-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stemhist] Integration tests & fixes #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not in the parts you changed, but here, for the record, are the things that concern me most in stemhist.py
:
193 -- print
statement needs paretheses
205 -- exe_dir
undefined
463 -- TTLibErorr
undefined
469 -- fontFileName
undefined
Since this is going to be replaced by psautohint
, I'm going to try not to worry about it too much. 😝
Note that it is still possible to build |
I just tried that and it seems to work with the few fonts I threw on it. |
@khaledhosny would you be opposed to including |
No objection, though I don’t know how to that (and the current build system I have for building |
OK. For now I'm going to open an issue to track it. |
No description provided.