Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotfexe] subtable offset too large #746

Closed
BoldMonday opened this issue Feb 26, 2019 · 1 comment
Closed

[makeotfexe] subtable offset too large #746

BoldMonday opened this issue Feb 26, 2019 · 1 comment

Comments

@BoldMonday
Copy link

After installing the latest afdko via pip (2.8.5) I am still experiencing problems when compiling one of our fonts that has a large aalt feature and a very large gsub table spread over several features.

Attempt 1:

makeotfexe [FATAL] <Logical> subtable offset too large (12948) in lookup 0 type 1

Attempt 2 with useExtension in aalt feature:

makeotfexe [FATAL] <Logical> subtable offset too large (12948) in lookup 0 type 7

Attempt 3 with removed aalt feature:

Built release mode font 'Logical.otf' Revision 1.003
@BoldMonday
Copy link
Author

Important to note is that even though the last attempt produced a working otf file, there are problems when decompiling it with ttx:

Dumping "Logical-01020304-7078-no-aalt-2.otf" to "Logical-01020304-7078-no-aalt-2.ttx"...
Dumping 'GlyphOrder' table...
Dumping 'head' table...
Dumping 'hhea' table...
Dumping 'maxp' table...
Dumping 'OS/2' table...
Dumping 'name' table...
Dumping 'cmap' table...
Dumping 'post' table...
Dumping 'CFF ' table...
Dumping 'GPOS' table...
Dumping 'GSUB' table...
WARNING: name id 38698 missing from name table
WARNING: name id 38698 missing from name table
WARNING: name id 38698 missing from name table
WARNING: name id 38698 missing from name table
WARNING: name id 38698 missing from name table
WARNING: name id 40378 missing from name table
WARNING: name id 40378 missing from name table
WARNING: name id 40378 missing from name table
WARNING: name id 40378 missing from name table
WARNING: name id 40378 missing from name table
WARNING: name id 40458 missing from name table
WARNING: name id 40458 missing from name table
WARNING: name id 40458 missing from name table
WARNING: name id 40458 missing from name table
WARNING: name id 40458 missing from name table
WARNING: name id 42770 missing from name table
WARNING: name id 42770 missing from name table
WARNING: name id 42770 missing from name table
WARNING: name id 42770 missing from name table
WARNING: name id 42770 missing from name table
WARNING: name id 41610 missing from name table
WARNING: name id 41610 missing from name table
WARNING: name id 41610 missing from name table
WARNING: name id 41610 missing from name table
WARNING: name id 41610 missing from name table
WARNING: name id 42834 missing from name table
WARNING: name id 42834 missing from name table
WARNING: name id 42834 missing from name table
WARNING: name id 42834 missing from name table
WARNING: name id 42834 missing from name table
WARNING: name id 44196 missing from name table
WARNING: name id 44196 missing from name table
WARNING: name id 44196 missing from name table
WARNING: name id 44196 missing from name table
WARNING: name id 44196 missing from name table
Dumping 'hmtx' table...
Dumping 'DSIG' table...

@miguelsousa miguelsousa changed the title [makeotf] subtable offset too large [makeotfexe] subtable offset too large Feb 27, 2019
miguelsousa pushed a commit that referenced this issue Mar 7, 2019
There were two bugs. One issue is that the overflow detection happened before the final offset adjustment was done, so that it could miss a small offset overflow. The other issue, which caused the reported bug, is that the field checked was an unsigned short, a 16 bit number, and could not hold an offset value larger than 64K.

Fixes #746
miguelsousa added a commit that referenced this issue Mar 7, 2019
@miguelsousa miguelsousa self-assigned this Mar 7, 2019
miguelsousa added a commit that referenced this issue Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants