Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support W3C get active element command #607

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Support W3C get active element command #607

merged 1 commit into from
Nov 7, 2019

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Oct 27, 2019 •
edited
Loading

/element/active requires POST method in JsonWireProtocol but W3C WebDriver spec requires GET method.

https://www.w3.org/TR/webdriver/#get-active-element

This patch checks remote WebDriver server speaks JWP or W3C on creating a session and remembers it. Then switch method of /element/active looking the flag.

@rhysd
support W3C get active element command
7bfdf92 
/element/active requires POST method in JWP but W3C WebDriver spec
requires GET method.

https://www.w3.org/TR/webdriver/#get-active-element

This patch checks remote WebDriver server speaks JWP or W3C on creating
a session and remember it. Then switch method of /element/active
looksing the flag.
@rhysd
Copy link
Contributor Author

rhysd commented Oct 28, 2019

CI failure seems not related to changes by this PR:

[12:10:27] 'sc:start' errored after 1.03 min
[12:10:27] Error: Could not start Sauce Connect. Exit code 1 signal: null
    at ChildProcess.<anonymous> (/home/travis/build/admc/wd/node_modules/sauce-connect-launcher/lib/sauce-connect-launcher.js:561:12)
    at ChildProcess.emit (events.js:198:13)
    at ChildProcess.EventEmitter.emit (domain.js:466:23)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)

@admc admc merged commit b150ce2 into admc:master Nov 7, 2019
@admc
Copy link
Owner

admc commented Nov 7, 2019

Thanks!

@imurchie imurchie mentioned this pull request Jan 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhysd @admc