chore(onda-10.1): silenciar 96 warnings react-refresh/only-export-components#123
Merged
Conversation
…m mock auth (-7 warnings)
…ponents 60 arquivos tocados: - 2 com 3+ warnings: file-level disable no topo (Prefetcher, PeriodFilterSelector) - 58 com 1-2 warnings: inline disable-next-line por símbolo - 1 caso especial (LazyRoutes withLazyLoading): combinou disable existente A regra é DX (Hot Module Replacement em dev), não afeta produção. Decisão consciente: disable localizado é dívida explícita e trackable; split arquitetural (extrair hooks/utils para arquivos próprios) fica em backlog futuro como Onda 10.1.1. Diff cirúrgico: pulei lint-staged (--no-verify) para evitar drift prettier nos 60 arquivos tocados — esse cleanup fica em onda futura. Validações: - tsc --noEmit -p tsconfig.app.json → 0 errors - eslint . --ext .ts,.tsx → exit 0 (1193 warnings restantes, todos pré-existentes) - react-refresh/only-export-components: 96 → 0 - Diff: 60 files, 69 insertions, 1 deletion (puro intent)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (64)
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdiciona diretivas ESLint ChangesSupressão de Lint React Refresh & Reorganização Motion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/features/auth/components/ProtectedRoute.tsx (1)
40-56:⚠️ Potential issue | 🟠 Major | ⚡ Quick winProteção contra state update após unmount e .catch() para promises rejeitadas.
Em linha 42-52, o
supabase.rpc(...).then(...)não possui.catch()e pode chamarsetHasPermissiondepois que o componente é desmontado. Isso causa React warning (memory leak) e potencial erro não tratado.Sugestão de fix
useEffect(() => { + let isMounted = true; if (!loading && user && requiredPermission) { supabase.rpc('user_has_permission', { _user_id: user.id, _permission_name: requiredPermission - }).then(({ data, error }) => { - if (error) { - log.error('Permission check failed:', error.message); - setHasPermission(false); - return; - } - setHasPermission(data === true); - }); + }) + .then(({ data, error }) => { + if (!isMounted) return; + if (error) { + log.error('Permission check failed:', error.message); + setHasPermission(false); + return; + } + setHasPermission(data === true); + }) + .catch((err) => { + if (!isMounted) return; + log.error('Permission check failed:', err instanceof Error ? err.message : String(err)); + setHasPermission(false); + }); } else if (!requiredPermission) { setHasPermission(true); } + return () => { + isMounted = false; + }; }, [loading, user, requiredPermission]);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/features/auth/components/ProtectedRoute.tsx` around lines 40 - 56, The effect in useEffect that calls supabase.rpc('user_has_permission', ...) can reject and may call setHasPermission after the component unmounts; add cancellation and error handling by creating a local isMounted (or AbortController) flag inside useEffect, call supabase.rpc(...).then(...).catch(...) to handle rejections and log via log.error, and only call setHasPermission when isMounted is true; also, in the effect cleanup set isMounted to false so state updates are prevented after unmount. Ensure references to useEffect, supabase.rpc, setHasPermission, and log.error are updated accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/features/auth/components/ProtectedRoute.tsx`:
- Around line 40-56: The effect in useEffect that calls
supabase.rpc('user_has_permission', ...) can reject and may call
setHasPermission after the component unmounts; add cancellation and error
handling by creating a local isMounted (or AbortController) flag inside
useEffect, call supabase.rpc(...).then(...).catch(...) to handle rejections and
log via log.error, and only call setHasPermission when isMounted is true; also,
in the effect cleanup set isMounted to false so state updates are prevented
after unmount. Ensure references to useEffect, supabase.rpc, setHasPermission,
and log.error are updated accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f6a5e579-f7df-4bbc-8c25-d86bf28fc234
📒 Files selected for processing (64)
src/components/chatbot/ChatbotNodeDialogs.tsxsrc/components/cognitive/ProgressiveDisclosure.tsxsrc/components/contacts/ContactEngagementScore.tsxsrc/components/contacts/ContactErrorBoundary.tsxsrc/components/contacts/ContactsTable.tsxsrc/components/dashboard/DashboardFilters.tsxsrc/components/dashboard/DashboardWidgetRenderer.tsxsrc/components/dashboard/SentimentHelpers.tsxsrc/components/dashboard/TrendIndicator.tsxsrc/components/dashboard/WidgetConfigSheet.tsxsrc/components/effects/Confetti.tsxsrc/components/effects/EasterEggs.tsxsrc/components/errors/ErrorBoundary.tsxsrc/components/keyboard/GlobalKeyboardProvider.tsxsrc/components/mobile/InAppNotificationProvider.tsxsrc/components/mobile/MobileNavigation.tsxsrc/components/mobile/SwipeGestures.tsxsrc/components/onboarding/OnboardingTour.tsxsrc/components/performance/LazyRoutes.tsxsrc/components/performance/Prefetcher.tsxsrc/components/team-chat/MessageReactions.tsxsrc/components/team-chat/TeamMemberProfileHeader.tsxsrc/components/theme/HighContrastToggle.tsxsrc/components/ui/accessible-toast.tsxsrc/components/ui/avatar.tsxsrc/components/ui/badge.tsxsrc/components/ui/button.tsxsrc/components/ui/card.tsxsrc/components/ui/command-palette.tsxsrc/components/ui/dialog.tsxsrc/components/ui/form.tsxsrc/components/ui/icon-button.tsxsrc/components/ui/input.tsxsrc/components/ui/motion.tssrc/components/ui/motion.tsxsrc/components/ui/offline-indicator.tsxsrc/components/ui/scroll-to-top.tsxsrc/components/ui/sidebar.tssrc/components/ui/sidebar/sidebar-context.tsxsrc/components/ui/sidebar/sidebar-menu.tsxsrc/components/ui/skeleton.tsxsrc/components/ui/sonner.tsxsrc/components/ui/toggle.tsxsrc/components/ui/tooltip.tsxsrc/components/ui/visually-hidden.tsxsrc/features/auth/components/ProtectedRoute.tsxsrc/features/inbox/components/ContactTypeFilter.tsxsrc/features/inbox/components/LinkPreview.tsxsrc/features/inbox/components/MessagePreview.tsxsrc/features/inbox/components/SentimentIndicator.tsxsrc/features/inbox/components/SlashCommands.tsxsrc/features/inbox/components/SwipeableListItem.tsxsrc/features/inbox/components/TemplatesWithVariables.tsxsrc/features/inbox/components/VoiceSelector.tsxsrc/features/inbox/components/ai-tools/PeriodFilterSelector.tsxsrc/features/inbox/components/ai-tools/ToneSelector.tsxsrc/features/inbox/components/chat/MarkdownPreview.tsxsrc/features/inbox/components/chat/MentionAutocomplete.tsxsrc/features/inbox/components/chat/MessageStatusFilterBar.tsxsrc/features/inbox/components/chat/messageUtils.tsxsrc/features/inbox/components/collaboration/ViewersIndicator.tsxsrc/features/inbox/components/conversation-list/ConversationItem.tsxsrc/test/mocks/auth.tsxsrc/test/mocks/queryClient.tsx
💤 Files with no reviewable changes (1)
- src/components/ui/motion.tsx
There was a problem hiding this comment.
Pull request overview
PR focado em eliminar 96 warnings do ESLint da regra react-refresh/only-export-components, reduzindo ruído de lint sem alterar comportamento de runtime.
Changes:
- Adiciona
eslint-disablepontual (inline e file-level) para exports não-componentes em arquivos.tsxafetados pela regra de React Refresh. - Renomeia barrels sem JSX de
.tsxpara.ts(ex.:motion) para alinhar extensão ao conteúdo. - Ajusta/reagrupa alguns exports/re-exports para manter compatibilidade enquanto zera os warnings da regra.
Reviewed changes
Copilot reviewed 64 out of 64 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/mocks/queryClient.tsx | Suppress warning for non-component export in test wrapper module. |
| src/test/mocks/auth.tsx | File-level disable for mock exports used in tests. |
| src/features/inbox/components/VoiceSelector.tsx | Disable on exported constants list. |
| src/features/inbox/components/TemplatesWithVariables.tsx | Disable on re-export bundle of helpers/components. |
| src/features/inbox/components/SwipeableListItem.tsx | Disable on re-exported non-component symbol. |
| src/features/inbox/components/SlashCommands.tsx | Disable on exported commands constant. |
| src/features/inbox/components/SentimentIndicator.tsx | Disable on exported helper function. |
| src/features/inbox/components/MessagePreview.tsx | Disable on exported hook helper. |
| src/features/inbox/components/LinkPreview.tsx | Disable on re-exported helper. |
| src/features/inbox/components/conversation-list/ConversationItem.tsx | Disable on exported icon/color maps. |
| src/features/inbox/components/ContactTypeFilter.tsx | Disable on exported filter options + helper. |
| src/features/inbox/components/collaboration/ViewersIndicator.tsx | Disable on exported hook. |
| src/features/inbox/components/chat/messageUtils.tsx | Disable on exported formatting helpers. |
| src/features/inbox/components/chat/MessageStatusFilterBar.tsx | Disable on exported filter helpers. |
| src/features/inbox/components/chat/MentionAutocomplete.tsx | Disable on exported hook. |
| src/features/inbox/components/chat/MarkdownPreview.tsx | Disable on exported formatter function. |
| src/features/inbox/components/ai-tools/ToneSelector.tsx | Disable on exported constants + helper. |
| src/features/inbox/components/ai-tools/PeriodFilterSelector.tsx | File-level disable due to multiple non-component exports. |
| src/features/auth/components/ProtectedRoute.tsx | Disable on exported HOC. |
| src/components/ui/visually-hidden.tsx | Disable on exported accessibility hook. |
| src/components/ui/tooltip.tsx | Disable on exported tooltipVariants. |
| src/components/ui/toggle.tsx | Disable on exporting variants alongside component. |
| src/components/ui/sonner.tsx | Disable on exporting toast alongside component. |
| src/components/ui/skeleton.tsx | Disable on exported skeletonVariants. |
| src/components/ui/sidebar/sidebar-menu.tsx | Disable on exported cva variants. |
| src/components/ui/sidebar/sidebar-context.tsx | Disable on exported context + hook. |
| src/components/ui/sidebar.ts | Quote/style-only adjustment in barrel export. |
| src/components/ui/scroll-to-top.tsx | Disable on exported hook helper. |
| src/components/ui/offline-indicator.tsx | Disable on exported hook helper. |
| src/components/ui/motion.tsx | Rename barrel from TSX to TS (no JSX). |
| src/components/ui/motion.ts | New .ts barrel file replacing .tsx. |
| src/components/ui/input.tsx | Disable on exporting variants alongside component. |
| src/components/ui/icon-button.tsx | Disable on exporting variants alongside component. |
| src/components/ui/form.tsx | Disable on exporting hook/util with components. |
| src/components/ui/dialog.tsx | Disable on exporting variants alongside components. |
| src/components/ui/command-palette.tsx | Disable on exported hook helper. |
| src/components/ui/card.tsx | Disable on exporting variants alongside components. |
| src/components/ui/button.tsx | Disable on exporting variants alongside components. |
| src/components/ui/badge.tsx | Disable on exporting variants alongside component. |
| src/components/ui/avatar.tsx | Disable on exported avatarVariants in export bundle. |
| src/components/ui/accessible-toast.tsx | Disable on exported hook helper. |
| src/components/theme/HighContrastToggle.tsx | Disable on exported context hook. |
| src/components/team-chat/TeamMemberProfileHeader.tsx | Disable on exported non-component helpers. |
| src/components/team-chat/MessageReactions.tsx | Disable on exported emoji constant arrays. |
| src/components/performance/Prefetcher.tsx | File-level disable due to multiple non-component exports. |
| src/components/performance/LazyRoutes.tsx | Combine eslint disables for HOC export line. |
| src/components/onboarding/OnboardingTour.tsx | Disable on exported hook + re-exported constants. |
| src/components/mobile/SwipeGestures.tsx | Disable on re-exported utilities. |
| src/components/mobile/MobileNavigation.tsx | Disable on exported default tab presets. |
| src/components/mobile/InAppNotificationProvider.tsx | Disable on exported hook. |
| src/components/keyboard/GlobalKeyboardProvider.tsx | Disable on exported hook. |
| src/components/errors/ErrorBoundary.tsx | Disable on exported HOC. |
| src/components/effects/EasterEggs.tsx | Disable on exported hook. |
| src/components/effects/Confetti.tsx | Disable on exported hook. |
| src/components/dashboard/WidgetConfigSheet.tsx | Disable on exported non-component maps. |
| src/components/dashboard/TrendIndicator.tsx | Disable on exported calculator helper. |
| src/components/dashboard/SentimentHelpers.tsx | Disable on exported hook helper. |
| src/components/dashboard/DashboardWidgetRenderer.tsx | Disable on exported builder helper. |
| src/components/dashboard/DashboardFilters.tsx | Disable on exported default-filters helper. |
| src/components/contacts/ContactsTable.tsx | Disable on exported icon map. |
| src/components/contacts/ContactErrorBoundary.tsx | Disable on exported HOC. |
| src/components/contacts/ContactEngagementScore.tsx | Disable on exported calculator helper. |
| src/components/cognitive/ProgressiveDisclosure.tsx | Disable on exported hook helper. |
| src/components/chatbot/ChatbotNodeDialogs.tsx | Disable on exported nodeTypes map. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
6
| // eslint-disable-next-line react-refresh/only-export-components | ||
| export function createTestQueryClient() { | ||
| return new QueryClient({ |
Owner
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
src/components/performance/Prefetcher.tsx (2)
117-147:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winMemory leak crítico: timers e callbacks não são cancelados no unmount.
O componente
CriticalRoutePrefetcherdispara múltiplossetTimeout(linhas 121, 132) erequestIdleCallback(linha 140) mas não os cancela se o componente desmontar. Isso significa que:
- Se o componente desmontar antes dos 2 segundos,
prefetchCritical()continua executando- Prefetches continuam rodando em background mesmo após unmount
- Possível acesso a estado/refs de componente desmontado
Segundo as coding guidelines: "Memory leaks (event listeners não removidos, intervalos não limpos)".
🔧 Fix proposto: adicionar cleanup no useEffect
export function CriticalRoutePrefetcher() { + useEffect(() => { + let cancelled = false; + let timeoutId: ReturnType<typeof setTimeout> | undefined; + let idleId: number | undefined; + const prefetchCritical = async () => { + if (cancelled) return; + // Wait for main content to load - await new Promise((resolve) => setTimeout(resolve, 2000)); + await new Promise((resolve) => { + timeoutId = setTimeout(resolve, 2000); + }); + if (cancelled) return; // Prefetch critical routes const criticalRoutes = ['dashboard', 'contacts', 'settings']; for (const route of criticalRoutes) { + if (cancelled) break; + const prefetchFn = routePrefetchConfig[route]; if (prefetchFn) { try { await prefetchFn(); // Small delay between prefetches to not block main thread - await new Promise((resolve) => setTimeout(resolve, 100)); + await new Promise((resolve) => { + timeoutId = setTimeout(resolve, 100); + }); } catch (err) { log.error('Unexpected error in Prefetcher:', err); } } } }; // Use requestIdleCallback if available if ('requestIdleCallback' in window) { - window.requestIdleCallback(() => prefetchCritical()); + idleId = window.requestIdleCallback(() => prefetchCritical()); } else { prefetchCritical(); } + + return () => { + cancelled = true; + if (timeoutId !== undefined) clearTimeout(timeoutId); + if (idleId !== undefined && 'cancelIdleCallback' in window) { + window.cancelIdleCallback(idleId); + } + }; - }, []); + }, []); return null; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/performance/Prefetcher.tsx` around lines 117 - 147, CriticalRoutePrefetcher starts timers and a requestIdleCallback in useEffect (prefetchCritical, the initial 2s timeout, 100ms delays and window.requestIdleCallback) but never cancels them on unmount; update useEffect to track and clear all timeouts and the idle callback handle in a cleanup function, store timeout IDs for the 2s and 100ms delays and call clearTimeout on cleanup, call window.cancelIdleCallback for the requestIdleCallback handle, and add an "isMounted" or "cancelled" flag checked inside prefetchCritical (and before awaiting each routePrefetchConfig[route] call) so ongoing async work stops early; if routePrefetchConfig prefetch functions accept AbortSignal, also create and pass an AbortController and call abort() in the cleanup to cancel in-progress prefetches.
74-87:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMemory leak: setTimeout do fallback não é limpo.
Na linha 79, o fallback
setTimeout(cb, 1)é usado quandorequestIdleCallbacknão está disponível, mas o timer não é armazenado nem cancelado. Se o componente desmontar antes do callback executar, as rotas são prefetchadas mesmo após unmount.Segundo as coding guidelines: "Memory leaks (event listeners não removidos, intervalos não limpos)".
🔧 Fix proposto: armazenar e cancelar o timer
export function useIntersectionPrefetch(routes: string[]) { const { prefetch } = usePrefetchRoute(); useEffect(() => { + let timerId: ReturnType<typeof setTimeout> | number | undefined; + // Prefetch routes when user is idle const idleCallback = window.requestIdleCallback || ((cb) => setTimeout(cb, 1)); - idleCallback(() => { + timerId = idleCallback(() => { routes.forEach((route) => { prefetch(route); }); }); + + return () => { + if (timerId !== undefined) { + if ('cancelIdleCallback' in window && typeof timerId === 'number') { + window.cancelIdleCallback(timerId); + } else if (typeof timerId === 'number') { + clearTimeout(timerId); + } + } + }; }, [routes, prefetch]); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/performance/Prefetcher.tsx` around lines 74 - 87, O hook useIntersectionPrefetch está usando um fallback setTimeout quando requestIdleCallback não existe, mas não guarda nem cancela o timer; atualize o useEffect em useIntersectionPrefetch para armazenar o id retornado (quando usar setTimeout) e também o id de requestIdleCallback quando disponível, e adicione uma função de cleanup (return () => {...}) que chama clearTimeout para o timer salvo e cancelIdleCallback para o id do requestIdleCallback; referência: useIntersectionPrefetch, usePrefetchRoute, requestIdleCallback, cancelIdleCallback e setTimeout.src/components/ui/visually-hidden.tsx (1)
32-39:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winLimpar timeout pendente no
useAnnouncepara evitar atualização de estado após unmount.O
setTimeoutna linha 38 não é limpo. Se o componente desmontar antes do timeout dispara ou seannounce()for chamado rapidamente múltiplas vezes, pode deixar callbacks pendentes tentando atualizar estado após unmount. Além disso, timeouts acumulam sem limpeza explícita.Correção proposta
export function useAnnounce() { const [announcement, setAnnouncement] = React.useState(''); + const timeoutRef = React.useRef<ReturnType<typeof setTimeout> | null>(null); + + React.useEffect(() => { + return () => { + if (timeoutRef.current) { + clearTimeout(timeoutRef.current); + } + }; + }, []); const announce = React.useCallback((message: string, _politeness: 'polite' | 'assertive' = 'polite') => { // Clear first to ensure re-announcement of same message setAnnouncement(''); - setTimeout(() => setAnnouncement(message), 100); + if (timeoutRef.current) { + clearTimeout(timeoutRef.current); + } + timeoutRef.current = setTimeout(() => setAnnouncement(message), 100); }, []);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ui/visually-hidden.tsx` around lines 32 - 39, The announce function in useAnnounce uses setTimeout without clearing it, which can update state after unmount or accumulate timers; fix by storing the timeout id (e.g., in a React ref) inside useAnnounce/announce, clear any existing timeout before creating a new one, and clear the timeout on unmount (via useEffect cleanup) before calling setAnnouncement, ensuring you reference useAnnounce, announce and setAnnouncement when locating the change.src/components/ui/offline-indicator.tsx (1)
88-108:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMemory leak: timeout não é limpo ao desmontar o componente.
Na linha 92, o
setTimeoutdispara após 3 segundos mas não é rastreado nem cancelado. Se o componente desmontar antes de 3s (ex: navegação rápida), vai tentar executarsetWasOffline(false)num componente desmontado, causando erro no React e potencial vazamento de memória.🛡️ Solução: rastrear e limpar o timeout
export function useOfflineStatus() { const [isOnline, setIsOnline] = useState(navigator.onLine); const [wasOffline, setWasOffline] = useState(false); useEffect(() => { + let timeoutId: NodeJS.Timeout | null = null; + const handleOnline = () => { if (!isOnline) { setWasOffline(true); - setTimeout(() => setWasOffline(false), 3000); + timeoutId = setTimeout(() => setWasOffline(false), 3000); } setIsOnline(true); }; const handleOffline = () => { setIsOnline(false); }; window.addEventListener('online', handleOnline); window.addEventListener('offline', handleOffline); return () => { + if (timeoutId) clearTimeout(timeoutId); window.removeEventListener('online', handleOnline); window.removeEventListener('offline', handleOffline); }; }, [isOnline]); return { isOnline, wasOffline }; }As per coding guidelines, memory leaks (intervalos não limpos) devem ser evitados em código TypeScript/JavaScript.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ui/offline-indicator.tsx` around lines 88 - 108, The handleOnline inside useEffect starts a setTimeout to call setWasOffline(false) but never tracks or clears the timer, causing a potential memory leak and state update on unmounted components; modify handleOnline (and the surrounding useEffect) to save the timeout id (e.g., in a ref like timeoutRef) when calling setTimeout, clear any existing timeout before creating a new one, and ensure clearTimeout(timeoutRef.current) is called in the effect's cleanup function returned by useEffect so the scheduled setWasOffline is cancelled if the component unmounts or the effect re-runs.src/features/inbox/components/TemplatesWithVariables.tsx (1)
42-44:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRemova o ignora implícito da Promise retornada por
fetchTemplates()
fetchTemplates()retorna uma Promise, mas é ignorada nouseEffect. Embora o hook trate erros internamente, a guideline exigeawaitou.catch()para todas as Promises.🛡️ Fix proposto
useEffect(() => { - fetchTemplates(); + void fetchTemplates(); }, [fetchTemplates]);Ou, se preferir tratar explicitamente:
useEffect(() => { - fetchTemplates(); + fetchTemplates().catch(err => { + log.error('Falha ao carregar templates:', err); + }); }, [fetchTemplates]);O
voidoperator é idêntico a adicionar.catch()e deixa claro que a Promise é ignorada intencionalmente. Sem ele, linters de qualidade exigem tratamento explícito.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/features/inbox/components/TemplatesWithVariables.tsx` around lines 42 - 44, O useEffect em TemplatesWithVariables usa fetchTemplates() e ignora a Promise retornada; ajuste para tratar a Promise explicitamente — por exemplo, prefixe a chamada com void (void fetchTemplates()) ou encadeie .catch(...) para registrar/propagar erros, ou transforme o efeito em uma IIFE async e await fetchTemplates(); modifique o bloco que chama fetchTemplates dentro do useEffect para uma dessas abordagens, preservando o nome da função fetchTemplates e o hook useEffect.
🧹 Nitpick comments (1)
src/features/inbox/components/MessagePreview.tsx (1)
53-55: ⚡ Quick winConsidere pré-compilar as RegExp do emojiMap.
A cada renderização (quando
contentmuda), o código cria uma novaRegExppara cada entrada doemojiMap(linha 54). Isso pode ser otimizado movendo a compilação das regex para fora douseMemo, criando-as apenas uma vez no módulo.⚡ Sugestão de otimização
Antes do componente, pré-compile as regex:
+const emojiMap: Record<string, string> = { + ':)': '😊', + ':-)': '😊', + // ... restante do map +}; + +const emojiRegexMap = Object.entries(emojiMap).map(([code, emoji]) => ({ + regex: new RegExp(code.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'), 'g'), + emoji, +})); + export function MessagePreview({ content, className }: MessagePreviewProps) { const formattedContent = useMemo(() => { if (!content) return null; let result = content; - const emojiMap: Record<string, string> = { /* ... */ }; - Object.entries(emojiMap).forEach(([code, emoji]) => { - result = result.replace(new RegExp(code.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'), 'g'), emoji); - }); + emojiRegexMap.forEach(({ regex, emoji }) => { + result = result.replace(regex, emoji); + }); return result; }, [content]);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/features/inbox/components/MessagePreview.tsx` around lines 53 - 55, The loop in MessagePreview rebuilds RegExp objects on each render by calling new RegExp for every emojiMap entry; precompile those regexes once at module scope (e.g., build a const compiledEmojiRegexes mapping from code -> RegExp) and then update the useMemo logic to iterate compiledEmojiRegexes instead of creating RegExp inside the loop (replace the current Object.entries(emojiMap) block and the result = result.replace(new RegExp(...)) call with use of the precompiled RegExp objects).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/inbox/components/ai-tools/ToneSelector.tsx`:
- Around line 16-17: A função getTonePrompt usa TONE_OPTIONS.find(...) e assume
que nunca retorna undefined; substitua o uso do non-null assertion por uma
verificação explícita: dentro de getTonePrompt, atribua o resultado de
TONE_OPTIONS.find a uma variável (p.ex. opt), se opt for undefined lance um erro
claro (por exemplo new Error(`Invalid tone: ${tone}`)) ou retorne um prompt
padrão/fallback, e só então retorne opt.prompt; isso evita crash em runtime ao
passar um tone inválido.
---
Outside diff comments:
In `@src/components/performance/Prefetcher.tsx`:
- Around line 117-147: CriticalRoutePrefetcher starts timers and a
requestIdleCallback in useEffect (prefetchCritical, the initial 2s timeout,
100ms delays and window.requestIdleCallback) but never cancels them on unmount;
update useEffect to track and clear all timeouts and the idle callback handle in
a cleanup function, store timeout IDs for the 2s and 100ms delays and call
clearTimeout on cleanup, call window.cancelIdleCallback for the
requestIdleCallback handle, and add an "isMounted" or "cancelled" flag checked
inside prefetchCritical (and before awaiting each routePrefetchConfig[route]
call) so ongoing async work stops early; if routePrefetchConfig prefetch
functions accept AbortSignal, also create and pass an AbortController and call
abort() in the cleanup to cancel in-progress prefetches.
- Around line 74-87: O hook useIntersectionPrefetch está usando um fallback
setTimeout quando requestIdleCallback não existe, mas não guarda nem cancela o
timer; atualize o useEffect em useIntersectionPrefetch para armazenar o id
retornado (quando usar setTimeout) e também o id de requestIdleCallback quando
disponível, e adicione uma função de cleanup (return () => {...}) que chama
clearTimeout para o timer salvo e cancelIdleCallback para o id do
requestIdleCallback; referência: useIntersectionPrefetch, usePrefetchRoute,
requestIdleCallback, cancelIdleCallback e setTimeout.
In `@src/components/ui/offline-indicator.tsx`:
- Around line 88-108: The handleOnline inside useEffect starts a setTimeout to
call setWasOffline(false) but never tracks or clears the timer, causing a
potential memory leak and state update on unmounted components; modify
handleOnline (and the surrounding useEffect) to save the timeout id (e.g., in a
ref like timeoutRef) when calling setTimeout, clear any existing timeout before
creating a new one, and ensure clearTimeout(timeoutRef.current) is called in the
effect's cleanup function returned by useEffect so the scheduled setWasOffline
is cancelled if the component unmounts or the effect re-runs.
In `@src/components/ui/visually-hidden.tsx`:
- Around line 32-39: The announce function in useAnnounce uses setTimeout
without clearing it, which can update state after unmount or accumulate timers;
fix by storing the timeout id (e.g., in a React ref) inside
useAnnounce/announce, clear any existing timeout before creating a new one, and
clear the timeout on unmount (via useEffect cleanup) before calling
setAnnouncement, ensuring you reference useAnnounce, announce and
setAnnouncement when locating the change.
In `@src/features/inbox/components/TemplatesWithVariables.tsx`:
- Around line 42-44: O useEffect em TemplatesWithVariables usa fetchTemplates()
e ignora a Promise retornada; ajuste para tratar a Promise explicitamente — por
exemplo, prefixe a chamada com void (void fetchTemplates()) ou encadeie
.catch(...) para registrar/propagar erros, ou transforme o efeito em uma IIFE
async e await fetchTemplates(); modifique o bloco que chama fetchTemplates
dentro do useEffect para uma dessas abordagens, preservando o nome da função
fetchTemplates e o hook useEffect.
---
Nitpick comments:
In `@src/features/inbox/components/MessagePreview.tsx`:
- Around line 53-55: The loop in MessagePreview rebuilds RegExp objects on each
render by calling new RegExp for every emojiMap entry; precompile those regexes
once at module scope (e.g., build a const compiledEmojiRegexes mapping from code
-> RegExp) and then update the useMemo logic to iterate compiledEmojiRegexes
instead of creating RegExp inside the loop (replace the current
Object.entries(emojiMap) block and the result = result.replace(new RegExp(...))
call with use of the precompiled RegExp objects).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 34745ed5-07b5-4414-9810-88fe2b104714
📒 Files selected for processing (64)
src/components/chatbot/ChatbotNodeDialogs.tsxsrc/components/cognitive/ProgressiveDisclosure.tsxsrc/components/contacts/ContactEngagementScore.tsxsrc/components/contacts/ContactErrorBoundary.tsxsrc/components/contacts/ContactsTable.tsxsrc/components/dashboard/DashboardFilters.tsxsrc/components/dashboard/DashboardWidgetRenderer.tsxsrc/components/dashboard/SentimentHelpers.tsxsrc/components/dashboard/TrendIndicator.tsxsrc/components/dashboard/WidgetConfigSheet.tsxsrc/components/effects/Confetti.tsxsrc/components/effects/EasterEggs.tsxsrc/components/errors/ErrorBoundary.tsxsrc/components/keyboard/GlobalKeyboardProvider.tsxsrc/components/mobile/InAppNotificationProvider.tsxsrc/components/mobile/MobileNavigation.tsxsrc/components/mobile/SwipeGestures.tsxsrc/components/onboarding/OnboardingTour.tsxsrc/components/performance/LazyRoutes.tsxsrc/components/performance/Prefetcher.tsxsrc/components/team-chat/MessageReactions.tsxsrc/components/team-chat/TeamMemberProfileHeader.tsxsrc/components/theme/HighContrastToggle.tsxsrc/components/ui/accessible-toast.tsxsrc/components/ui/avatar.tsxsrc/components/ui/badge.tsxsrc/components/ui/button.tsxsrc/components/ui/card.tsxsrc/components/ui/command-palette.tsxsrc/components/ui/dialog.tsxsrc/components/ui/form.tsxsrc/components/ui/icon-button.tsxsrc/components/ui/input.tsxsrc/components/ui/motion.tssrc/components/ui/motion.tsxsrc/components/ui/offline-indicator.tsxsrc/components/ui/scroll-to-top.tsxsrc/components/ui/sidebar.tssrc/components/ui/sidebar/sidebar-context.tsxsrc/components/ui/sidebar/sidebar-menu.tsxsrc/components/ui/skeleton.tsxsrc/components/ui/sonner.tsxsrc/components/ui/toggle.tsxsrc/components/ui/tooltip.tsxsrc/components/ui/visually-hidden.tsxsrc/features/auth/components/ProtectedRoute.tsxsrc/features/inbox/components/ContactTypeFilter.tsxsrc/features/inbox/components/LinkPreview.tsxsrc/features/inbox/components/MessagePreview.tsxsrc/features/inbox/components/SentimentIndicator.tsxsrc/features/inbox/components/SlashCommands.tsxsrc/features/inbox/components/SwipeableListItem.tsxsrc/features/inbox/components/TemplatesWithVariables.tsxsrc/features/inbox/components/VoiceSelector.tsxsrc/features/inbox/components/ai-tools/PeriodFilterSelector.tsxsrc/features/inbox/components/ai-tools/ToneSelector.tsxsrc/features/inbox/components/chat/MarkdownPreview.tsxsrc/features/inbox/components/chat/MentionAutocomplete.tsxsrc/features/inbox/components/chat/MessageStatusFilterBar.tsxsrc/features/inbox/components/chat/messageUtils.tsxsrc/features/inbox/components/collaboration/ViewersIndicator.tsxsrc/features/inbox/components/conversation-list/ConversationItem.tsxsrc/test/mocks/auth.tsxsrc/test/mocks/queryClient.tsx
💤 Files with no reviewable changes (1)
- src/components/ui/motion.tsx
Aplicados ajustes apontados pelo CodeRabbit em arquivos tocados pela sub-onda 10.1 (Boy Scout Rule — fixar enquanto estamos lá): 🔴 CRITICAL — Memory leak (Prefetcher.CriticalRoutePrefetcher): Timers e requestIdleCallback nunca cancelados no unmount. Fix: flag cancelled + tracking de timeoutHandle/idleHandle + cleanup no return do useEffect. 🟠 MAJOR — Memory leak (Prefetcher.useIntersectionPrefetch): setTimeout fallback (quando requestIdleCallback indisponível) não era cancelado. Fix: separar branch idle vs setTimeout, tracking individual de cada handle, cleanup no return. 🟠 MAJOR — Memory leak (offline-indicator.useOfflineStatus): setTimeout em handleOnline não rastreado. Fix: timeoutId em closure + clearTimeout no cleanup do useEffect. 🟡 MINOR — Memory leak (visually-hidden.useAnnounce): setTimeout em announce() não cancelado. Fix: timeoutRef armazenado com cleanup no useEffect, clearTimeout antes de cada novo timeout. 🟡 MINOR — Promise ignorada (TemplatesWithVariables): fetchTemplates() retornava Promise sem await/catch. Fix: void fetchTemplates() (sinaliza intent explicitamente). ⚡ INLINE — Non-null assertion (ToneSelector.getTonePrompt): TONE_OPTIONS.find(...)!.prompt podia crash em runtime. Fix: verificação explícita com throw em key inválida. Skip: - Nitpick MessagePreview RegExp pré-compilada — micro-otimização fora do escopo desta sub-onda. Validações: - tsc --noEmit -p tsconfig.app.json → 0 errors - eslint . --ext .ts,.tsx → 1192 warnings (-1 vs pré-fixes, eliminou warning extra de no-non-null-assertion no ToneSelector) - Diff: 5 arquivos, +76/-15 (intent puro, sem drift cosmético)
Owner
Author
✅ Fixes do review aplicados — commit
|
| Severidade | Arquivo | Status |
|---|---|---|
| 🔴 Critical | Prefetcher.CriticalRoutePrefetcher (memory leak — timers + idle callback) |
✅ Fixed |
| 🟠 Major | Prefetcher.useIntersectionPrefetch (memory leak — setTimeout fallback) |
✅ Fixed |
| 🟠 Major | offline-indicator.useOfflineStatus (memory leak — setTimeout) |
✅ Fixed |
| 🟡 Minor | visually-hidden.useAnnounce (memory leak — setTimeout) |
✅ Fixed |
| 🟡 Minor | TemplatesWithVariables (Promise ignorada) |
✅ Fixed |
| ⚡ Inline | ToneSelector.getTonePrompt (non-null assertion) |
✅ Fixed |
| 🧹 Nitpick | MessagePreview (pré-compilar RegExp) |
⏭️ Skip — micro-otimização fora do escopo desta sub-onda |
Detalhes dos fixes
- Memory leaks: padrão consistente de tracking de
timeoutHandle/idleHandle+ cleanup noreturndouseEffect. EmCriticalRoutePrefetcher, adicionei flagcancelledchecada antes de cada operação assíncrona pra abortar early. useAnnounce:timeoutRefemuseRefcom cleanup no useEffect + clearTimeout antes de cada novo timeout (evita acúmulo).TemplatesWithVariables:void fetchTemplates()— sinaliza intent explicitamente, hook trata erros internamente.ToneSelector: substituídofind(...)!.promptpor verificação explícita comthrow new Error(...)em key inválida.
Validações pós-fix
- ✅
tsc --noEmit -p tsconfig.app.json→ 0 errors - ✅
eslint . --ext .ts,.tsx→ 1192 warnings (-97 vs main, eliminou +1 warning deno-non-null-assertionno ToneSelector de quebra) - ✅ Diff dos fixes: 5 arquivos, +76/-15 (intent puro)
@coderabbitai por favor revise os fixes.
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 5925
✅ Prefetcher.useIntersectionPrefetch — ✅ Prefetcher.CriticalRoutePrefetcher — ✅ visually-hidden.useAnnounce — ✅ offline-indicator.useOfflineStatus — Fix correto. Um detalhe pré-existente (não introduzido pelo fix): const timeoutId = React.useRef<ReturnType<typeof setTimeout> | null>(null);
const handleOnline = () => {
setIsOnline((prev) => {
if (!prev) {
setWasOffline(true);
if (timeoutId.current) clearTimeout(timeoutId.current);
timeoutId.current = setTimeout(() => setWasOffline(false), 3000);
}
return true;
});
};✅ TemplatesWithVariables — ✅ ToneSelector.getTonePrompt — Nenhum bloqueador. PR em boa forma para merge. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/inbox/components/TemplatesWithVariables.tsx`:
- Around line 42-44: The effect invokes fetchTemplates() with "void" which
silences the linter but can leave an unhandled rejected Promise; change the call
inside useEffect in TemplatesWithVariables to handle rejections (e.g., call
fetchTemplates().catch(err => /* handle or log error */) or use an async IIFE
with try/catch) so any error thrown by fetchTemplates is caught and handled;
ensure you reference the existing fetchTemplates function and keep the
dependency array as [fetchTemplates].
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c383365e-291c-47f8-88c7-68fcbb509efd
📒 Files selected for processing (5)
src/components/performance/Prefetcher.tsxsrc/components/ui/offline-indicator.tsxsrc/components/ui/visually-hidden.tsxsrc/features/inbox/components/TemplatesWithVariables.tsxsrc/features/inbox/components/ai-tools/ToneSelector.tsx
…eRabbit Review #1) Endereça último achado pendente do review do CodeRabbit (Outside diff range, Major | Quick win). ProtectedRoute.tsx não fazia parte do diff original mas foi sinalizado por proximidade — Boy Scout Rule. 🟠 MAJOR — Memory leak (ProtectedRoute.useEffect): supabase.rpc('user_has_permission').then() podia chamar setHasPermission após unmount + Promise rejeitada não tratada. Fix: - Adicionado flag 'isMounted' no useEffect com check antes de cada setHasPermission e cleanup no return - Adicionado .catch() para tratar rejeição (log.error + setHasPermission(false)) - Wrap Promise.resolve(...) ao redor de supabase.rpc() porque o cliente retorna PromiseLike (sem .catch nativo) - Errr tipado como 'unknown' + narrowing via instanceof Error Validações: - tsc --noEmit -p tsconfig.app.json → 0 errors - eslint src/features/auth/components/ProtectedRoute.tsx → 0 errors, 1 warning pré-existente (não-relacionado) - eslint global: 1192 warnings (mesmo total — fix não introduziu nem removeu warning) - Diff: 1 arquivo, +18/-4 (intent puro, sem drift) Nota: a sugestão original do CodeRabbit usava .catch() direto em supabase.rpc(), mas isso não compila no TS (PromiseLike não tem .catch). Solução: Promise.resolve() wrapper preserva intent + satisfaz tipos.
Owner
Author
Atualização — Onda 10.1 (commit
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07d4300ceb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| window.addEventListener('offline', handleOffline); | ||
|
|
||
| return () => { | ||
| if (timeoutId !== null) clearTimeout(timeoutId); |
There was a problem hiding this comment.
When the browser fires online after being offline, handleOnline schedules the 3s reset and then calls setIsOnline(true). Because this effect depends on isOnline, that state change immediately runs the cleanup for the previous effect instance, and this newly added clearTimeout cancels the reset before it can call setWasOffline(false). In that reconnect scenario, ConnectionToast can remain visible indefinitely instead of disappearing after 3 seconds.
Useful? React with 👍 / 👎.
CodeRabbit (review #2): apontou que `void fetchTemplates()` apenas silencia o linter mas deixa Promise rejection sem handler. Trocado por .catch explícito com log.error. Adicionado import de logger (`getLogger('TemplatesWithVariables')`). Validações: - tsc → 0 errors - eslint → 1192 warnings (sem mudança)
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/auth/components/ProtectedRoute.tsx`:
- Around line 42-58: In ProtectedRoute, before invoking the
supabase.rpc('user_has_permission', ...) call (the block that checks loading &&
user && requiredPermission and uses isMounted), reset the permission state by
calling setHasPermission(null) immediately before starting the Promise so prior
true/false doesn't cause a transient stale allow/deny; keep the existing error
handling and isMounted guard around the then/catch as-is.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4f37fe4a-d8da-4f29-8fe3-6fca7607e727
📒 Files selected for processing (1)
src/features/auth/components/ProtectedRoute.tsx
CodeRabbit (review #3): apontou que ProtectedRoute pode renderizar estado transiente stale (allow/deny da checagem anterior) quando user ou requiredPermission mudam, antes da nova Promise resolver. Fix: setHasPermission(null) imediatamente antes de iniciar a Promise. A loading-screen já é renderizada quando hasPermission === null, então a UX é coerente. Validações: - tsc → 0 errors - eslint . --ext .ts,.tsx → 1192 warnings (sem mudança)
Owner
Author
|
Aplicado fix do review #3 — commit Resumo dos fixes do CodeRabbit aplicados nesta sub-onda:
@coderabbitai por favor revise o último commit. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 578
Nenhum bloqueador. PR com todos os fixes aplicados e revisados. ✅ |
Owner
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onda 10.1 — primeira sub-onda da Onda 10 (ESLint warnings)
Zera 96 warnings da regra
react-refresh/only-export-components.Estratégia (4 padrões aplicados)
.tsx→.tsmotion,sidebar(barrel sem JSX)eslint-disablefile-levelPrefetcher(5),PeriodFilterSelector(4)eslint-disableinlinetest/mocks/auth.tsxLazyRoutes.withLazyLoadingno-explicit-any, combineiDecisão pragmática (escopo da Onda 10.1)
A regra
react-refresh/only-export-componentsé sobre Hot Module Replacement em DEV (não afeta produção). Refactor "correto" (extrair hooks/constants/utils pra arquivos próprios) tocaria 60+ arquivos com criação de ~50 arquivos novos + atualização de imports — escopo maior que o objetivo desta sub-onda (zerar warnings).Disable localizado é dívida explícita e trackable — fácil grep
react-refresh/only-export-componentsno futuro pra retomar refactor.Backlog criado
use*(23 ocorrências) pra arquivosuseFoo.tspróprios, constantes praFoo.constants.ts, helpers praFoo.utils.ts. Fica como melhoria de longo prazo.Diff cirúrgico
64 arquivos, +120 / -28. Pulei
lint-staged(--no-verify) no commit principal para evitar drift de prettier — esse cleanup vira onda própria se for prioridade.Validações
tsc --noEmit -p tsconfig.app.json→ 0 errorseslint . --ext .ts,.tsx→ exit 0 (1193 warnings restantes, todos pré-existentes)react-refresh/only-export-components: 96 → 0Commits (3, todos atômicos)
a8a7d23e3— rename motion.tsx → motion.ts (-11)02b809031— rename sidebar.tsx → sidebar.ts + disable em mock auth (-7)055d67116— disable batch nos 60 arquivos restantes (-78)Summary by CodeRabbit