-
Notifications
You must be signed in to change notification settings - Fork 0
fix: harden production gates — security, CORS, observability, lint (re-#66) #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
55a1cab
fix: harden production gates — security, observability, CI cleanliness
claude d38fd81
fix(forgot-password): restore requestSent state used by inline succes…
claude 145e36f
fix(tests): recover ~70 tests + heal TS regression cluster
claude 22e41f4
fix(header): declare sidebarOpen prop + clean lint regressions
claude 52c47e4
fix(tests): authService.signOut mock + dedup quotes mock + stepper rules
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| #!/usr/bin/env node | ||
| // Cross-platform vitest launcher that forces TZ before workers spawn. | ||
| // | ||
| // Why a wrapper instead of `vitest run`: | ||
| // vitest's config-level `test.env: { TZ: ... }` only stubs process.env in | ||
| // the worker after Date.prototype.toLocaleString has already cached the TZ | ||
| // (see comment in vitest.config.ts). Setting TZ in the parent process here | ||
| // guarantees it propagates to the worker spawn, so snapshot files that | ||
| // were generated under America/Sao_Paulo stay reproducible regardless of | ||
| // the host clock (CI Ubuntu UTC, dev BRT, etc.). | ||
| // | ||
| // Args passthrough: anything after the script name is forwarded verbatim to | ||
| // vitest. e.g. `node scripts/run-vitest.mjs run --coverage`. | ||
|
|
||
| import { spawn } from 'node:child_process'; | ||
|
|
||
| const env = { ...process.env }; | ||
| if (!env.TZ) { | ||
| env.TZ = 'America/Sao_Paulo'; | ||
| } | ||
|
|
||
| const args = process.argv.slice(2); | ||
| const child = spawn('npx', ['vitest', ...args], { | ||
| stdio: 'inherit', | ||
| env, | ||
| shell: true, | ||
| }); | ||
|
|
||
| child.on('close', (code) => { | ||
| process.exit(code ?? 1); | ||
| }); | ||
|
|
||
| child.on('error', (err) => { | ||
| console.error('Failed to launch vitest:', err); | ||
| process.exit(1); | ||
| }); |
267 changes: 176 additions & 91 deletions
267
src/components/admin/connections/ConnectionsOverviewTable.tsx
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
test:qualityscript now passes--exclude tests/hooks/**without quotes, so in POSIX shells npm expands the glob before Node runs. That meansvitestreceives one expanded path as the--excludevalue and the rest as positional test filters, which can end up running hook tests instead of excluding them (or otherwise changing the suite unpredictably). This breaks the intended quality gate behavior on CI/dev environments that perform glob expansion.Useful? React with 👍 / 👎.