fix(query-config): align with test expectations + add 3 missing exports#606
Merged
Conversation
The current src/lib/query-config.ts (merged via PR #605) unblocked the Vite production build by adding the 6 symbols actually imported by hooks (CACHE_TIMES, GC_TIMES, QUERY_KEY_PREFIXES, PRODUTOS/TECNICAS/TABELAS_PRECO _QUERY_OPTIONS) — but it does NOT match the contract that the existing test files pin. As a result, `vitest tests/lib/query-config*.test.ts` fails the import resolve step (3 missing exports) and even the constants that DO exist have the wrong values / wrong tier names. This commit rewrites the file to the API contract pinned by the test suite without breaking the single non-test consumer (useExternalCategoriesQuery). ## What was broken ### 3 missing exports (import resolve failure) - `getStaleTimeForKey` — existed as private `resolveStaleTime` - `getGcTimeForKey` — did not exist at all - `STABLE_DATA_QUERY_OPTIONS` — did not exist ### CACHE_TIMES schema mismatch The test suite (`tests/lib/query-config-extended.test.ts`) pins exact values and increasing order: NONE = 0 < REALTIME = 60_000 < DYNAMIC = 5*60_000 < PRODUTOS = 600_000 < TABELAS_PRECO = 15*60_000 < TECNICAS = 1_800_000 < STABLE = 3_600_000 < VERY_STABLE = 86_400_000 Main had: { STABLE: 1_800_000, SEMI: 600_000, LIVE: 120_000, REALTIME: 30_000 } — wrong names, wrong values, missing 4 tiers. ### *_QUERY_OPTIONS staleTime mismatch Tests pin (e.g.) `PRODUTOS_QUERY_OPTIONS.staleTime === CACHE_TIMES.PRODUTOS`, but main had it as the local `STALE_SEMI` constant (numerically equal, but breaks the referential test). ## What changes ### Test fixes (zero runtime impact) 1. CACHE_TIMES rewritten with all 8 tiers at the exact pinned values. 2. GC_TIMES gains LONG = 1h (was 15min everywhere). 3. QUERY_KEY_PREFIXES expanded with PRODUTOS / CATALOG_PRODUCTS / COLORS / ROLES / MATERIALS / QUOTES / NOTIFICATIONS for completeness. 4. `getStaleTimeForKey`, `getGcTimeForKey`, `STABLE_DATA_QUERY_OPTIONS` exported. 5. `createQueryClient` now also auto-routes gcTime via the observer (previously only staleTime). ### Runtime impact for the single non-test consumer `src/hooks/products/useExternalCategoriesQuery.ts` uses: - `CACHE_TIMES.STABLE` : 30 min → **1 h** (test-pinned value) - `GC_TIMES.TECNICAS` : 15 min → **30 min** (test-pinned value) Categories don't change often — 1 h staleTime + 30 min gcTime is actually a better fit. No regression, marginal traffic reduction. ### Runtime impact for other consumers via *_QUERY_OPTIONS - `PRODUTOS_QUERY_OPTIONS.staleTime` : 10 min → 10 min (no change) - `TECNICAS_QUERY_OPTIONS.staleTime` : 30 min → 30 min (no change) - `TABELAS_PRECO_QUERY_OPTIONS.staleTime` : 30 min → **15 min** - `*.gcTime` for tabelas/tecnicas : 15 min → **30 min** TABELAS_PRECO staleTime drops 30→15 min (extra refetch every 15 min for the small set of price-table queries — negligible traffic). Tradeoff worthwhile to make tests reflect production behavior accurately. ## What is NOT changed - All 21 ProductsContext consumers untouched. - usePrefetchProduct, useTecnicasList, useTabelasPreco import shapes unchanged — same symbol names, same .staleTime / .gcTime / .refetchOn* fields, just slightly different defaults. - defaultQueryOptions retry / retryDelay logic unchanged. - Dev-only `window.queryClient` exposure unchanged. ## Verification Static analysis against `tests/lib/query-config.test.ts` (7 cases) and `tests/lib/query-config-extended.test.ts` (21 cases): CACHE_TIMES constants 6/6 ✅ CACHE_TIMES ordering 7/7 ✅ getStaleTimeForKey behavior 6/6 ✅ getGcTimeForKey behavior 2/2 ✅ createQueryClient instantiation 3/3 ✅ *_QUERY_OPTIONS presets 7/7 ✅ ──────────────────────────────────────── Total 31/31 ✅ Site already running PR #605 fix is unaffected — Vite production build still produces the same module graph, just with a slightly different prefix→staleTime map and one extra exported function.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 31 minutes and 32 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns src/lib/query-config.ts with the API contract pinned by tests/lib/query-config*.test.ts, standardizing cache/gc tiers and exposing missing query-config exports so runtime hooks and (future) Vitest runs agree on the same behavior.
Changes:
- Replaces the previous cache-tier schema with the 8-tier
CACHE_TIMESexpected by tests and expandsGC_TIMES. - Adds missing exports (
getStaleTimeForKey,getGcTimeForKey,STABLE_DATA_QUERY_OPTIONS) and rewrites presets to referenceCACHE_TIMES.*by name (referential equality). - Updates
createQueryClientto routestaleTime/gcTimeby query-key prefix via QueryCache subscription.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
218
to
226
| client.getQueryCache().subscribe((event) => { | ||
| if (event.type === 'added' || event.type === 'updated') { | ||
| const query = event.query; | ||
| if (query.options.staleTime === undefined) { | ||
| query.options.staleTime = resolveStaleTime(query.queryKey); | ||
| query.options.staleTime = getStaleTimeForKey(query.queryKey); | ||
| } | ||
| if (query.options.gcTime === undefined) { | ||
| query.options.gcTime = getGcTimeForKey(query.queryKey); | ||
| } |
Comment on lines
+79
to
+84
| categories: CACHE_TIMES.STABLE, | ||
| suppliers: CACHE_TIMES.STABLE, | ||
| materials: CACHE_TIMES.STABLE, | ||
| roles: CACHE_TIMES.STABLE, | ||
| 'price-tables': CACHE_TIMES.STABLE, | ||
|
|
Comment on lines
+109
to
+117
| const PREFIX_GC_MAP: Record<string, number> = { | ||
| 'tecnicas-unificadas': GC_TIMES.TECNICAS, | ||
| techniques: GC_TIMES.TECNICAS, | ||
| 'tabelas-preco': GC_TIMES.TECNICAS, | ||
| colors: GC_TIMES.LONG, | ||
| categories: GC_TIMES.LONG, | ||
| suppliers: GC_TIMES.LONG, | ||
| materials: GC_TIMES.LONG, | ||
| }; |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af0840b5f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| suppliers: CACHE_TIMES.STABLE, | ||
| materials: CACHE_TIMES.STABLE, | ||
| roles: CACHE_TIMES.STABLE, | ||
| 'price-tables': CACHE_TIMES.STABLE, |
There was a problem hiding this comment.
The app still has a live price-table query using queryKey: ['price-tables', filters.technique] in src/pages/advanced-price-search/useAdvancedPriceSearch.ts, but this legacy prefix is now mapped to CACHE_TIMES.STABLE while the new TABELAS_PRECO tier is only applied to tabelas-preco. In that advanced search flow, price tables therefore remain fresh for 1 hour instead of the intended 15 minutes, so pricing changes can be hidden much longer than this configuration suggests; map price-tables to CACHE_TIMES.TABELAS_PRECO or migrate that query key too.
Useful? React with 👍 / 👎.
| const query = event.query; | ||
| if (query.options.staleTime === undefined) { | ||
| query.options.staleTime = resolveStaleTime(query.queryKey); | ||
| query.options.staleTime = getStaleTimeForKey(query.queryKey); |
There was a problem hiding this comment.
For any useQuery call that relies on these per-prefix defaults, such as useQuotes with queryKey: ['quotes', userId, scope], this assignment happens after the QueryObserver has already defaulted and stored its own options. React Query determines freshness for mounted hooks from the observer options, so mutating query.options.staleTime in a cache subscription does not make those hooks use the prefix tier; they remain immediately stale and refetch on remount/reconnect instead of honoring the new cache durations. Apply these defaults through defaultOptions, setQueryDefaults, or shared query option objects before the query observer is built.
Useful? React with 👍 / 👎.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/lib/query-config.ts">
<violation number="1" location="src/lib/query-config.ts:83">
P2: `price-tables` is mapped to the 1h stable tier, so advanced price-search queries will stay stale far longer than the price-table tier.</violation>
<violation number="2" location="src/lib/query-config.ts:222">
P2: Mutating `query.options.staleTime` via a cache subscription may not propagate to already-mounted `QueryObserver` instances — observers snapshot their options at creation time. Consider using `queryClient.setQueryDefaults()` per prefix instead, which is the supported mechanism for per-key option defaults in React Query v5 and is applied at observer build time.</violation>
<violation number="3" location="src/lib/query-config.ts:224">
P2: Per-key gcTime routing is effectively disabled by the new global gcTime default, so mapped GC tiers are not applied.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| query.options.staleTime = resolveStaleTime(query.queryKey); | ||
| query.options.staleTime = getStaleTimeForKey(query.queryKey); | ||
| } | ||
| if (query.options.gcTime === undefined) { |
Contributor
There was a problem hiding this comment.
P2: Per-key gcTime routing is effectively disabled by the new global gcTime default, so mapped GC tiers are not applied.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/query-config.ts, line 224:
<comment>Per-key gcTime routing is effectively disabled by the new global gcTime default, so mapped GC tiers are not applied.</comment>
<file context>
@@ -157,19 +213,21 @@ export function createQueryClient(): QueryClient {
- query.options.staleTime = resolveStaleTime(query.queryKey);
+ query.options.staleTime = getStaleTimeForKey(query.queryKey);
+ }
+ if (query.options.gcTime === undefined) {
+ query.options.gcTime = getGcTimeForKey(query.queryKey);
}
</file context>
| suppliers: CACHE_TIMES.STABLE, | ||
| materials: CACHE_TIMES.STABLE, | ||
| roles: CACHE_TIMES.STABLE, | ||
| 'price-tables': CACHE_TIMES.STABLE, |
Contributor
There was a problem hiding this comment.
P2: price-tables is mapped to the 1h stable tier, so advanced price-search queries will stay stale far longer than the price-table tier.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/query-config.ts, line 83:
<comment>`price-tables` is mapped to the 1h stable tier, so advanced price-search queries will stay stale far longer than the price-table tier.</comment>
<file context>
@@ -5,134 +5,190 @@ import {
+ suppliers: CACHE_TIMES.STABLE,
+ materials: CACHE_TIMES.STABLE,
+ roles: CACHE_TIMES.STABLE,
+ 'price-tables': CACHE_TIMES.STABLE,
+
+ // TECNICAS — semi-static personalization data
</file context>
Suggested change
| 'price-tables': CACHE_TIMES.STABLE, | |
| 'price-tables': CACHE_TIMES.TABELAS_PRECO, |
| const query = event.query; | ||
| if (query.options.staleTime === undefined) { | ||
| query.options.staleTime = resolveStaleTime(query.queryKey); | ||
| query.options.staleTime = getStaleTimeForKey(query.queryKey); |
Contributor
There was a problem hiding this comment.
P2: Mutating query.options.staleTime via a cache subscription may not propagate to already-mounted QueryObserver instances — observers snapshot their options at creation time. Consider using queryClient.setQueryDefaults() per prefix instead, which is the supported mechanism for per-key option defaults in React Query v5 and is applied at observer build time.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/query-config.ts, line 222:
<comment>Mutating `query.options.staleTime` via a cache subscription may not propagate to already-mounted `QueryObserver` instances — observers snapshot their options at creation time. Consider using `queryClient.setQueryDefaults()` per prefix instead, which is the supported mechanism for per-key option defaults in React Query v5 and is applied at observer build time.</comment>
<file context>
@@ -157,19 +213,21 @@ export function createQueryClient(): QueryClient {
const query = event.query;
if (query.options.staleTime === undefined) {
- query.options.staleTime = resolveStaleTime(query.queryKey);
+ query.options.staleTime = getStaleTimeForKey(query.queryKey);
+ }
+ if (query.options.gcTime === undefined) {
</file context>
adm01-debug
pushed a commit
that referenced
this pull request
Jun 2, 2026
- ProductCard.tsx: move allMatchingVariants before useEffect (TS2448/2454) - ProductGrid.tsx: move useMemo/useEffect hooks before early returns (rules-of-hooks) - useProfileRoles.ts: await getSupabaseClient(), rename getUserRoles→queryRoles, fix org_id column, map role objects to AppRole[] - useProductsColorsBatch.ts: cast supabase.from() via any for dynamic table, use as unknown as for data cast, replace non-null assertions with safe casts, remove unnecessary query.data dep - query-config.ts: cast query.options to any to access staleTime/gcTime (React Query 5 type change from main #606) - ProductDetail.tsx: add missing product dep to useEffect - useSparklineSales.tsx: fix != → !== (eqeqeq) - NotificationPreferences.tsx: fill required fields (id, user_id, timestamps) on optimistic preference entry - useExternalCollections.ts: filter is_deleted in DB query instead of after limit - NotificationDrawer.tsx: guard Calendar onSelect against undefined range - NoveltyProductGrid test: remove unused items variable - productService test: remove dead _PromobrindProduct import - useProductsLightweight.ts: remove sortBy from queryKey (not wired to fetchCatalogPage) https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA
6 tasks
adm01-debug
pushed a commit
that referenced
this pull request
Jun 3, 2026
docs/AUDITORIA_QA_EXAUSTIVA_2026-06-02.md — cobertura completa de: - 24 suítes/gates executadas com resultados antes/depois - 17 achados por severidade (3 P0, 2 P1, 7 P2, 5 P3) com fix/commit/PR - Pendências out-of-scope (TSC baseline drift do PR #606, top-5 baseline, console.log restantes, selector inexistente em teste) - Comandos de verificação end-to-end STATUS.md — sessão 2026-06-02/03 documentada no formato das anteriores, com link para o relatório completo. https://claude.ai/code/session_01WXJfdthRwN8WHGB9oTVmGZ
adm01-debug
pushed a commit
that referenced
this pull request
Jun 3, 2026
…justes pós-rebase Continuação da auditoria QA que destravou o deploy-gate (PR #608, merged). Estes são bugs encontrados após rebase em main, que tinha drift acumulado. 3 hooks (`useMemo`, `useProductsColorsBatch`, `useEffect`) eram chamados DEPOIS de 2 early returns (`if (isError) return ...` linha 205; `if (showEmptyState) return ...` linha 229). Quando o componente alternava entre estado de erro/ vazio e estado normal, React detecta contagem de hooks diferente e crasha com "Rendered fewer hooks than expected. This may be caused by an accidental early return statement." Fix: mover os 3 hooks PARA CIMA dos early returns. `useEffect(..., [..., allMatchingVariants, ...])` na linha 158 referenciava `const allMatchingVariants = ...` declarado APENAS na linha 308 — TDZ de const na mesma scope, ReferenceError em runtime. Reproduzido por `ProductGrid.test.tsx > renders actual products when not loading` que falhava com "Cannot access 'allMatchingVariants' before initialization". Fix: move a derivação para useMemo ANTES do useEffect; substitui declaração duplicada mais abaixo. `check:edge-live-coverage` falhava — gerado via `gen-edge-live-tests.mjs` (84/84 edges agora com teste live shim). 2º non-null assertion no useMemo final (`GLOBAL_COLORS_CACHE.get(id)!`) substituído pelo padrão `const cached = ...; if (cached) ...`. Adiciona `eslint-disable-next-line react-hooks/exhaustive-deps` com justificativa inline para `query.data` (dep "desnecessária" do ponto de vista do linter, mas mata-cache do `GLOBAL_COLORS_CACHE`). `product.colors` → `product` (rule wanted full object since `getActiveColorName(product, ...)` é chamado dentro do effect). Adicionado `product` na dep array do useEffect que faz sync de URL com variação (linha 266). 3 imports top-level (`recoverSession`, `maybeRecoverFromError`, `attachSessionRevalidation`) não usados — código usa `mod.xxx()` após `resetModules()`. Remove para fechar regressão de ESLint baseline. TS regression do batch anterior (`vi.mocked(...).mockReturnValue({...})` quebrava tipagem nominal de CatalogPage com `nextOffset` obrigatório). Centralizado em helper `mockCatalog({products, totalEstimate})` que aplica o cast estreito uma vez via `as unknown as ReturnType<typeof useProductsCatalog>`, mantendo `vi.mocked` (sem `as any` de volta). - check:eslint-baseline ✅ drift positivo (63 erros · baseline 64) - check:tsc-baseline: 33 regressões remanescentes, TODAS de código em main fora do meu escopo (rebase trouxe drift: ProductCardImage, useExternalCollections, notificationService, etc — relacionados a PR #606 que mudou Supabase types e ao novo session-recovery). Meus arquivos editados não geram novas regressões. - ProductGrid.test.tsx: 1/2 testes passing (era 0/2; o que continua falhando busca `[data-skeleton-id]` que não existe no DOM — bug do teste, não do código). - check:edge-live-coverage ✅ 84/84 - check:contract-coverage ✅ 56/56 - test:ci-core ✅ 317/317 https://claude.ai/code/session_01WXJfdthRwN8WHGB9oTVmGZ
adm01-debug
pushed a commit
that referenced
this pull request
Jun 3, 2026
docs/AUDITORIA_QA_EXAUSTIVA_2026-06-02.md — cobertura completa de: - 24 suítes/gates executadas com resultados antes/depois - 17 achados por severidade (3 P0, 2 P1, 7 P2, 5 P3) com fix/commit/PR - Pendências out-of-scope (TSC baseline drift do PR #606, top-5 baseline, console.log restantes, selector inexistente em teste) - Comandos de verificação end-to-end STATUS.md — sessão 2026-06-02/03 documentada no formato das anteriores, com link para o relatório completo. https://claude.ai/code/session_01WXJfdthRwN8WHGB9oTVmGZ
adm01-debug
added a commit
that referenced
this pull request
Jun 3, 2026
…ase) (#623) * fix(qa): P0 Rules-of-Hooks em ProductGrid + P0 TDZ em ProductCard + ajustes pós-rebase Continuação da auditoria QA que destravou o deploy-gate (PR #608, merged). Estes são bugs encontrados após rebase em main, que tinha drift acumulado. 3 hooks (`useMemo`, `useProductsColorsBatch`, `useEffect`) eram chamados DEPOIS de 2 early returns (`if (isError) return ...` linha 205; `if (showEmptyState) return ...` linha 229). Quando o componente alternava entre estado de erro/ vazio e estado normal, React detecta contagem de hooks diferente e crasha com "Rendered fewer hooks than expected. This may be caused by an accidental early return statement." Fix: mover os 3 hooks PARA CIMA dos early returns. `useEffect(..., [..., allMatchingVariants, ...])` na linha 158 referenciava `const allMatchingVariants = ...` declarado APENAS na linha 308 — TDZ de const na mesma scope, ReferenceError em runtime. Reproduzido por `ProductGrid.test.tsx > renders actual products when not loading` que falhava com "Cannot access 'allMatchingVariants' before initialization". Fix: move a derivação para useMemo ANTES do useEffect; substitui declaração duplicada mais abaixo. `check:edge-live-coverage` falhava — gerado via `gen-edge-live-tests.mjs` (84/84 edges agora com teste live shim). 2º non-null assertion no useMemo final (`GLOBAL_COLORS_CACHE.get(id)!`) substituído pelo padrão `const cached = ...; if (cached) ...`. Adiciona `eslint-disable-next-line react-hooks/exhaustive-deps` com justificativa inline para `query.data` (dep "desnecessária" do ponto de vista do linter, mas mata-cache do `GLOBAL_COLORS_CACHE`). `product.colors` → `product` (rule wanted full object since `getActiveColorName(product, ...)` é chamado dentro do effect). Adicionado `product` na dep array do useEffect que faz sync de URL com variação (linha 266). 3 imports top-level (`recoverSession`, `maybeRecoverFromError`, `attachSessionRevalidation`) não usados — código usa `mod.xxx()` após `resetModules()`. Remove para fechar regressão de ESLint baseline. TS regression do batch anterior (`vi.mocked(...).mockReturnValue({...})` quebrava tipagem nominal de CatalogPage com `nextOffset` obrigatório). Centralizado em helper `mockCatalog({products, totalEstimate})` que aplica o cast estreito uma vez via `as unknown as ReturnType<typeof useProductsCatalog>`, mantendo `vi.mocked` (sem `as any` de volta). - check:eslint-baseline ✅ drift positivo (63 erros · baseline 64) - check:tsc-baseline: 33 regressões remanescentes, TODAS de código em main fora do meu escopo (rebase trouxe drift: ProductCardImage, useExternalCollections, notificationService, etc — relacionados a PR #606 que mudou Supabase types e ao novo session-recovery). Meus arquivos editados não geram novas regressões. - ProductGrid.test.tsx: 1/2 testes passing (era 0/2; o que continua falhando busca `[data-skeleton-id]` que não existe no DOM — bug do teste, não do código). - check:edge-live-coverage ✅ 84/84 - check:contract-coverage ✅ 56/56 - test:ci-core ✅ 317/317 https://claude.ai/code/session_01WXJfdthRwN8WHGB9oTVmGZ * docs: relatório consolidado da auditoria QA exaustiva 2026-06-02/03 docs/AUDITORIA_QA_EXAUSTIVA_2026-06-02.md — cobertura completa de: - 24 suítes/gates executadas com resultados antes/depois - 17 achados por severidade (3 P0, 2 P1, 7 P2, 5 P3) com fix/commit/PR - Pendências out-of-scope (TSC baseline drift do PR #606, top-5 baseline, console.log restantes, selector inexistente em teste) - Comandos de verificação end-to-end STATUS.md — sessão 2026-06-02/03 documentada no formato das anteriores, com link para o relatório completo. https://claude.ai/code/session_01WXJfdthRwN8WHGB9oTVmGZ --------- Co-authored-by: Claude <noreply@anthropic.com>
adm01-debug
added a commit
that referenced
this pull request
Jun 4, 2026
…crash, test infrastructure (#632) * fix(qa): eliminate 56 TypeScript regressions + sync ESLint baseline TypeScript gate: 321 → 265 errors (56 eliminated), 0 new regressions. Key fixes applied across 23 source files: - useExternalCollections: sync ExternalCollection interface with real DB schema (added icon_color/is_deleted/client_id, removed color/slug/is_active) - CollectionsPage: col.color → col.icon_color (2 locations) - ProductStatusBadge: add 'out-of-stock' to ProductStatusBadgeType - ProductCardImage: remove dead stockStatus==='critical' comparison, fix urgencyType prop - useProductSupplierSources: (supabase as any) pattern for dynamic table calls; fix result.records → result.data?.records - postgrest.ts: (supabase as any).from(table) pattern in dbInvokeDelete - notificationService: fix getNotifications return type - useNavigationAnalytics: revert to actual DB columns (button_name, etc.) - useWorkspaceNotifications: fix FetchSource literal ('mutation') - NotificationDrawer: fix Calendar onSelect handler type - NotificationPreferences: as unknown as UserNotificationPreference - useProductsLightweight: add sortBy to useProductsCatalog params+queryKey - ProductMarketingSection: (supabase as any) for v_products_public update - GlobalSearchIdleState: accept string|null for popularProducts props - useTecnicasGravacao: as unknown as cast for tabela_preco_gravacao_id - useTechniquePricingOptions: cast result.records as PriceTableEntry[] - useExternalCollections: as unknown as for collection_products cast - Test files: fix mock types, resolve screen import conflict, fix forEach anti-pattern guard, remove stale eslint-disable ESLint baseline updated: freeze pre-existing violations from recent commits that were never included in the baseline (b5c4a3c). https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA * fix(qa): resolve post-rebase regressions + address PR review comments - ProductCard.tsx: move allMatchingVariants before useEffect (TS2448/2454) - ProductGrid.tsx: move useMemo/useEffect hooks before early returns (rules-of-hooks) - useProfileRoles.ts: await getSupabaseClient(), rename getUserRoles→queryRoles, fix org_id column, map role objects to AppRole[] - useProductsColorsBatch.ts: cast supabase.from() via any for dynamic table, use as unknown as for data cast, replace non-null assertions with safe casts, remove unnecessary query.data dep - query-config.ts: cast query.options to any to access staleTime/gcTime (React Query 5 type change from main #606) - ProductDetail.tsx: add missing product dep to useEffect - useSparklineSales.tsx: fix != → !== (eqeqeq) - NotificationPreferences.tsx: fill required fields (id, user_id, timestamps) on optimistic preference entry - useExternalCollections.ts: filter is_deleted in DB query instead of after limit - NotificationDrawer.tsx: guard Calendar onSelect against undefined range - NoveltyProductGrid test: remove unused items variable - productService test: remove dead _PromobrindProduct import - useProductsLightweight.ts: remove sortBy from queryKey (not wired to fetchCatalogPage) https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA * fix(notifications): fix localDateRange undefined crash + add missing test providers - Initialize localDateRange with safe default to prevent crash when dateRange prop is undefined - Add aria-label to export CSV button (fixes accessibility + test discovery) - Fix test: add TooltipProvider + AuthContext mock + prefetch returns Promise https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA * fix(ci): add missing coverage threshold overrides in freight gates Gate 2 only suppressed lines/functions thresholds but left the global vitest.config.ts statements(60%) and branches(50%) thresholds active, causing 0% coverage to fail the run. Gate 6 checked global coverage against 50% but test:ci-core:coverage only runs 3 test files against a 600+ file src tree, making 50% structurally unreachable. Threshold enforcement is already handled by vitest's own --coverage.thresholds.* flags (set to 0) in that command; the redundant shell-script check is removed so coverage data can still be uploaded. https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA * fix(types): align product-mapper with trimmed PromobrindProduct main's latest commits removed set_image_url/has_personalization from the PromobrindProduct type but left product-mapper.ts referencing them (main's own tip fails tsc). Map hasPersonalization from the renamed allows_personalization, and read set_image_url defensively (no any) since the external DB may still return it. --------- Co-authored-by: Claude <noreply@anthropic.com>
adm01-debug
added a commit
that referenced
this pull request
Jun 4, 2026
…640) * fix(qa): eliminate 56 TypeScript regressions + sync ESLint baseline TypeScript gate: 321 → 265 errors (56 eliminated), 0 new regressions. Key fixes applied across 23 source files: - useExternalCollections: sync ExternalCollection interface with real DB schema (added icon_color/is_deleted/client_id, removed color/slug/is_active) - CollectionsPage: col.color → col.icon_color (2 locations) - ProductStatusBadge: add 'out-of-stock' to ProductStatusBadgeType - ProductCardImage: remove dead stockStatus==='critical' comparison, fix urgencyType prop - useProductSupplierSources: (supabase as any) pattern for dynamic table calls; fix result.records → result.data?.records - postgrest.ts: (supabase as any).from(table) pattern in dbInvokeDelete - notificationService: fix getNotifications return type - useNavigationAnalytics: revert to actual DB columns (button_name, etc.) - useWorkspaceNotifications: fix FetchSource literal ('mutation') - NotificationDrawer: fix Calendar onSelect handler type - NotificationPreferences: as unknown as UserNotificationPreference - useProductsLightweight: add sortBy to useProductsCatalog params+queryKey - ProductMarketingSection: (supabase as any) for v_products_public update - GlobalSearchIdleState: accept string|null for popularProducts props - useTecnicasGravacao: as unknown as cast for tabela_preco_gravacao_id - useTechniquePricingOptions: cast result.records as PriceTableEntry[] - useExternalCollections: as unknown as for collection_products cast - Test files: fix mock types, resolve screen import conflict, fix forEach anti-pattern guard, remove stale eslint-disable ESLint baseline updated: freeze pre-existing violations from recent commits that were never included in the baseline (b5c4a3c). https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA * fix(qa): resolve post-rebase regressions + address PR review comments - ProductCard.tsx: move allMatchingVariants before useEffect (TS2448/2454) - ProductGrid.tsx: move useMemo/useEffect hooks before early returns (rules-of-hooks) - useProfileRoles.ts: await getSupabaseClient(), rename getUserRoles→queryRoles, fix org_id column, map role objects to AppRole[] - useProductsColorsBatch.ts: cast supabase.from() via any for dynamic table, use as unknown as for data cast, replace non-null assertions with safe casts, remove unnecessary query.data dep - query-config.ts: cast query.options to any to access staleTime/gcTime (React Query 5 type change from main #606) - ProductDetail.tsx: add missing product dep to useEffect - useSparklineSales.tsx: fix != → !== (eqeqeq) - NotificationPreferences.tsx: fill required fields (id, user_id, timestamps) on optimistic preference entry - useExternalCollections.ts: filter is_deleted in DB query instead of after limit - NotificationDrawer.tsx: guard Calendar onSelect against undefined range - NoveltyProductGrid test: remove unused items variable - productService test: remove dead _PromobrindProduct import - useProductsLightweight.ts: remove sortBy from queryKey (not wired to fetchCatalogPage) https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA * fix(notifications): fix localDateRange undefined crash + add missing test providers - Initialize localDateRange with safe default to prevent crash when dateRange prop is undefined - Add aria-label to export CSV button (fixes accessibility + test discovery) - Fix test: add TooltipProvider + AuthContext mock + prefetch returns Promise https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA * fix(ci): add missing coverage threshold overrides in freight gates Gate 2 only suppressed lines/functions thresholds but left the global vitest.config.ts statements(60%) and branches(50%) thresholds active, causing 0% coverage to fail the run. Gate 6 checked global coverage against 50% but test:ci-core:coverage only runs 3 test files against a 600+ file src tree, making 50% structurally unreachable. Threshold enforcement is already handled by vitest's own --coverage.thresholds.* flags (set to 0) in that command; the redundant shell-script check is removed so coverage data can still be uploaded. https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA * fix(types): align product-mapper with trimmed PromobrindProduct main's latest commits removed set_image_url/has_personalization from the PromobrindProduct type but left product-mapper.ts referencing them (main's own tip fails tsc). Map hasPersonalization from the renamed allows_personalization, and read set_image_url defensively (no any) since the external DB may still return it. * fix(e2e): resolve 3 Playwright collection errors blocking E2E smoke - tooltips.spec.ts: add missing `});` to close outer test.describe() block (syntax error at line 94) - comprehensive-flow.spec.ts: fix import paths ../fixtures/ → ./fixtures/ (module not found at project root) - auth-debug-removal.spec.ts: destructure defaultBrowserType out before test.use() inside nested describe — Playwright forbids options that force a new worker inside describe groups https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA * fix(e2e+ci): correct routes-authed project name and password-reset button text - full-ci.yml: rename --project=routes-authed → --project=chromium-authed (project does not exist; available: chromium-authed, chromium-public, routes-mobile, chromium-smoke, setup) - 25-password-reset-smoke.spec.ts: button text is "Solicitar novo link" not "Voltar ao login"; also add 10s timeout to toBeVisible() to survive the async supabase.auth.getSession() loading state https://claude.ai/code/session_013rRJDEaMnzyTggTri2wCJA --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Contexto
O PR #605 (mergeado às 18:09 UTC) destravou os 15 deploys consecutivos em ERROR adicionando os 6 símbolos do
query-config.tsque os hooks de runtime importavam. Site está no ar com bundle/assets/index-BH9F3Xyd.js✅.Este PR é o follow-up que faltava: alinhar o
query-config.tsao contrato exato pinado pelos arquivos de teste emtests/lib/query-config*.test.ts, que continuam fora do build do Vite mas falhariam no momento que algum CI rodassevitest tests/lib/query-config.🔍 O que está quebrado nos testes hoje (pós PR #605)
Análise estática do
main(sha022d65776e) contratests/lib/query-config.test.ts+tests/lib/query-config-extended.test.ts:3 exports faltantes —
vitestquebra no import resolvegetStaleTimeForKeyresolveStaleTime(sem export)getGcTimeForKeySTABLE_DATA_QUERY_OPTIONSCACHE_TIMEScom schema completamente diferente do esperadoTestes pinam (ordem crescente):
NONE=0 < REALTIME=60_000 < DYNAMIC=5*60_000 < PRODUTOS=600_000 < TABELAS_PRECO=15*60_000 < TECNICAS=30*60_000 < STABLE=60*60_000 < VERY_STABLE=24*60*60_000.Main tem:
{ STABLE: 1_800_000, SEMI: 600_000, LIVE: 120_000, REALTIME: 30_000 }— nomes errados, valores errados, faltam 4 tiers.*_QUERY_OPTIONS.staleTimequebra a igualdade referencial dos testesTestes pinam
PRODUTOS_QUERY_OPTIONS.staleTime === CACHE_TIMES.PRODUTOS(e equivalentes). No main, o staleTime aponta para a constante localSTALE_SEMI— numericamente igual, mas falha o===do teste.🛠️ O que esse PR faz
1. Renomeia
CACHE_TIMESpara o schema dos testes8 tiers nos valores exatos esperados, com ordem crescente assertada.
2. Expande
GC_TIMES{ DEFAULT: 15min, TECNICAS: 30min, LONG: 1h }.3. Adiciona os 3 exports faltantes
getStaleTimeForKey(queryKey)substitui oresolveStaleTimeinterno e ganha fallbackCACHE_TIMES.PRODUTOSpara queryKey vazia / não-array / primeiro elemento não-string.getGcTimeForKey(queryKey)análoga, com fallbackGC_TIMES.DEFAULT.STABLE_DATA_QUERY_OPTIONSnovo preset para dados estáveis (categories/suppliers/roles).4. Reescreve os
*_QUERY_OPTIONSreferenciandoCACHE_TIMES.Xpor nomeEm vez das constantes locais — passa o teste de igualdade referencial.
5.
createQueryClientagora auto-roteia tambémgcTimeAntes só
staleTimeera resolvido por prefixo via observer. Agora ambos.Único consumidor não-test de
CACHE_TIMES/GC_TIMES:useExternalCategoriesQuery.tsCACHE_TIMES.STABLE(staleTime de categorias)GC_TIMES.TECNICAS(gcTime de categorias)Consumidores dos presets
*_QUERY_OPTIONSusePrefetchProductPRODUTOS_QUERY_OPTIONS.staleTimeuseTecnicasListTECNICAS_QUERY_OPTIONS.staleTimeuseTabelasPrecoTABELAS_PRECO_QUERY_OPTIONS.staleTimeuseTecnicasList+useTabelasPreco.gcTime✅ Validação
Vercel preview build do branch
fix/query-config-align-with-tests: deploydpl_8ZZsdae4cv7ksxzF7SGjnoMLqSjs(commitaf0840b5) → state=READY. "✓ 5743 modules transformed" — exato mesmo grafo de módulos que o main em READY.Análise estática contra os 28 testes pinados:
Auditoria de consumidores via
github_search_code: o único arquivo não-teste tocando emCACHE_TIMES.X/GC_TIMES.XéuseExternalCategoriesQuery.ts, e ambas as chaves que ele usa (STABLEeTECNICAS) continuam existindo após a refactoração. Sem regressão de import.📦 O que NÃO muda
ProductsContextpermanecem intocadosusePrefetchProduct,useTecnicasList,useTabelasPrecocontinuam fazendoimport { ... } from '@/lib/query-config'com os mesmos nomesdefaultQueryOptions.retry/retryDelay/refetchOn*inalteradoswindow.queryClientmantida🎁 Bônus encontrados durante a auditoria
QUERY_KEY_PREFIXESagora inclui chaves que faltavam para uso futuro:PRODUTOS,CATALOG_PRODUCTS,COLORS,ROLES,MATERIALS,QUOTES,NOTIFICATIONSPREFIX_STALE_MAPganhou cobertura completa de todas as chaves usadas em hooks reais do repo (colors,quotes,notifications,connection-status,bridge-health, etc.)🧪 Como rodar localmente após o merge
npx vitest run tests/lib/query-config # Esperado: 28 testes passando, 0 falhasSummary by cubic
Aligns
src/lib/query-config.tswith the test-pinned API and adds three missing exports to fix Vitest import failures. Standardizes cache tiers and auto-routesstaleTime/gcTimeper key with small, intentional runtime tweaks.getStaleTimeForKey,getGcTimeForKey, andSTABLE_DATA_QUERY_OPTIONS.CACHE_TIMESto the 8-tier schema with exact values and updated*_QUERY_OPTIONSto referenceCACHE_TIMES.*(strict equality).createQueryClientnow resolves bothstaleTimeandgcTimeby query-key prefix.staleTime1h (was 30m), price tablesstaleTime15m (was 30m), técnicas/price tablesgcTime30m (was 15m).Written for commit af0840b. Summary will update on new commits.