Skip to content

ci: lint-gate bloqueante (prettier + typecheck + regras de projeto)#508

Closed
adm01-debug wants to merge 1 commit into
mainfrom
codex/configure-lint-job-with-blocking-failure
Closed

ci: lint-gate bloqueante (prettier + typecheck + regras de projeto)#508
adm01-debug wants to merge 1 commit into
mainfrom
codex/configure-lint-job-with-blocking-failure

Conversation

@adm01-debug
Copy link
Copy Markdown
Owner

@adm01-debug adm01-debug commented May 29, 2026

Draft aberto durante limpeza de branches para resgatar trabalho não mergeado.

Conteúdo (1 commit)

  • Adiciona job lint-gate bloqueante (prettier format:check, typecheck, ESLint annotations, baseline, guards de projeto) e reorganiza o job quality

⚠️ Atenção do revisor

Branch ~1.400 commits atrás do main e alternativa/concorrente ao PR de estágio rápido do CI. O ci.yml atual já evoluiu com gates equivalentes, então provavelmente superada. Avaliar antes de descartar ou rebase.

https://claude.ai/code/session_01QpLctApdgHrT7hBAS3dk71


Generated by Claude Code


Summary by cubic

Adds a blocking CI lint gate that runs Prettier, TypeScript typecheck, ESLint with PR annotations and baseline, plus critical project guard scripts. Tests now run only after this gate, giving fail-fast feedback and clearer PR signals.

  • Refactors
    • Added lint-gate job (Prettier format:check, TS typecheck, ESLint annotations + baseline, guard scripts).
    • Moved guard scripts and lint baseline from quality to lint-gate.
    • Renamed quality to “Tests & Security” and made it depend on lint-gate.
    • Ensures fail-fast on style/type/lint; ESLint outputs inline PR annotations.

Written for commit a170f04. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

Release Notes

  • Chores
    • Reorganizado o fluxo de CI/CD para melhorar a detecção de erros em etapas anteriores do processo de validação, garantindo verificações de formatação, tipagem e lint antes da execução de testes.

Review Change Stack

@supabase
Copy link
Copy Markdown

supabase Bot commented May 29, 2026

This pull request has been ignored for the connected project doufsxqlfjyuvxuezpln because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Novo job lint-gate consolida validações de formatação, typecheck, ESLint com baseline e verificações de escopo/rotas/nesting. Job quality agora depende de lint-gate, elimina execução duplicada de checks, e se renomeia para Tests & Security com foco em testes e gates de segurança.

Changes

Reorganização do Pipeline CI

Layer / File(s) Summary
Job lint-gate com validações consolidadas
.github/workflows/ci.yml
Novo job executando npm ci, format:check, typecheck, ESLint baseline gate, e quatro scripts de verificação (check-seller-scope, check-route-error-element, check-aschild-nesting, check-route-ref-usage) em sequência como pré-requisito obrigatório.
Job quality com atualização de dependência e remoção de duplicatas
.github/workflows/ci.yml
Job renomeada para Tests & Security, reconfigurada para depender de lint-gate, com remoção de steps duplicados de typecheck, ESLint baseline e verificações de rotas/escopo/nesting. Pipeline mantém npm ci e segue direto para testes unitários e gates de segurança/edge/CORS/RLS.

Possibly Related PRs

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed O título descreve precisamente a mudança principal: adição de um job lint-gate bloqueante que executa verificações de formatação (prettier), tipos TypeScript e regras de projeto.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/configure-lint-job-with-blocking-failure
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch codex/configure-lint-job-with-blocking-failure

Comment @coderabbitai help to get the list of available commands and usage tips.

@adm01-debug adm01-debug marked this pull request as ready for review May 29, 2026 13:54
Copilot AI review requested due to automatic review settings May 29, 2026 13:54
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR proposes restructuring the main CI workflow to introduce a new blocking “lint gate” stage (formatting, type checks, ESLint baseline, and project guard scripts) that runs before the heavier test/security job, aiming to fail fast on style/type/lint and enforce project rules earlier.

Changes:

  • Adds a new lint-gate job that runs Prettier format:check, typecheck, an ESLint run intended for PR-readable output, ESLint baseline gate, and critical guard scripts.
  • Refactors quality (renamed to “Tests & Security”) to depend on lint-gate, and removes guard/baseline/typecheck steps from quality.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines +48 to +49
- name: ESLint annotations (legível no PR)
run: npx eslint src --format=github --max-warnings=500
Comment thread .github/workflows/ci.yml
Comment on lines +45 to +46
- name: TypeScript type check (bloqueante)
run: npm run typecheck
Copy link
Copy Markdown
Owner Author

Fechando após análise de viabilidade.

Motivo: branch criada sobre um main cujo histórico foi reescrito (force-push) — hoje sem ancestral comum com o main atual, daí o conflito total ("unrelated histories").

O ci.yml foi reescrito no main e já tem gates equivalentes ao lint-gate proposto aqui (prettier format:check, typecheck fail-fast, lint:baseline, guards de projeto). Reaplicar este job antigo é alternativa concorrente e superada.

Decisão de engenharia: fechar em vez de "resolver conflito". Caso queira algum check específico daqui, recriar sobre o ci.yml atual é o caminho seguro.


Generated by Claude Code

@adm01-debug adm01-debug deleted the codex/configure-lint-job-with-blocking-failure branch May 29, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants