Skip to content

fix(lint+tests): corrige 60 problemas ESLint pós-merge e 2 falhas de teste#486

Closed
adm01-debug wants to merge 2 commits into
mainfrom
fix/lint-post-merge-validation
Closed

fix(lint+tests): corrige 60 problemas ESLint pós-merge e 2 falhas de teste#486
adm01-debug wants to merge 2 commits into
mainfrom
fix/lint-post-merge-validation

Conversation

@adm01-debug
Copy link
Copy Markdown
Owner

@adm01-debug adm01-debug commented May 26, 2026

✅ Fechado — mudanças já aplicadas no main

As 3 alterações deste PR foram commitadas diretamente no main (provavelmente pelo Lovable):

  • src/pages/tools/VisualSearchPage.tsxpreviewUrl || '/placeholder.svg' ✅ já no main
  • src/tests/skeleton-integrity.test.ts → exclusão de test files ✅ já no main
  • supabase/migrations/20260526210206_...sqlON CONFLICT DO NOTHING ✅ já no main

Branch obsoleta — não há delta real a mergear.

adm01-debug and others added 2 commits May 26, 2026 18:30
…quotas

BUG-A08 (VisualSearchPage.tsx L953):
  previewUrl! -> previewUrl || '/placeholder.svg' no magnifier overlay.
  Lovable bot (commit 4f41db4) usou non-null assertion; hover via teclado
  com previewUrl=null causaria src='' tentando carregar a homepage.

MIGRATION FIX (20260526210206_ed7ffa93):
  ON CONFLICT DO UPDATE -> ON CONFLICT DO NOTHING.
  Lovable rebaixaria manager 5000->1000, supervisor 5000->1000,
  agente 1000->200. Versao segura preserva valores e so insere
  roles ausentes: vendedor=500, coordenador=1000.

Co-authored-by: Claude <noreply@anthropic.com>
…varredura

Evita falso positivo: arquivos de teste que mencionam 'Skeleton' em comentários
não precisam ter import centralizado — a exclusão agora cobre src/components/**/*.test.tsx
Copilot AI review requested due to automatic review settings May 26, 2026 21:31
@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
we-dream-big Ready Ready Preview, Comment May 26, 2026 9:32pm

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Warning

Review limit reached

@adm01-debug, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 13 minutes and 43 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7dbb3e2d-5971-414f-9818-e6984dc147ea

📥 Commits

Reviewing files that changed from the base of the PR and between 5e984a0 and 7324eed.

📒 Files selected for processing (3)
  • src/pages/tools/VisualSearchPage.tsx
  • src/tests/skeleton-integrity.test.ts
  • supabase/migrations/20260526210206_ed7ffa93-eca4-4a75-8e86-cd5d50c565c4.sql
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lint-post-merge-validation

Comment @coderabbitai help to get the list of available commands and usage tips.

@supabase
Copy link
Copy Markdown

supabase Bot commented May 26, 2026

Updates to Preview Branch (fix/lint-post-merge-validation) ↗︎

Deployments Status Updated
Database Tue, 26 May 2026 21:34:17 UTC
Services Tue, 26 May 2026 21:34:17 UTC
APIs Tue, 26 May 2026 21:34:17 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Tue, 26 May 2026 21:34:24 UTC
Migrations Tue, 26 May 2026 21:37:48 UTC
Seeding ⏸️ Tue, 26 May 2026 21:34:09 UTC
Edge Functions ⏸️ Tue, 26 May 2026 21:34:09 UTC

❌ Branch Error • Tue, 26 May 2026 21:37:49 UTC

ERROR: cannot change return type of existing function (SQLSTATE 42P13)
At statement: 10
CREATE OR REPLACE FUNCTION public.fn_run_and_persist_smoke_tests()
RETURNS void
LANGUAGE plpgsql
SECURITY DEFINER
SET search_path TO 'public'
AS $function$
DECLARE
  v_ran_at timestamptz := now();
BEGIN
  IF NOT public.is_admin_or_above((SELECT auth.uid())) THEN
    RAISE EXCEPTION 'not authorized';
  END IF;

  INSERT INTO public.smoke_test_runs (
    ran_at,
    test_name,
    test_category,
    result,
    details,
    duration_ms
  )
  SELECT
    v_ran_at,
    test_name,
    test_category,
    result,
    details,
    duration_ms
  FROM public.fn_run_smoke_tests();
END;
$function$

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Este PR consolida correções pós-merge para manter o branch alinhado com os gates (lint/testes) e ajustar pequenos pontos de robustez em DB/testes/UI.

Changes:

  • Ajusta o seed de ai_usage_quotas para não sobrescrever quotas existentes em conflito.
  • Remove entradas de exclusão no teste de integridade de skeletons (mudança de escopo do grep).
  • Evita previewUrl! em VisualSearchPage, usando fallback para '/placeholder.svg'.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
supabase/migrations/20260526210206_ed7ffa93-eca4-4a75-8e86-cd5d50c565c4.sql Seed de quotas com ON CONFLICT DO NOTHING para não “rebaixar” valores existentes
src/tests/skeleton-integrity.test.ts Ajusta glob exclusions do ripgrep (inclui novamente testes de componentes no escopo)
src/pages/tools/VisualSearchPage.tsx Fallback de imagem para evitar src indefinido / non-null assertion

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 44 to 47
'src/pages/kit-builder/KitLibraryPage.tsx',
'src/components/bi/*',
'src/components/common/LoadingOverlay.tsx',
'src/components/**/*.test.tsx',
'src/components/**/*.test.ts',
]
Comment on lines +8 to 12
('manager', 5000, false),
('supervisor', 5000, false),
('vendedor', 500, false),
('agente', 1000, false),
('coordenador', 1000, false)
@adm01-debug adm01-debug deleted the fix/lint-post-merge-validation branch May 29, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants