[REBASED → #481] fix(mockup-generator): auditoria exaustiva — 10 bugs corrigidos#478
Closed
adm01-debug wants to merge 3 commits into
Closed
[REBASED → #481] fix(mockup-generator): auditoria exaustiva — 10 bugs corrigidos#478adm01-debug wants to merge 3 commits into
adm01-debug wants to merge 3 commits into
Conversation
… limit 200, T10 thumbnail_url
… userId delete, T9 URL params T1: 7 async handlers wrapped in useCallback → useMemo output is now truly stable. T2: Correct dependency arrays eliminate stale-closure bugs. T3: historyPushTimeout + draftNoticeTimeoutRef cleaned up on unmount (no memory leaks). T5: Batch DB saves parallelised with Promise.allSettled (was sequential for-await). T6: deleteMockupFromDb receives user?.id for owner-scoped DELETE. T9: URL param cleanup preserves non-processed search params.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 48 minutes and 11 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Copilot stopped reviewing on behalf of
adm01-debug due to an error
May 26, 2026 20:39
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR hardens the mockup generator hook against stale closures and timer leaks, improves batch history persistence performance, and tightens history deletion/URL-param handling.
Changes:
- Stabilizes async handlers with
useCallback, fixes dependency arrays, and adds unmount cleanup for debounced timers. - Parallelizes batch history saves using
Promise.allSettledand scopes DB deletion byuserId. - Updates URL param cleanup to only remove processed keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/hooks/mockup/useMockupGenerator.ts | Stabilizes handlers, improves batch save behavior, and cleans up timers/URL params. |
| src/hooks/mockup/mockupGenerationService.ts | File content appears replaced with a base64-like single-line payload, breaking the TS module. |
Comments suppressed due to low confidence (2)
src/hooks/mockup/mockupGenerationService.ts:1
- This file appears to have been replaced by a base64-encoded (or otherwise escaped) single-line payload rather than valid TypeScript source. As-is, the module will not compile and all imports from this service will break. Please restore the file as plain TypeScript (normal UTF-8 text), ensuring the repository contains the real source code rather than an encoded artifact.
/**
 * mockupGenerationService — Handles mockup generation API calls and history persistence.
 * Extracted from useMockupGenerator to reduce hook complexity.
 *
 * Fixes (audit 26/05/2026):
 * T4: position_x, position_y, logo_url persisted as top-level columns.
 * T7: getTechniquePrompt skips "default" in search loop.
 * T8: fetchMockupHistory limited to 200 records.
 * T10: thumbnail_url now stores mockupUrl (not logoUrl).
 */
import { supabase } from '@/integrations/supabase/client';
import { uploadLogoToStorage, downloadImageAsPdfFromUrl } from '@/lib/mockup-storage';
import { toast } from 'sonner';
import type { PersonalizationArea } from '@/components/mockup/MultiAreaManager';

export interface Technique {
  id: string;
  name: string;
  code: string | null;
  [key: string]: unknown;
}

export interface GeneratedMockup {
  id: string;
  product_id: string | null;
  product_name: string;
  product_sku: string | null;
  technique_id: string | null;
  technique_name: string;
  mockup_url: string;
  layout_url?: string | null;
  logo_url: string;
  position_x: number | null;
  position_y: number | null;
  logo_width_cm: number | null;
  logo_height_cm: number | null;
  location_name?: string | null;
  colors_count?: number | null;
  annotations?: Array<Record<string, unknown>> | null;
  client_name?: string | null;
  created_at: string;
  client_id: string | null;
}

const TECHNIQUE_PROMPTS: Record<string, string> = {
  bordado: 'as professional machine embroidery with visible thread stitch texture',
  silk: 'as screen printed with flat solid colors, matte finish',
  dtf: 'as DTF printed transfer with vibrant colors, slight glossy finish',
  laser: 'as laser engraved, etched into the material surface, monochromatic',
  laser_co2: 'as CO2 laser engraved with precise etching on organic materials',
  laser_fibra: 'as fiber laser marked on metal with high-contrast permanent mark',
  sublimacao: 'as sublimation printed, colors absorbed seamlessly into the material',
  tampografia: 'as pad printed with slightly glossy ink, precise small details',
  hot_stamping: 'as hot stamped with metallic foil finish, shiny reflective surface',
  adesivo: 'as vinyl sticker/decal applied to surface',
  uv: 'as UV printed with raised ink texture, vibrant colors',
  transfer: 'as heat transfer vinyl, smooth finish with slight sheen',
  default: 'as professionally printed/applied logo',
};

// T7 FIX: skip "default" in the loop to avoid false substring matches.
export function getTechniquePrompt(technique: Technique): string {
  const code = technique.code?.toLowerCase() || technique.name.toLowerCase();
  for (const [key, prompt] of Object.entries(TECHNIQUE_PROMPTS)) {
    if (key === 'default') continue;
    if (code.includes(key) || technique.name.toLowerCase().includes(key)) return prompt;
  }
  return TECHNIQUE_PROMPTS.default;
}

// T8 FIX: limit to 200 records to prevent unbounded payload growth.
export async function fetchMockupHistory(userId?: string): Promise<GeneratedMockup[]> {
  let query = supabase
    .from('generated_mockups')
    .select(
      'id, product_id, product_name, product_sku, technique_id, technique_name, ' +
      'mockup_url, logo_url, position_x, position_y, logo_width_cm, logo_height_cm, ' +
      'client_id, client_name, location_name, colors_count, annotations, created_at',
    )
    .order('created_at', { ascending: false })
    .limit(200);
  if (userId) query = query.eq('user_id', userId);
  const { data, error } = await query;
  if (error) throw error;
  return (data || []) as unknown as GeneratedMockup[];
}

export interface SaveMockupParams {
  userId: string;
  product: { id: string; name: string; sku?: string | null };
  technique: Technique;
  client: { id?: string; name?: string; nome_fantasia?: string; razao_social?: string } | null;
  area: PersonalizationArea;
  mockupUrl: string;
  annotations?: { id: string; x: number; y: number; text: string }[];
  extra?: { layoutUrl?: string; locationName?: string; colorsCount?: number };
}

// T4 FIX: position_x, position_y, logo_url, logo_width_cm, logo_height_cm persisted top-level.
// T10 FIX: thumbnail_url = mockupUrl (was incorrectly set to logoUrl).
export async function saveMockupToDb(params: SaveMockupParams): Promise<string | null> {
  const { userId, product, technique, client, area, mockupUrl, annotations, extra } = params;

  try {
    let logoUrl = area.logoPreview || '';
    if (area.logoPreview?.startsWith('data:')) {
      const uploadedUrl = await uploadLogoToStorage(
        userId,
        area.logoPreview,
        `${product.sku || 'product'}-${technique.code || 'tech'}`,
      );
      logoUrl = uploadedUrl || '';
    }

    let safeProductId: string | null = null;
    if (product.id) {
      const { data: productRow } = await supabase
        .from('products')
        .select('id')
        .eq('id', product.id)
        .maybeSingle();
      if (productRow) safeProductId = product.id;
    }

    const safeTechniqueId: string | null = technique.id || null;
    const clientName = client?.nome_fantasia || client?.razao_social || client?.name || null;

    const { data: insertedRow, error } = await supabase
      .from('generated_mockups')
      .insert({
        user_id: userId,
        product_id: safeProductId,
        product_name: product.name,
        product_sku: product.sku || null,
        technique_id: safeTechniqueId,
        technique_name: technique.name,
        mockup_url: mockupUrl,
        thumbnail_url: mockupUrl || null,
        logo_url: logoUrl || null,
        position_x: area.positionX,
        position_y: area.positionY,
        logo_width_cm: area.logoWidth,
        logo_height_cm: area.logoHeight,
        area_name: extra?.locationName || area.name || 'Frente',
        ai_model_used: technique.code || technique.name || 'custom',
        area_config: {
          positionX: area.positionX,
          positionY: area.positionY,
          logoWidth: area.logoWidth,
          logoHeight: area.logoHeight,
          logoUrl,
          clientName,
          colorsCount: extra?.colorsCount || null,
          annotations: annotations && annotations.length > 0 ? annotations : null,
        },
      })
      .select('id')
      .single();

    if (error) throw error;
    return insertedRow?.id || null;
  } catch (error) {
    console.error('Error saving to history:', error);
    return null;
  }
}

export interface GenerateMockupParams {
  productImage: string;
  productName: string;
  technique: Technique;
  areas: PersonalizationArea[];
}

export interface GenerateMockupResult {
  singleUrl: string | null;
  batchResults: { areaName: string; url: string }[];
}

export async function generateMockupApi(
  params: GenerateMockupParams,
): Promise<GenerateMockupResult> {
  const { productImage, productName, technique, areas } = params;
  const areasWithLogos = areas.filter((a) => a.logoPreview);
  const techniquePrompt = getTechniquePrompt(technique);

  if (areasWithLogos.length === 1) {
    const area = areasWithLogos[0];
    const isLogoUrl = area.logoPreview?.startsWith('http');

    const response = await supabase.functions.invoke('generate-mockup', {
      body: {
        productImageUrl: productImage,
        logoBase64: isLogoUrl ? undefined : area.logoPreview,
        logoUrl: isLogoUrl ? area.logoPreview : undefined,
        techniqueName: technique.name,
        techniquePrompt,
        positionX: area.positionX,
        positionY: area.positionY,
        logoWidthCm: area.logoWidth,
        logoHeightCm: area.logoHeight,
        logoRotation: area.logoRotation || 0,
        logoScale: area.logoScale ?? 100,
        productName,
        areas: areasWithLogos.map((a) => ({
          name: a.name,
          positionX: a.positionX,
          positionY: a.positionY,
          logoWidth: a.logoWidth,
          logoHeight: a.logoHeight,
          logoRotation: a.logoRotation || 0,
          logoScale: a.logoScale ?? 100,
        })),
      },
    });

    if (response.error) {
      const errData = response.data || response.error;
      if (errData?.errorCode === 'SVG_NOT_SUPPORTED') {
        throw new Error(errData.error || 'Logos SVG não são suportados. Use PNG ou JPG.');
      }
      throw response.error;
    }
    if (!response.data?.mockupUrl) throw new Error('Nenhuma imagem retornada');
    return { singleUrl: response.data.mockupUrl, batchResults: [] };
  }

  // BATCH — API calls sequential (constraint), DB saves handled in parallel by the hook (T5).
  const results: { areaName: string; url: string }[] = [];
  const failedAreas: string[] = [];

  for (const area of areasWithLogos) {
    const isLogoUrl = area.logoPreview?.startsWith('http');
    toast.info(`Gerando ${area.name}...`, { duration: 2000 });

    const response = await supabase.functions.invoke('generate-mockup', {
      body: {
        productImageUrl: productImage,
        logoBase64: isLogoUrl ? undefined : area.logoPreview,
        logoUrl: isLogoUrl ? area.logoPreview : undefined,
        techniqueName: technique.name,
        techniquePrompt,
        positionX: area.positionX,
        positionY: area.positionY,
        logoWidthCm: area.logoWidth,
        logoHeightCm: area.logoHeight,
        logoRotation: area.logoRotation || 0,
        logoScale: area.logoScale ?? 100,
        productName,
        areas: [{
          name: area.name,
          positionX: area.positionX,
          positionY: area.positionY,
          logoWidth: area.logoWidth,
          logoHeight: area.logoHeight,
          logoRotation: area.logoRotation || 0,
          logoScale: area.logoScale ?? 100,
        }],
      },
    });

    if (response.error) {
      console.error(`Error generating ${area.name}:`, response.error);
      failedAreas.push(area.name);
      continue;
    }
    if (response.data?.mockupUrl)
      results.push({ areaName: area.name, url: response.data.mockupUrl });
  }

  if (failedAreas.length > 0) {
    toast.warning(
      `${failedAreas.length} área(s) falharam: ${failedAreas.join(', ')}`,
      { duration: 5000 },
    );
  }

  if (results.length === 0) throw new Error('Nenhum mockup gerado no batch');
  return { singleUrl: results[0].url, batchResults: results };
}

export async function downloadMockupAsPdf(mockupUrl: string, sku?: string, techniqueName?: string) {
  const safeSku = (sku || 'produto').replace(/[^a-zA-Z0-9-_]/g, '-');
  const safeTechnique = (techniqueName || 'tecnica').replace(/[^a-zA-Z0-9-_]/g, '-');
  const fileName = `mockup-${safeSku}-${safeTechnique}.pdf`;
  await downloadImageAsPdfFromUrl(mockupUrl, fileName);
}

export async function deleteMockupFromDb(id: string, userId?: string): Promise<void> {
  let query = supabase.from('generated_mockups').delete().eq('id', id);
  if (userId) query = query.eq('user_id', userId);
  const { error } = await query;
  if (error) throw error;
}

export const createDefaultArea = (): PersonalizationArea => ({
  id: crypto.randomUUID(),
  name: 'Frente',
  positionX: 50,
  positionY: 50,
  logoWidth: 5,
  logoHeight: 3,
  logoRotation: 0,
  logoScale: 100,
  logoPreview: null,
});

src/hooks/mockup/useMockupGenerator.ts:1
- Both effects are unmount-only cleanup blocks and can be merged into a single
useEffect(() => () => { ... }, [])to reduce duplicated lifecycle code. This is optional, but it makes the cleanup behavior easier to audit/extend (e.g., if more refs are added later).
/**
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+623
to
+628
| const batchSaveResults = await Promise.allSettled( | ||
| result.batchResults.map((r, i) => { | ||
| const area = areasWithLogos.find((a) => a.name === r.areaName) || areasWithLogos[i]; | ||
| return saveMockupToHistory(r.url, area).then((recordId) => ({ recordId, r })); | ||
| }), | ||
| ); |
… (T4,T7,T8,T10 already merged via #473)
adm01-debug
changed the title
adm01-debug
added a commit
that referenced
this pull request
May 26, 2026
…D main (#484) Incorpora PR #478 (fix/mockup-generator-audit-10tasks) sobre HEAD atual do main. T1 — useMemo ineficaz: 7 handlers → useCallback com deps corretas T2 — Closures staladas: deps explícitas em cada useCallback async T3 — 2 memory leaks: historyPushTimeout + draftNoticeTimeoutRef com cleanup T4 — position_x/y, logo_url, logo_width/height_cm adicionados ao INSERT top-level T5 — Batch saves sequenciais → Promise.allSettled (escrita paralela) T6 — deleteMockupFromDb sem userId → filtro de owner adicionado T7 — getTechniquePrompt: skip key 'default' no loop T8 — fetchMockupHistory: .limit(200) T9 — window.history.replaceState: preserva outros query params T10 — thumbnail_url = mockupUrl (era logoUrl incorretamente) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fechado: branch rebased sobre HEAD atual do main em
rebase/478-mockup. PR substituto: #481 (será aberto agora). O conflito era causado pela divergência entre a base do PR (commit617a55c) e os 33+ commits que o Lovable fez no main desde então. Os 2 arquivos únicos desta branch (mockupGenerationService.tseuseMockupGenerator.ts) foram aplicados limpos sobre o HEAD atual.