feat(quotes): migrate updateQuote to transactional backend RPC by adm01-debug · Pull Request #404 · adm01-debug/promo-gifts-v4

adm01-debug · 2026-05-26T01:45:53Z

Motivation

Garantir atomicidade ao atualizar um orçamento para evitar escritas parciais ao mover a lógica de múltiplas operações frontend para o backend transacional.
Consolidar o fluxo que atualiza quotes, remove itens/personalizações e recria itens/personalizações em uma única transação para permitir rollback completo em erro.
Propagar mensagens de erro amigáveis e sanitizadas ao frontend para melhorar a experiência do usuário em falhas do backend.

Description

Adicionada a função SQL transacional public.update_quote_transactional em supabase/migrations/20260526103000_quote_update_transactional_rpc.sql que executa UPDATE quotes, DELETE quote_item_personalizations, DELETE quote_items, INSERT quote_items e INSERT quote_item_personalizations dentro da mesma transação.
Alterado src/services/quoteService.ts para montar payloads saneados/formatados de itens e chamar supabase.rpc('update_quote_transactional', ...) em vez de executar multiplas operações separadas no cliente.
Importada e usada a função de saneamento de mensagens sanitizeMessage para mapear/retornar um fallback público quando a RPC falhar, e adicionada verificação explícita de retorno vazio do RPC.
Pequenas correções de tipagem em src/services/quoteService.ts (any → Array<Record<string, unknown>> e options?: Record<string, unknown>) para satisfazer as regras de lint/TypeScript nos arquivos alterados.

Testing

Executado npm run typecheck que falhou devido a uma regressão de baseline de TypeScript em um arquivo não relacionado (src/components/admin/users/useUserManagement.ts).
Ferramentas de pré-commit automáticas (prettier e eslint --fix) foram executadas e passaram nos arquivos modificados após ajustes; o commit foi criado com sucesso.
A alteração adiciona a migration SQL que precisa ser aplicada no ambiente de banco para validação de integração completa em staging.

Codex Task

Summary by cubic

Migrated the quote update flow to a single transactional Supabase RPC to guarantee atomic writes and avoid partial updates. The service now calls the RPC with sanitized item/personalization payloads and returns user‑friendly errors.

Refactors
- Add public.update_quote_transactional RPC to update the quote, remove old items/personalizations, and insert new ones in one transaction (returns the updated quote row).
- Update quoteService.updateQuote to build sanitized payloads (trim product_name/notes, round2 unit_price, include nested personalizations), call supabase.rpc('update_quote_transactional'), map errors via sanitizeMessage, and throw on empty RPC response.
- Tighten TypeScript types for collections and options.
Migration
- Apply supabase/migrations/20260526103000_quote_update_transactional_rpc.sql.
- Ensure RLS policies permit the RPC’s UPDATE/INSERT/DELETE for authorized users.

^{Written for commit 3af7786. Summary will update on new commits. Review in cubic}

chatgpt-codex-connector · 2026-05-26T01:45:56Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-05-26T01:45:57Z

Warning

Review limit reached

@adm01-debug, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 48 minutes and 48 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 180e4bd4-7706-4f02-a986-7086603930cc

📥 Commits

Reviewing files that changed from the base of the PR and between a50919e and 3af7786.

📒 Files selected for processing (2)

src/services/quoteService.ts
supabase/migrations/20260526103000_quote_update_transactional_rpc.sql

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/migrate-updatequote-to-transactional-flow

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vercel · 2026-05-26T01:45:57Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
we-dream-big	Error		May 26, 2026 2:14am

supabase · 2026-05-26T01:45:58Z

This pull request has been ignored for the connected project doufsxqlfjyuvxuezpln due to reaching the limit of concurrent preview branches.
Go to Project Integrations Settings ↗︎ if you wish to update this limit.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copilot

Pull request overview

Este PR migra o fluxo de atualização de orçamentos (quotes) do frontend para uma RPC transacional no Postgres/Supabase, com o objetivo de garantir atomicidade (update + delete + reinsert de itens/personalizações) e retornar erros mais seguros para a UI.

Changes:

Adiciona a RPC public.update_quote_transactional em migration SQL para executar update/delete/insert em uma única transação.
Refatora quoteService.updateQuote para montar payloads e chamar supabase.rpc('update_quote_transactional', ...) em vez de múltiplas operações client-side.
Passa a sanitizar mensagens de erro via sanitizeMessage e ajusta tipos TS (any → tipos mais estritos).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
supabase/migrations/20260526103000_quote_update_transactional_rpc.sql	Implementa a RPC transacional para atualizar quote + recriar itens/personalizações.
src/services/quoteService.ts	Troca o update client-side por chamada RPC e aplica sanitização de erro + ajustes de tipagem.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+    discount_value = coalesce((_quote_patch->>'discount_value')::numeric, discount_value),
+    subtotal = coalesce((_quote_patch->>'subtotal')::numeric, subtotal),
+    total_amount = coalesce((_quote_patch->>'total_amount')::numeric, total_amount),
+    quote_number = coalesce(_quote_patch->>'quote_number', quote_number),
+    expires_at = coalesce((_quote_patch->>'expires_at')::timestamptz, expires_at),


+    insert into public.quote_items (
+      quote_id, product_id, product_name, quantity, unit_price, discount_percent,
+      discount_value, line_total, sort_order, notes
+    )
+    values (
+      _quote_id,
+      nullif(_item->>'product_id', '')::uuid,
+      _item->>'product_name',
+      coalesce((_item->>'quantity')::integer, 0),
+      coalesce((_item->>'unit_price')::numeric, 0),
+      coalesce((_item->>'discount_percent')::numeric, 0),
+      coalesce((_item->>'discount_value')::numeric, 0),
+      coalesce((_item->>'line_total')::numeric, 0),
+      coalesce((_item->>'sort_order')::integer, 0),
+      _item->>'notes'
+    )


+      insert into public.quote_item_personalizations (
+        quote_item_id, technique_id, technique_name, location, colors, dimensions,
+        quantity, unit_cost, total_cost, notes
+      )
+      values (
+        _new_item_id,
+        nullif(_pers->>'technique_id', '')::uuid,
+        _pers->>'technique_name',
+        _pers->>'location',
+        _pers->>'colors',
+        _pers->>'dimensions',
+        coalesce((_pers->>'quantity')::integer, 0),
+        coalesce((_pers->>'unit_cost')::numeric, 0),
+        coalesce((_pers->>'total_cost')::numeric, 0),
+        _pers->>'notes'
+      );


+      personalizations: buildPersonalizationsInsertPayload(
+        items[index]?.personalizations || [],
+        quoteId,
+      ),
+    }));


…TS2322 quoteService) (#421) Rebaseado sobre o main atual (e14f8f0). Regressões pré-existentes que bloqueavam todos os PRs no CI (nenhuma introduzida por mim): - SidebarReorganized.tsx: anotação `// rls-allow` reposicionada para imediatamente acima do `.from('discount_approval_requests')` (o checker não a reconhecia 2 linhas acima). Sem mudança de comportamento. - CoverageInsightsDashboardPage.tsx: removido non-null assertion redundante (acesso já guardado por `values.length < 2`). - quoteService.ts (logHistory): `options?: Record<string,unknown>` gerava `{}` ao inserir em colunas tipadas (TS2322 ×4, vindo do #404). Campos string agora são narrowed via typeof; `metadata` cast para `Json`. Nota: o fix anterior de useUserManagement.ts foi descartado — o main já corrigiu via `untypedFrom`. Gates verdes localmente: tsc 484/486 (sem regressão), eslint (sem regressão), seller-scope (pass). https://claude.ai/code/session_01HjiGVkF3Df9GiFjDbfxDYn Co-authored-by: Claude <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings May 26, 2026 01:45

adm01-debug added the codex label May 26, 2026 — with ChatGPT Codex Connector

vercel Bot had a problem deploying to Preview May 26, 2026 01:45 Failure

Copilot started reviewing on behalf of adm01-debug May 26, 2026 01:46 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

adm01-debug mentioned this pull request May 26, 2026

📋 Auditoria Promo Gifts — Plano de Correções em 20 Etapas (rastreamento) #264

Open

35 tasks

feat(quotes): move quote update to transactional rpc

3af7786

adm01-debug force-pushed the codex/migrate-updatequote-to-transactional-flow branch from 7e4f795 to 3af7786 Compare May 26, 2026 02:11

adm01-debug merged commit e14f8f0 into main May 26, 2026
4 of 6 checks passed

vercel Bot had a problem deploying to Preview May 26, 2026 02:14 Failure

adm01-debug mentioned this pull request May 26, 2026

fix(ci): destrava gates do main (seller-scope + TS2322 quoteService + non-null) [rebased] #421

Merged

3 tasks

adm01-debug deleted the codex/migrate-updatequote-to-transactional-flow branch May 29, 2026 13:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(quotes): migrate updateQuote to transactional backend RPC#404

feat(quotes): migrate updateQuote to transactional backend RPC#404
adm01-debug merged 1 commit into
mainfrom
codex/migrate-updatequote-to-transactional-flow

adm01-debug commented May 26, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented May 26, 2026

Uh oh!

coderabbitai Bot commented May 26, 2026 •

edited

Loading

Review limit reached

Uh oh!

vercel Bot commented May 26, 2026 •

edited

Loading

Uh oh!

supabase Bot commented May 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adm01-debug commented May 26, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Description

Testing

Summary by cubic

Uh oh!

chatgpt-codex-connector Bot commented May 26, 2026

Uh oh!

coderabbitai Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

vercel Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase Bot commented May 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adm01-debug commented May 26, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented May 26, 2026 •

edited

Loading

vercel Bot commented May 26, 2026 •

edited

Loading