Skip to content

ci: align deploy gates with project baselines#281

Merged
adm01-debug merged 1 commit into
mainfrom
fix/deploy-gates-smoke-project
May 24, 2026
Merged

ci: align deploy gates with project baselines#281
adm01-debug merged 1 commit into
mainfrom
fix/deploy-gates-smoke-project

Conversation

@adm01-debug
Copy link
Copy Markdown
Owner

@adm01-debug adm01-debug commented May 24, 2026

Summary

  • Replace the raw deploy-gate TypeScript command with the repository baseline gates: npm run typecheck and npm run lint:baseline.
  • Replace the stale Playwright project chromium with the canonical smoke wrapper npm run test:e2e:smoke, which targets chromium-smoke from playwright.config.ts.

Why

Deploy Gates / Gate 3 - E2E Smoke failed on PR #280 because --project=chromium no longer exists. The same workflow also used raw npx tsc --noEmit, which bypasses the repo's TypeScript baseline gate and can fail on known debt unrelated to a PR.

Validation

  • npm.cmd run test:e2e:smoke — 8 passed, 38 skipped
  • npm.cmd run build — passed
  • npx.cmd vitest run tests/contracts --run — 8 files, 426 tests passed
  • npm.cmd run typecheck — no TypeScript baseline regression
  • npm.cmd run lint:baseline — no ESLint baseline regression

Refs #264


Summary by cubic

Aligns Deploy Gates with project baselines to prevent false TS/lint failures and run the correct smoke tests. Replaces raw npx tsc --noEmit and Playwright --project=chromium with npm run typecheck, npm run lint:baseline, and npm run test:e2e:smoke (refs #264).

Written for commit add5f4f. Summary will update on new commits. Review in cubic

Copilot AI review requested due to automatic review settings May 24, 2026 18:09
@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
we-dream-big Ready Ready Preview, Comment May 24, 2026 6:10pm

@supabase
Copy link
Copy Markdown

supabase Bot commented May 24, 2026

This pull request has been ignored for the connected project doufsxqlfjyuvxuezpln because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

Warning

Review limit reached

@adm01-debug, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 5 reviews/hour. Refill in 33 minutes and 17 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ee258f91-a1d3-4f64-a455-df90830863e6

📥 Commits

Reviewing files that changed from the base of the PR and between 35a9708 and add5f4f.

📒 Files selected for processing (1)
  • .github/workflows/deploy-gates.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deploy-gates-smoke-project

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “Deploy Gates” GitHub Actions workflow to use the repository’s canonical baseline gates for TypeScript and ESLint, and to run the correct Playwright smoke project via the existing npm wrapper script. This aligns CI behavior with how the repo is intended to be validated, avoiding failures from stale Playwright project names and bypassed baseline checks.

Changes:

  • Replace raw npx tsc --noEmit with npm run typecheck (TS baseline gate).
  • Replace ad-hoc lint invocation with npm run lint:baseline (ESLint baseline gate).
  • Replace npx playwright test --project=chromium smoke invocation with npm run test:e2e:smoke (targets chromium-smoke).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adm01-debug adm01-debug merged commit 7835020 into main May 24, 2026
29 of 37 checks passed
@adm01-debug adm01-debug deleted the fix/deploy-gates-smoke-project branch May 24, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants