ci: align deploy gates with project baselines#281
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Your plan currently allows 5 reviews/hour. Refill in 33 minutes and 17 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates the “Deploy Gates” GitHub Actions workflow to use the repository’s canonical baseline gates for TypeScript and ESLint, and to run the correct Playwright smoke project via the existing npm wrapper script. This aligns CI behavior with how the repo is intended to be validated, avoiding failures from stale Playwright project names and bypassed baseline checks.
Changes:
- Replace raw
npx tsc --noEmitwithnpm run typecheck(TS baseline gate). - Replace ad-hoc lint invocation with
npm run lint:baseline(ESLint baseline gate). - Replace
npx playwright test --project=chromiumsmoke invocation withnpm run test:e2e:smoke(targetschromium-smoke).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
npm run typecheckandnpm run lint:baseline.chromiumwith the canonical smoke wrappernpm run test:e2e:smoke, which targetschromium-smokefromplaywright.config.ts.Why
Deploy Gates / Gate 3 - E2E Smokefailed on PR #280 because--project=chromiumno longer exists. The same workflow also used rawnpx tsc --noEmit, which bypasses the repo's TypeScript baseline gate and can fail on known debt unrelated to a PR.Validation
npm.cmd run test:e2e:smoke— 8 passed, 38 skippednpm.cmd run build— passednpx.cmd vitest run tests/contracts --run— 8 files, 426 tests passednpm.cmd run typecheck— no TypeScript baseline regressionnpm.cmd run lint:baseline— no ESLint baseline regressionRefs #264
Summary by cubic
Aligns Deploy Gates with project baselines to prevent false TS/lint failures and run the correct smoke tests. Replaces raw
npx tsc --noEmitand Playwright--project=chromiumwithnpm run typecheck,npm run lint:baseline, andnpm run test:e2e:smoke(refs #264).Written for commit add5f4f. Summary will update on new commits. Review in cubic