Skip to content

test: corrige AppLogo.visual (teste quebrado no main) + import nao-usado#210

Merged
adm01-debug merged 1 commit into
mainfrom
fix/applogo-visual-h9-drift
May 24, 2026
Merged

test: corrige AppLogo.visual (teste quebrado no main) + import nao-usado#210
adm01-debug merged 1 commit into
mainfrom
fix/applogo-visual-h9-drift

Conversation

@adm01-debug
Copy link
Copy Markdown
Owner

@adm01-debug adm01-debug commented May 24, 2026

O que este PR faz

Corrige 2 deltas de teste remanescentes depois que o grosso da faxina de testes drifted (7 de 9 alvos) já entrou no main via #124/#196/#178.

🐛 AppLogo.visual — teste FALHANDO no main

O SUT AppLogo.tsx (L29) define o sidebar variant com h-9 w-9, mas o teste esperava h-10 w-10 → o teste está vermelho no main hoje. O re-import do Lovable reverteu o tamanho do ícone no sidebar. Alinho o assert ao SUT (h-9 w-9). 4/4 verde.

🧹 ScenarioSimulation — import não-usado

Remove signupSchema do import (não usado no corpo; loginSchema permanece). Drift positivo de lint.

Contexto

O PR #125 (escopo original de 9 testes drifted) foi fechado sem merge porque outras instâncias paralelas resolveram 7 dos alvos no main de forma equivalente/melhor (PriceFreshnessBadge TS2322, AdminStandardRules naming-convention, AuthBranding ×2, QuoteBuilderDiscountAdvanced, useCatalogState via describe.skip, schema fob_pre). Estes 2 são o que sobrou de genuinamente necessário — o AppLogo.visual em particular é um teste quebrado em produção que ninguém havia pego.

Validado localmente: TZ=America/Sao_Paulo vitest, 6/6 nos 2 arquivos, 0 warnings de lint.


Summary by cubic

Fix failing AppLogo.visual test on main by updating the expected sidebar icon size to h-9 w-9 to match the component. Remove the unused signupSchema import from ScenarioSimulation.test to clear lint noise.

Written for commit 622694d. Summary will update on new commits. Review in cubic

- AppLogo.visual: SUT sidebar variant usa h-9 w-9 mas teste esperava h-10 -> teste falhando no main; alinha ao SUT (4/4)
- ScenarioSimulation: remove import signupSchema nao-usado
Copilot AI review requested due to automatic review settings May 24, 2026 01:12
@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
we-dream-big Ready Ready Preview, Comment May 24, 2026 1:13am

@supabase
Copy link
Copy Markdown

supabase Bot commented May 24, 2026

This pull request has been ignored for the connected project doufsxqlfjyuvxuezpln because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

Warning

Review limit reached

@adm01-debug, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 42 minutes and 22 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2b53f505-48c2-4fb3-a816-3b8c4b638a87

📥 Commits

Reviewing files that changed from the base of the PR and between 3078fb2 and 622694d.

📒 Files selected for processing (2)
  • src/components/layout/AppLogo.visual.test.tsx
  • src/tests/ScenarioSimulation.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/applogo-visual-h9-drift

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Este PR corrige drift residual em testes após o re-import do Lovable, alinhando asserts ao SUT atual e removendo ruído de lint.

Changes:

  • Atualiza o teste visual do AppLogo para esperar o tamanho correto do ícone no variant sidebar (h-9 w-9), consistente com AppLogo.tsx.
  • Remove signupSchema de ScenarioSimulation.test.ts por estar sem uso, limpando import não-utilizado.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/layout/AppLogo.visual.test.tsx Ajusta o assert do variant sidebar para refletir o tamanho real aplicado pelo componente (h-9 w-9).
src/tests/ScenarioSimulation.test.ts Remove import não-usado (signupSchema) mantendo apenas o schema efetivamente exercitado no teste (loginSchema).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adm01-debug adm01-debug merged commit 08f7f58 into main May 24, 2026
22 of 25 checks passed
@adm01-debug adm01-debug deleted the fix/applogo-visual-h9-drift branch May 24, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants