Skip to content

refactor(eslint): Etapas 14-16 — elimina top arquivos do baseline (442→177)#209

Merged
adm01-debug merged 10 commits into
mainfrom
chore/eslint-etapas-14-16
May 24, 2026
Merged

refactor(eslint): Etapas 14-16 — elimina top arquivos do baseline (442→177)#209
adm01-debug merged 10 commits into
mainfrom
chore/eslint-etapas-14-16

Conversation

@adm01-debug
Copy link
Copy Markdown
Owner

@adm01-debug adm01-debug commented May 24, 2026

Etapas 14-16 — eliminação dos top arquivos do baseline ESLint

Conclui as Etapas 14-16 do plano de 20 passos (PR #124). Branch criada a partir do main atual (c832c1f), diff limpo.

Arquivos-alvo levados a 0 problemas de lint

  • Etapa 14: SupabaseConnectionsTab.tsx
  • Etapa 15: CatalogContent.tsx, ProductQuickView.tsx
  • Etapa 16: useSimulatorWizard.ts (15× react-hooks/exhaustive-deps via dispatch estável de useReducer), useGlobalSearch.ts

Abordagem (tsc-safe)

  • Remoção de imports não usados via TS LanguageService.organizeImports (RemoveUnused).
  • Prefixo _ em identificadores não usados (params/catch/const), preservando destructuring/bindings.
  • dispatch (estável) adicionado a 15 deps arrays do useSimulatorWizard.

Resultado

  • Baseline ESLint: 442 → 177 erros (245 arquivos). .eslint-baseline.json regenerado sobre o main atual.
  • Gate check-eslint-baseline.mjs: verde (177 = 177, sem regressão).
  • .tsc-baseline.json intacto — PR puramente de lint.
  • 116 arquivos alterados (+206 / −821). Sem mudança de comportamento em runtime.

Substitui o #207 (que tinha merge-base antigo e diff poluído).


Summary by cubic

Cut ESLint baseline errors from 442 to 177 by cleaning unused code and fixing hook dependencies across top offenders. Lint-only refactor with no runtime changes; regenerated .eslint-baseline.json, check-eslint-baseline.mjs passes, and .tsc-baseline.json remains unchanged.

  • Refactors
    • Removed unused imports/vars and prefixed unused identifiers with _.
    • Resolved react-hooks/exhaustive-deps by adding stable dispatch in useSimulatorWizard (15 deps arrays).
    • Brought these files to zero lint issues: SupabaseConnectionsTab.tsx, CatalogContent.tsx, ProductQuickView.tsx, useSimulatorWizard.ts, useGlobalSearch.ts.

Written for commit ed5cf0a. Summary will update on new commits. Review in cubic

Copilot AI review requested due to automatic review settings May 24, 2026 01:11
@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
we-dream-big Ready Ready Preview, Comment May 24, 2026 1:12am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

Warning

Review limit reached

@adm01-debug, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 43 minutes and 15 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 77da7908-5905-4b80-909a-a4ba789601e5

📥 Commits

Reviewing files that changed from the base of the PR and between 377c7ac and ed5cf0a.

📒 Files selected for processing (116)
  • .eslint-baseline.json
  • src/components/auth/ForgotPasswordForm.tsx
  • src/components/auth/PasswordStrengthIndicator.tsx
  • src/components/bi/BIAiCopilot.tsx
  • src/components/bi/ClientComparator.tsx
  • src/components/bi/ExecutiveSummaryButton.tsx
  • src/components/catalog/CatalogContent.tsx
  • src/components/categories/CategorySidebarPanel.tsx
  • src/components/compare/ComparisonHighlights.tsx
  • src/components/dashboard/QuickActionsPanel.tsx
  • src/components/dashboard/RecentKitsWidget.tsx
  • src/components/expert/ExpertChatDialog.tsx
  • src/components/filters/ColorGroupFilter.tsx
  • src/components/filters/CommemorativeDateFilter.tsx
  • src/components/filters/ExternalCategoryFilter.tsx
  • src/components/filters/FilterPanel.tsx
  • src/components/filters/filter-panel/sections/SizeFilter.tsx
  • src/components/intelligence/IntelligenceFilterBar.tsx
  • src/components/intelligence/RankingFilterToolbar.tsx
  • src/components/intelligence/SegmentAnalysis.tsx
  • src/components/inventory/StockAlertDialogs.tsx
  • src/components/inventory/StockCategoryTreeSelect.tsx
  • src/components/inventory/StockDashboard.tsx
  • src/components/inventory/StockFilterToolbar.tsx
  • src/components/kit-builder/BoxSelector.tsx
  • src/components/kit-builder/DiscontinuedItemsAlert.tsx
  • src/components/kit-builder/KitIsometricPreview.tsx
  • src/components/kit-builder/KitSummary.tsx
  • src/components/kit-builder/SimilarKitsWidget.tsx
  • src/components/layout/GlobalOverlay.tsx
  • src/components/layout/SidebarReorganized.tsx
  • src/components/mobile/MobileProductActions.tsx
  • src/components/mobile/SmartMobileNav.tsx
  • src/components/mockup/LogoColorAnalyzer.tsx
  • src/components/mockup/MockupConfigPanel.tsx
  • src/components/mockup/MockupProductSelector.tsx
  • src/components/mockup/MockupResultCard.tsx
  • src/components/mockup/MockupWizard.tsx
  • src/components/navigation/DynamicBreadcrumbs.tsx
  • src/components/notifications/NotificationDrawer.tsx
  • src/components/notifications/badge-stats/EfficiencyGrid.tsx
  • src/components/notifications/badge-stats/useNotificationsMetricsPanel.ts
  • src/components/onboarding/OnboardingTour.tsx
  • src/components/pdf/PropostaComercialTailwind.tsx
  • src/components/pdf/proposal/LogoWithTransparentBg.tsx
  • src/components/pricing/ProductPriceSimulator.tsx
  • src/components/pricing/simulator/EngravingList.tsx
  • src/components/pricing/simulator/MultiEngravingResult.tsx
  • src/components/pricing/simulator/PriceResultV51.tsx
  • src/components/pricing/simulator/QuantityAndResult.tsx
  • src/components/products/BulkActionBar.tsx
  • src/components/products/FutureStockModal.tsx
  • src/components/products/PackagingModal.tsx
  • src/components/products/ProductCard.tsx
  • src/components/products/ProductGallery.tsx
  • src/components/products/ProductGrid.test.tsx
  • src/components/products/ProductGrid.tsx
  • src/components/products/ProductListItem.tsx
  • src/components/products/ProductQuickView.tsx
  • src/components/products/ProductSparkline.tsx
  • src/components/products/ProductStickyHeader.tsx
  • src/components/products/ProductTableView.tsx
  • src/components/products/QuickAddToQuote.tsx
  • src/components/products/RecentlyViewedBar.tsx
  • src/components/products/RelatedProducts.tsx
  • src/components/products/SupplierComparisonCards.tsx
  • src/components/products/customization/ConfigurationPanel.tsx
  • src/components/products/customization/__tests__/LocationPanelAdvanced.test.tsx
  • src/components/products/share/ShareAllColorsDialog.tsx
  • src/components/products/share/usePhotoDownload.ts
  • src/components/providers/AppBootstrap.tsx
  • src/components/quotes/AdminTemplatesManager.tsx
  • src/components/quotes/PdfGenerationDialog.tsx
  • src/components/quotes/QuoteAutoSave.tsx
  • src/components/quotes/QuoteBuilderProductSearch.tsx
  • src/components/quotes/QuoteBuilderSummaryColumn.tsx
  • src/components/quotes/QuoteStatusTimeline.tsx
  • src/components/quotes/QuoteValidityBanner.tsx
  • src/components/quotes/QuoteVersionCompare.tsx
  • src/components/quotes/QuoteVersionHistory.tsx
  • src/components/quotes/SaveAsTemplateButton.tsx
  • src/components/ramo-atividade/RamoAtividadeGroupAccordion.tsx
  • src/components/reports/ScheduledReportsManager.tsx
  • src/components/search/GlobalSearchHelpers.tsx
  • src/components/search/GlobalSearchIdleState.tsx
  • src/components/search/GlobalSearchPalette.tsx
  • src/components/search/VoiceSearchOverlay.tsx
  • src/components/security/PushNotificationSettings.tsx
  • src/components/simulator/MockupPreview.tsx
  • src/components/simulator/TechniqueCard.tsx
  • src/components/simulator/wizard/ConfirmedSummary.tsx
  • src/components/simulator/wizard/PersonalizationTabs.tsx
  • src/components/simulator/wizard/StepProduct.tsx
  • src/components/simulator/wizard/StepSpecs.tsx
  • src/components/simulator/wizard/WizardContextBar.tsx
  • src/components/ui/LoadingButton.tsx
  • src/components/ui/LoadingState.tsx
  • src/contexts/AuthContext.tsx
  • src/data/mock-match-products.ts
  • src/hooks/auth/useProfileRoles.ts
  • src/hooks/simulator/useSimulatorWizard.ts
  • src/hooks/ui/useGlobalShortcuts.ts
  • src/pages/Simulation.tsx
  • src/pages/auth/AuthBranding.tsx
  • src/pages/auth/ResetPassword.tsx
  • src/pages/auth/SSOCallbackPage.tsx
  • src/pages/quotes/useQuotesListPage.ts
  • src/services/authService.ts
  • src/tests/AdminMobileInteraction.test.tsx
  • src/tests/AdminStructuralComparison.test.tsx
  • src/tests/CatalogFilteringLogic.test.tsx
  • src/tests/ScenarioSimulation.test.ts
  • src/tests/quotePersistence.test.ts
  • src/types/jspdf-autotable.d.ts
  • src/utils/excelExport.ts
  • src/utils/performance.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/eslint-etapas-14-16

Comment @coderabbitai help to get the list of available commands and usage tips.

@supabase
Copy link
Copy Markdown

supabase Bot commented May 24, 2026

This pull request has been ignored for the connected project doufsxqlfjyuvxuezpln because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@adm01-debug adm01-debug merged commit 3078fb2 into main May 24, 2026
18 of 23 checks passed
@adm01-debug adm01-debug deleted the chore/eslint-etapas-14-16 branch May 24, 2026 01:12
@adm01-debug adm01-debug review requested due to automatic review settings May 24, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant