Skip to content

fix(test): corrigir import de QuoteBuilderPage no teste de delivery tooltip#18

Merged
adm01-debug merged 1 commit into
mainfrom
fix/vitest-quotebuilderpage-import
May 19, 2026
Merged

fix(test): corrigir import de QuoteBuilderPage no teste de delivery tooltip#18
adm01-debug merged 1 commit into
mainfrom
fix/vitest-quotebuilderpage-import

Conversation

@adm01-debug
Copy link
Copy Markdown
Owner

@adm01-debug adm01-debug commented May 19, 2026

Bug

O step 🧪 Unit Tests (Vitest) do workflow Quote Builder Delivery Quality está falhando no main desde que o #16 destravou o npm ci. Não é regressão do #16 — o bug já existia, mas estava escondido pelo erro de npm ci em 1s que parava o pipeline antes de chegar nos testes.

Causa raiz

src/pages/QuoteBuilderPage.tsx foi movido para src/pages/quotes/QuoteBuilderPage.tsx em refactor anterior. O teste em src/pages/__tests__/QuoteBuilderDeliveryTooltip.test.tsx ficou apontando pro path antigo:

import QuoteBuilderPage from '../QuoteBuilderPage';  // ← src/pages/QuoteBuilderPage.tsx (não existe)

Erro:

Failed to resolve import "../QuoteBuilderPage" from "src/pages/__tests__/QuoteBuilderDeliveryTooltip.test.tsx".

Fix

1 caractere — adicionar quotes/ no path:

-import QuoteBuilderPage from '../QuoteBuilderPage';
+import QuoteBuilderPage from '../quotes/QuoteBuilderPage';

Validação local

$ npx vitest run src/pages/__tests__/QuoteBuilderDeliveryTooltip.test.tsx
 ✓ src/pages/__tests__/QuoteBuilderDeliveryTooltip.test.tsx (4 tests) 1672ms
   ✓ should show the tooltip content on hover  580ms
   ✓ should hide the tooltip content when unhovering  409ms
   ✓ should hide the tooltip content when pressing Escape  398ms

 Test Files  1 passed (1)
      Tests  4 passed (4)

Escopo

1 arquivo, +1/-1 linha.

Não toca

  • Os outros failures pré-existentes do main (Migrations sync guard, E2E smoke, Visual Baseline, Vercel preview, Test Coverage) — backlog separado.

Summary by cubic

Fixes the broken import in src/pages/__tests__/QuoteBuilderDeliveryTooltip.test.tsx to point to ../quotes/QuoteBuilderPage, unblocking the Vitest unit test step in the Quote Builder Delivery Quality workflow.

Written for commit 75922b5. Summary will update on new commits. Review in cubic

Summary by CodeRabbit

  • Tests
    • Ajustes internos em importações de testes para melhor organização da suite de testes.

Review Change Stack

…ooltip

O arquivo QuoteBuilderPage.tsx foi movido de src/pages/ para
src/pages/quotes/ em refactor anterior, mas o teste em
src/pages/__tests__/QuoteBuilderDeliveryTooltip.test.tsx ficou com
import apontando pro path antigo, fazendo Vite/vitest abortar com
'Failed to resolve import "../QuoteBuilderPage"' antes mesmo de
rodar qualquer assercao.

Fix: '../QuoteBuilderPage' -> '../quotes/QuoteBuilderPage'

Validado localmente: 4 testes do arquivo passam (antes: 0 — suite
failed to collect).

Desbloqueia o step '🧪 Unit Tests (Vitest)' do workflow Quote
Builder Delivery Quality, que estava falhando como dano colateral
de correção anterior do package-lock (#16).
Copilot AI review requested due to automatic review settings May 19, 2026 19:28
@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
we-dream-big Ready Ready Preview, Comment May 19, 2026 7:29pm

@adm01-debug adm01-debug merged commit 77d0c10 into main May 19, 2026
9 of 18 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 539eebc3-bc2a-4f6b-8aa1-9f2d33d8c4c1

📥 Commits

Reviewing files that changed from the base of the PR and between e392ea4 and 75922b5.

📒 Files selected for processing (1)
  • src/pages/__tests__/QuoteBuilderDeliveryTooltip.test.tsx

Walkthrough

Ajuste de caminho de importação no arquivo de teste QuoteBuilderDeliveryTooltip.test.tsx. A importação de QuoteBuilderPage foi atualizada para apontar para ../quotes/QuoteBuilderPage, refletindo reorganização da estrutura de diretórios do projeto.

Changes

Ajuste de Importação - Reorganização de Módulo

Layer / File(s) Summary
Correção de Caminho de Importação
src/pages/__tests__/QuoteBuilderDeliveryTooltip.test.tsx
Importação de QuoteBuilderPage ajustada para ../quotes/QuoteBuilderPage acompanhando reorganização do módulo no novo subdiretório.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutos

Suggested reviewers

  • Copilot
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vitest-quotebuilderpage-import

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrige um failure de CI nos unit tests (Vitest) ajustando o path de import do QuoteBuilderPage após um refactor que moveu o arquivo para src/pages/quotes/.

Changes:

  • Atualiza o import no teste QuoteBuilderDeliveryTooltip para apontar para ../quotes/QuoteBuilderPage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

adm01-debug added a commit that referenced this pull request May 19, 2026
…ity e visual-tests

O workflow Quote Builder Delivery Quality estava falhando no step
'Unit Tests (Vitest)' mesmo apos o fix do import (#18), porque o
workflow hardcodava node-version: 18 e jsdom@29 (bumpado em B-1 da
auditoria pre-prod) e suas deps transitivas (html-encoding-sniffer
+ @exodus/bytes) so funcionam em Node 20+.

Erro reproduzido localmente com Node 18:
  Error: require() of ES Module .../html-encoding-sniffer.js not supported.

Fix: usar node-version-file: '.nvmrc' (= 20.20.2) em ambos os
workflows, alinhando com o padrao ja usado em ci.yml e e2e.yml.
Elimina o drift entre workflows e a versao canonica do projeto.

visual-tests.yml ja tinha sido bumpado para Node 20 em #14, mas
com hardcode; consolida com '.nvmrc' para evitar reincidencia.
adm01-debug added a commit that referenced this pull request May 19, 2026
…l-tests workflows (#19)

O workflow Quote Builder Delivery Quality estava falhando no step
'Unit Tests (Vitest)' mesmo apos o fix do import (#18), porque o
workflow hardcodava node-version: 18 e jsdom@29 (bumpado em B-1 da
auditoria pre-prod) e suas deps transitivas (html-encoding-sniffer
+ @exodus/bytes) so funcionam em Node 20+.

Erro reproduzido localmente com Node 18:
  Error: require() of ES Module .../html-encoding-sniffer.js not supported.

Fix: usar node-version-file: '.nvmrc' (= 20.20.2) em ambos os
workflows, alinhando com o padrao ja usado em ci.yml e e2e.yml.
Elimina o drift entre workflows e a versao canonica do projeto.

visual-tests.yml ja tinha sido bumpado para Node 20 em #14, mas
com hardcode; consolida com '.nvmrc' para evitar reincidencia.
@adm01-debug adm01-debug deleted the fix/vitest-quotebuilderpage-import branch May 24, 2026 17:42
adm01-debug added a commit that referenced this pull request May 24, 2026
…ity e visual-tests (#277)

O workflow Quote Builder Delivery Quality estava falhando no step
'Unit Tests (Vitest)' mesmo apos o fix do import (#18), porque o
workflow hardcodava node-version: 18 e jsdom@29 (bumpado em B-1 da
auditoria pre-prod) e suas deps transitivas (html-encoding-sniffer
+ @exodus/bytes) so funcionam em Node 20+.

Erro reproduzido localmente com Node 18:
  Error: require() of ES Module .../html-encoding-sniffer.js not supported.

Fix: usar node-version-file: '.nvmrc' (= 20.20.2) em ambos os
workflows, alinhando com o padrao ja usado em ci.yml e e2e.yml.
Elimina o drift entre workflows e a versao canonica do projeto.

visual-tests.yml ja tinha sido bumpado para Node 20 em #14, mas
com hardcode; consolida com '.nvmrc' para evitar reincidencia.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants