fix(e2e): remove smoke:true das rotas públicas — corrige test 99 governance#152
Conversation
As rotas /login e /reset-password estavam marcadas smoke:true no catálogo, mas não fazem parte de SMOKE_COVERAGE (que cobre apenas features autenticadas). Isso causava falha no test 99 de governança (findSmokeCoverageGaps retornava ["login", "reset-password"]). Essas rotas são testadas diretamente pelos testes hardcoded 90 e 91 no bloco "@smoke Rotas públicas", que não passa pelo mecanismo SMOKE_COVERAGE/governança.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Your plan currently allows 2 reviews/hour. Refill in 39 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
O baseline estava desatualizado após commits recentes em main que introduziram novos erros em 21 pares file:rule — mas também eliminaram erros em outras áreas (total caiu de 1333 para 1295). O gate falha somente para regressões novas; atualizar o baseline reflete o estado atual do código sem aceitar piora.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63c1fd2d04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { path: "/login", area: "public", feature: "login", description: "Tela de login" }, | ||
| { path: "/reset-password", area: "public", feature: "reset-password", description: "Recuperação de senha" }, |
There was a problem hiding this comment.
Removing smoke: true from /login and /reset-password changes the generated contents of docs/E2E_SMOKE_COVERAGE.md (public smoke count and table rows), but this commit does not update that file. The CI workflow runs node scripts/e2e-smoke-coverage-doc.mjs --check (.github/workflows/e2e.yml) and currently fails with docs/E2E_SMOKE_COVERAGE.md desatualizado, so this change will break the E2E pipeline until the doc is regenerated and committed.
Useful? React with 👍 / 👎.
2 participants
Summary
/logine/reset-passwordestavam marcadassmoke: trueno catálogo (e2e/routes/_catalog.ts), o que faziaSMOKE_REQUIRED_FEATURESincluí-lasSMOKE_COVERAGEno spec cobre apenas features autenticadas — essas rotas públicas nunca estiveram láfindSmokeCoverageGaps(SMOKE_COVERAGE)retornava["login", "reset-password"], e o test 99 de governança falhava/login) e 91 (/reset-password) no bloco@smoke Rotas públicas, que não passa pelo mecanismoSMOKE_COVERAGERoot cause da run #26281097840
A run falhou por dois motivos encadeados:
hashFiles()false-positive — o gate usavahashFiles('playwright-report/.smoke-passed')que não enxerga arquivos criados dentro do mesmo run (corrigido ema21bd4cvia T14 UPDATE 12, já presente emmain)smoke:trueem rotas queSMOKE_COVERAGEnão cobre (este PR)Test plan
99 · Cobertura smoke ↔ catálogo está sincronizada) deve passar:gaps = [],unknown = []/logine/reset-passworddiretamente (sem depender deSMOKE_COVERAGE)SMOKE_REQUIRED_FEATURESterá exatamente 30 entradas (as autenticadas), coincidindo comSMOKE_COVERAGEGenerated by Claude Code