fix(secrets): corrige contratos quebrados no módulo de secrets/conexões#132
Conversation
- Renomeia parâmetro `updatedById` → `updatedBy` em `buildUpdatedTooltip` para alinhar com `SecretStatus.updated_by` e eliminar confusão de nomenclatura - Corrige path dos mocks de teste: `@/hooks/useSecretsManager` → `@/hooks/admin` e `@/hooks/useConnectionTestDetails` → `@/hooks/intelligence` (paths reais dos barrel exports) usando o padrão `importOriginal` para não quebrar outros exports - Adiciona campos ausentes no mock de `useSecretsManager` (`isLoading`, `secrets`, `listError`, `list`, `refreshCache`) para cobrir todo o contrato do hook - Corrige `refresh: vi.fn()` → `refetch: vi.fn()` nos mocks de `useConnectionTestDetails` para refletir o campo real do `ConnectionTestDetailsState` - Remove cast `as any` no teste de modo rotate, adicionando o campo obrigatório `name` ao objeto `SecretStatus` https://claude.ai/code/session_01QL2QShzSzFYzonYBTVcBhT
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Summary
updatedById→updatedByembuildUpdatedTooltip(SecretField.utils.ts) — alinha o nome do parâmetro comSecretStatus.updated_by, eliminando confusão de nomenclatura@/hooks/useSecretsManager→@/hooks/admine@/hooks/useConnectionTestDetails→@/hooks/intelligence(os caminhos reais dos barrel exports), usandoimportOriginalpara preservar demais exportsuseSecretsManager:isLoading,secrets,listError,list,refreshCache— cobrindo todo o contrato do hookrefresh→refetchnos mocks deuseConnectionTestDetails— reflete o campo real deConnectionTestDetailsStateas anyremovido no teste de modo rotate; campo obrigatórionameadicionado ao objetoSecretStatusTest plan
npx vitest run tests/components/admin/SecretField.test.tsx— 19 testes passamnpx vitest run tests/components/admin/SecretField.a11y.test.tsx— 8 testes passamnpx vitest run tests/components/admin/pluralization.test.tsx— 11 testes passamhttps://claude.ai/code/session_01QL2QShzSzFYzonYBTVcBhT
Generated by Claude Code
Summary by cubic
Corrige contratos no módulo de secrets/conexões, alinhando nomes e mocks de hooks para evitar erros na UI e nos testes. Atualiza o utilitário de tooltip e ajusta os testes para refletirem os barrel exports e estados reais.
buildUpdatedTooltip: renomeia parâmetroupdatedById→updatedBypara alinhar comSecretStatus.updated_by.@/hooks/useSecretsManager→@/hooks/admine@/hooks/useConnectionTestDetails→@/hooks/intelligence, usandoimportOriginalpara preservar exports.useSecretsManagermock: adicionaisLoading,secrets,listError,list,refreshCache.useConnectionTestDetailsmock:refresh→refetchconformeConnectionTestDetailsState.as anyno teste de rotate, adicionando campo obrigatórionameemSecretStatus.Written for commit ed48aef. Summary will update on new commits. Review in cubic