Skip to content

audit + fixes: forensic 2026-05-23 — 9 commits, 5 P0/P1 fixes, ESLint -34 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adm01-debug wants to merge 9 commits into from
+1,511 −515
Closed

audit + fixes: forensic 2026-05-23 — 9 commits, 5 P0/P1 fixes, ESLint -34 #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3c175b7
docs(audit): forensic bug audit 2026-05-23 — reconciliation of 4 prio…
claude May 23, 2026
c41d0ff
fix(connections): add validateUrlFormat fail-fast guard (post-mortem …
claude May 23, 2026
6ae8d82
chore(ci): T-FIX-3 — bump GitHub Actions before 2026-06-02 cutoff
claude May 23, 2026
978a6fe
fix(test): silence naming-convention warnings for PascalCase JSX comp…
claude May 23, 2026
5d3b377
fix(test): type the snapshot cases tuple to satisfy strict TS
claude May 23, 2026
a4509e1
fix(hooks): eliminate 4 rules-of-hooks violations via optional contex…
claude May 23, 2026
c4e9879
docs(audit): senior QA pass 2 — actual execution evidence + bundle an…
claude May 23, 2026
d76689e
fix(qa): batch — CORS migration, baseline refresh, mock updates, scen…
claude May 23, 2026
79f3bf1
docs(audit): pass-3 — capture batch fixes (CORS, baselines, mocks, sc…
claude May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 4 additions & 40 deletions .eslint-baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
{
"generatedAt": "2026-05-22T03:12:40.396Z",
"totalErrors": 473,
"generatedAt": "2026-05-23T02:18:35.830Z",
"totalErrors": 439,
"counts": {
"src/components/access/DevAccessDeniedPage.tsx": {
"react-hooks/exhaustive-deps": 1
},
"src/components/admin/OwnershipRepairDialog.tsx": {
"@typescript-eslint/naming-convention": 1
},
"src/components/admin/connections/ConnectionTestDetailsDialog.tsx": {
"no-duplicate-imports": 1
},
"src/components/admin/connections/ConnectionTestHistoryPanel.tsx": {
"@typescript-eslint/no-non-null-assertion": 1
},
Expand Down Expand Up @@ -184,11 +181,7 @@
"@typescript-eslint/naming-convention": 1
},
"src/components/common/EnhancedSpotlight.tsx": {
"@typescript-eslint/no-explicit-any": 1,
"@typescript-eslint/no-unused-vars": 1,
"no-empty": 1,
"react-hooks/exhaustive-deps": 2,
"react-hooks/rules-of-hooks": 1
"react-hooks/exhaustive-deps": 2
},
"src/components/compare/ComparisonDuelView.tsx": {
"@typescript-eslint/no-unused-vars": 1
Expand Down Expand Up @@ -364,22 +357,12 @@
"src/components/layout/GlobalOverlay.tsx": {
"@typescript-eslint/no-unused-vars": 4
},
"src/components/layout/Header.tsx": {
"@typescript-eslint/no-unused-vars": 9
},
"src/components/layout/MainLayout.tsx": {
"@typescript-eslint/no-unused-vars": 2,
"react-hooks/exhaustive-deps": 1
},
"src/components/layout/SidebarReorganized.tsx": {
"@typescript-eslint/no-unused-vars": 5
},
"src/components/layout/sidebar/SidebarBrandHeader.tsx": {
"@typescript-eslint/no-explicit-any": 1,
"@typescript-eslint/no-unused-vars": 1,
"no-empty": 1,
"react-hooks/rules-of-hooks": 1
},
"src/components/layout/sidebar/SidebarNavGroup.tsx": {
"react-hooks/exhaustive-deps": 1
},
Expand Down Expand Up @@ -869,11 +852,7 @@
"@typescript-eslint/no-unused-vars": 1
},
"src/components/ui/ShortcutsHelpDialog.tsx": {
"@typescript-eslint/naming-convention": 1,
"@typescript-eslint/no-explicit-any": 2,
"@typescript-eslint/no-unused-vars": 1,
"no-empty": 1,
"react-hooks/rules-of-hooks": 1
"@typescript-eslint/naming-convention": 1
},
"src/components/ui/currency-input.tsx": {
"@typescript-eslint/no-explicit-any": 1
Expand All @@ -884,9 +863,6 @@
"src/components/ui/stat-card.tsx": {
"@typescript-eslint/naming-convention": 2
},
"src/contexts/AuthContext.test.tsx": {
"@typescript-eslint/consistent-type-imports": 1
},
"src/contexts/AuthContext.tsx": {
"@typescript-eslint/no-explicit-any": 2,
"@typescript-eslint/no-unused-vars": 7
Expand Down Expand Up @@ -1066,12 +1042,6 @@
"src/hooks/simulator/useWizardPersistence.ts": {
"react-hooks/exhaustive-deps": 1
},
"src/hooks/ui/useGlobalShortcuts.ts": {
"@typescript-eslint/no-explicit-any": 1,
"@typescript-eslint/no-unused-vars": 1,
"react-hooks/exhaustive-deps": 1,
"react-hooks/rules-of-hooks": 1
},
"src/lib/auth/auth-flow-tracer.ts": {
"eqeqeq": 1
},
Expand Down Expand Up @@ -1250,9 +1220,6 @@
"react-hooks/exhaustive-deps": 1
},
"src/pages/system/SystemStatusPage.tsx": {
"@typescript-eslint/no-explicit-any": 1,
"@typescript-eslint/no-non-null-assertion": 1,
"@typescript-eslint/no-unused-vars": 4,
"react-hooks/exhaustive-deps": 1
},
"src/pages/tools/AdvancedPriceSearchPage.tsx": {
Expand Down Expand Up @@ -1290,9 +1257,6 @@
"@typescript-eslint/no-explicit-any": 5,
"no-console": 1
},
"src/tests/AdminLayout.test.tsx": {
"@typescript-eslint/no-explicit-any": 1
},
"src/tests/AdminMobileInteraction.test.tsx": {
"@typescript-eslint/no-unused-vars": 1
},
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/branch-protection-sentinel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
name: Verify push to main matches accepted patterns
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

actions/checkout v5 breaking changes compared to v4

💡 Result:

Compared to actions/checkout@v4, the main breaking change in actions/checkout@v5 is the required Node.js runtime and therefore your minimum GitHub Actions Runner version. 1) Node.js runtime update (breaking for self-hosted/older runners) - v5 updates the action to use the Node.js 24 runtime [1][2]. - The v5.0.0 release notes state this requires a minimum Actions Runner version of v2.327.1 to run [2][3]. 2) v5 docs/README guidance reflects the above - The action’s README/usage explicitly labels “Checkout v5” as supporting Node.js 24 and links it to the runner requirement [4]. What is not evidenced as “v4 → v5 breaking” beyond the runtime change - In the sources surfaced here, I do not see other documented behavioral-breaking changes specifically attributed to the v5 major bump (for example, no confirmed v4→v5 change to inputs like persist-credentials, fetch behavior, etc.). If you’re upgrading from v4 to v5, the practical checklist is: - Ensure your GitHub-hosted runner is already new enough, or for self-hosted runners upgrade to at least Actions Runner v2.327.1 [2][3]. - Bump the workflow reference from actions/checkout@v4 to actions/checkout@v5 [1][4].

Citations:

Garanta compatibilidade do runner com actions/checkout@v5 (.github/workflows/branch-protection-sentinel.yml:40)

O breaking change relevante do actions/checkout@v5 vs v4 é o runtime Node.js (Node 24), que exige GitHub Actions Runner ≥ v2.327.1; sem isso o step pode falhar e o sentinel deixar de auditar/rodar. Não há evidência nas fontes encontradas de mudança breaking especificamente em fetch-depth ou persist-credentials.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/branch-protection-sentinel.yml at line 40, The workflow
currently uses actions/checkout@v5 which requires GitHub Actions Runner ≥
v2.327.1 due to Node 24; update the workflow to ensure compatibility by either
reverting to actions/checkout@v4 or adding a pre-check that enforces the runner
version (>= 2.327.1) before running the branch-protection-sentinel job, or
conditionally use v4 when the runner is older. Locate the checkout usage
(actions/checkout@v5) and implement one of: replace with actions/checkout@v4,
add a step that reads the runner version and fails/alerts if < 2.327.1, or add
job-level logic to select the appropriate checkout action based on the runner
version. Ensure the chosen approach clearly documents the requirement and
prevents the sentinel from silently failing on older runners.

with:
# fetch-depth: 0 → histórico completo, para auditar todos os commits do push
fetch-depth: 0
Expand Down
70 changes: 35 additions & 35 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ jobs:
continue-on-error: true

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

actions/checkout v5 breaking changes compared to v4

💡 Result:

Key breaking change when moving from actions/checkout v4 to v5: runner/Node.js runtime requirement. 1) Minimum compatible runner version + Node runtime bump - actions/checkout v5.0.0 requires a minimum GitHub Actions Runner version of v2.327.1 to use that release [1]. - The main action README notes that “Checkout v5 now supports Node.js 24” and “This requires a minimum Actions Runner version of v2.327.1 to run.” [2]. - The v5.0.0 release changelog confirms the underlying change: “Update actions checkout to use node 24” [1]. What this means in practice - If your workflows run on self-hosted runners older than 2.327.1, they may fail to execute actions/checkout@v5 (so you should upgrade the runner before switching) [2][1]. 2) What appears NOT to be breaking (based on the sources found) - The sources located for v5 vs v4 primarily document the Node/runner requirement. I did not find additional explicit, v4-to-v5 “breaking change” items (e.g., input renames/removals or behavior changes) in the retrieved authoritative excerpts beyond this requirement [2][1]. Reference points in case you also need the context - The v5.0.0 release notes and full changelog link from the comparison page v4→v5 [3]. - The releases page includes later v5.x changes (not necessarily “breaking”), which you can review as you upgrade within the v5 major line [4].

Citations:

Verifique o requisito mínimo do runner ao usar actions/checkout@v5 em todos os jobs
A troca de actions/checkout@v4 → actions/checkout@v5 é incompatível com GitHub Actions runners antigos: o v5 exige Runner mínimo v2.327.1 (Node.js 24). Se qualquer um dos 13 jobs estiver em self-hosted runner abaixo desse nível, o CI pode falhar. Upgrade/ajuste dos runners antes de manter checkout@v5 nesses jobs.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 33, Verifique todos os jobs que usam
actions/checkout@v5: o actions/checkout@v5 exige runner mínimo v2.327.1 (Node.js
24), então identifique quaisquer jobs self-hosted entre os 13 que rodem em
runners abaixo dessa versão e ou faça upgrade desses runners para ≥ v2.327.1 ou
altere somente os jobs afetados para actions/checkout@v4 até o upgrade; procure
referências a actions/checkout@v5 no workflow e aplique a correção por job
conforme necessário.


- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'

Expand All @@ -55,9 +55,9 @@ jobs:
timeout-minutes: 90

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand Down Expand Up @@ -189,8 +189,8 @@ jobs:
needs: quality
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand All @@ -207,9 +207,9 @@ jobs:
timeout-minutes: 75

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand Down Expand Up @@ -239,7 +239,7 @@ jobs:

- name: Upload coverage report
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

actions/upload-artifact v5 breaking changes compared to v4

💡 Result:

Compared to actions/upload-artifact@v4, the only documented breaking change in actions/upload-artifact@v5.0.0 (upstream release notes) is that it supports Node v24.x and the release is treated as a breaking change accordingly [1]. What this likely means for you: - If you run self-hosted runners with older Node runtimes, you may need to ensure the runner environment (or GitHub Actions/runner setup) can execute actions/upload-artifact@v5; v5.0.0 explicitly calls out Node v24 support as the breaking change [1]. - For GitHub Enterprise Server (GHES), the repo notes that upload-artifact@v4+ is not supported “yet” and you must use v3 (with Node 16 or node20 guidance). The v4…v5 comparison page carries that updated GHES guidance text [2]. Notable context (from v4 era, included here because many “v5 vs v4” upgrade issues are actually v4 changes): - v4 included behavioral changes around artifact immutability/overwrite semantics and hidden files being ignored by default (with include-hidden-files to opt in). These are described in the official MIGRATION.md for v3→v4 [3]. If you share which exact v4 tag you’re on (e.g., v4.4.0 vs v4.6.x) and whether runners are GitHub-hosted or self-hosted/GHES, I can map the likely practical deltas more precisely.

Citations:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find all occurrences of upload-artifact@v5 in the workflow
rg -n "actions/upload-artifact@v5" .github/workflows/ci.yml || true

# Also show the surrounding lines for each match
rg -n -C 2 "actions/upload-artifact@v5" .github/workflows/ci.yml || true

Repository: adm01-debug/promo-gifts-v4

Length of output: 2145

🌐 Web query:

actions/upload-artifact v5 retention-days behavior changes from v4

💡 Result:

Behavior of actions/upload-artifact retention-days did not materially change from v4 to v5: in both cases the input “retention-days” is interpreted as “duration after which artifact will expire in days”, where 0 means “use the default retention”, with constraints that it must be at least 1 day and at most 90 days (unless overridden by repo/org/enterprise retention settings). This is described in the v4 action README and is also reflected in the current action input definition. [1][2] What likely changed between v4 and v5 is the underlying artifact backend/runtime (v5 is built on newer internals), but the documented retention-days contract remains the same; the v5 release is documented as a major backend/architecture package update rather than a change to retention semantics. [3][4] Practical implications for migration: - If you set retention-days: 0 in v4, it continues to mean “use default retention” in v5. [1][2] - If you set retention-days to a value between 1 and 90 inclusive in v4, you can keep using the same value in v5; it must not exceed the repository/organization/enterprise retention limit. [1][5] - If your value exceeds the retention limit configured at the repo/org/enterprise level, uploads will not be able to retain longer than that limit; this rule is consistent in the official docs. [5] Sources: v4 README for retention-days semantics and limits, main action.yml for the same semantics, GitHub Docs for the “cannot exceed configured retention limit” rule, and the v5.0.0 release/change context from the upstream compare/release pages. [1][2][5][4][3]

Citations:

🌐 Web query:

actions/upload-artifact v5 path patterns breaking changes v4

💡 Result:

In short: the main path-pattern “breaking change” people hit moving from upload-artifact@v4.0.x (or early v4) to later v4 releases is that hidden files/directories (paths containing components starting with “.”) are excluded by default; you must opt in with include-hidden-files: true. [1][2][3] What changed (v4 path patterns / globbing behavior) 1) Hidden files and hidden directories are excluded by default. - If your glob/path patterns match content under directories like.terragrunt-download/ then those files will not be included unless you set include-hidden-files to true. This was reported as “path patterns not working” after upgrading to actions/upload-artifact@v4.4.0, where only plan.txt showed up because it lived outside the hidden directory, while patterns under.terragrunt-download didn’t match any uploaded files. [1] - The GitHub changelog/blog posts around this period describe excluding hidden files by default for security reasons, and the fix is to set include-hidden-files: true. [2] 2) Wildcards/globs still work, but must be expressed as supported patterns. - The v4 README explains that path is “a file, directory or wildcard pattern,” and references @actions/glob for supported wildcard behavior. [4] - It also documents how the directory hierarchy is preserved after the first wildcard pattern, and how multiple paths use the least common ancestor as the root. These are not specific to v4→v5, but they explain how patterns are interpreted when they do match. [4] actions/upload-artifact v5: what about v4→v5 path pattern breaking changes? - The sources surfaced for “v5” here (the compare page and a v5 preparatory PR) don’t show an additional, separate “path patterns breaking change” beyond the hidden-files behavior; what’s explicitly evidenced in the available sources is the hidden-file exclusion introduced/affecting v4. [5][6] - Additionally, the v4 documentation/README is where the path and glob semantics are spelled out, including hidden-file handling. [7][4][3] How to fix your workflow (recommended) - If your patterns include anything under a hidden directory (e.g., anything under.something/), add include-hidden-files: true. Example: - uses: actions/upload-artifact@v4 with: name: terragrunt-plan path: |.terragrunt-download///*.tfplan include-hidden-files: true This matches the documented intent: explicitly include hidden files when needed. [2][3] - If you can rename directories to avoid leading dots, you can also avoid needing include-hidden-files; this is suggested by practitioners responding to the v4.4.0 breakage report. [1] Notes specific to pattern reliability - Quote paths that begin with a wildcard character to avoid YAML alias parsing issues (documented in the v4 README). [4] - Ensure you’re not relying on v3 mixing/mismatched download actions; v4 artifacts require v4 download actions. This is a common “upgrade break” but not a globbing/path-pattern issue. [8] Caveat - Your exact query asks specifically about “actions/upload-artifact v5 path patterns breaking changes v4.” With the evidence available in the retrieved sources, the only clearly documented, path-pattern-related breaking behavior is the hidden-files exclusion that impacts v4 users; I did not find a separate, explicit v4→v5 path-glob breaking change statement in the surfaced authoritative material. [5][2][4][3]

Citations:

🌐 Web query:

actions/upload-artifact v5 breaking changes only Node 24

💡 Result:

actions/upload-artifact v5 Node 24 “breaking changes” (i.e., changes introduced with v5 that affect runners/actions behavior for Node 24) can be summarized as follows: 1) Node 24 runtime support (v5.0.0) - In actions/upload-artifact v5.0.0, GitHub added support for Node v24.x and the release notes explicitly label this as a “BREAKING CHANGE” (treated as breaking for the purpose of upgrade guidance). [1] 2) Action behavior change: v5 is intended to run on Node 24 by default (not Node 20) - The project’s PR that updates the action to use Node.js 24 states that v5 had preliminary support for Node 24 but was by default still running on Node 20; it now runs on Node 24 by default. [2] Practical implication for workflows - If your workflow or custom runner environment was only compatible with the action running on Node 20, you should test again under the Node 24 runtime used by upload-artifact v5. (This follows directly from the v5 “BREAKING CHANGE”/runtime update language above.) [1][2] Notes - Other “breaking changes” reported by the community for upload-artifact@v4/v4.x (for example, hidden files handling) are separate from the Node 24 runtime switch described above; the sources above specifically cover the Node 24-related v5 change. [3]

Citations:

Checar compatibilidade e inputs do actions/upload-artifact@v5 (v4→v5)

  • A breaking change documentada do upload-artifact@v5.0.0 vs v4 é a atualização de runtime para Node v24 (principalmente relevante em self-hosted/GHES).
  • retention-days não muda de forma material: 0 segue como “default retention” e valores 1–90 continuam sujeitos ao limite configurado na org/repo.
  • Para paths/globs: não há breaking change explícito de v4→v5 nos materiais consultados; se você depende de diretórios “hidden” (começando com .), isso é um comportamento historicamente associado ao v4 (verifique include-hidden-files: true).

Also applies to: 292-292, 316-316, 345-345, 403-403, 458-458, 512-512, 540-540, 595-595

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 242, The workflow upgrades uses:
actions/upload-artifact@v5 which has a breaking runtime change (Node v24) and
potentially different defaults for hidden files; check each occurrence of uses:
actions/upload-artifact@v5 (and the instances listed) and validate inputs:
ensure retention-days values remain acceptable, add include-hidden-files: true
if you rely on dotfiles, and confirm self-hosted/GHES runners support Node v24;
if compatibility cannot be guaranteed, pin to actions/upload-artifact@v4 or add
explicit configuration to match prior behavior.

with:
name: coverage-report-${{ github.run_id }}
path: coverage/
Expand All @@ -261,8 +261,8 @@ jobs:
runs-on: ubuntu-latest
needs: quality
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand All @@ -289,7 +289,7 @@ jobs:
--coverage.thresholds.branches=0
--coverage.thresholds.statements=0
- name: Upload Coverage Artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: full-coverage-report
path: coverage/
Expand All @@ -300,8 +300,8 @@ jobs:
runs-on: ubuntu-latest
needs: quality
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand All @@ -313,7 +313,7 @@ jobs:
run: npm run test:e2e:critical
- name: Upload E2E Report
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: playwright-report
path: playwright-report/
Expand All @@ -329,8 +329,8 @@ jobs:
runs-on: ubuntu-latest
needs: build-gate
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand All @@ -342,7 +342,7 @@ jobs:
run: npx playwright test e2e/flows/elite-ux-validation.spec.ts
- name: Upload Elite E2E Report
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: playwright-elite-report
path: playwright-report/
Expand All @@ -355,9 +355,9 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand Down Expand Up @@ -400,7 +400,7 @@ jobs:

- name: Upload ref-warning console snapshot
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: console-snapshot-ref-${{ github.run_id }}
path: |
Expand All @@ -415,9 +415,9 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand Down Expand Up @@ -455,7 +455,7 @@ jobs:

- name: Upload hook coverage artifact
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: hooks-coverage
path: coverage/
Expand All @@ -468,9 +468,9 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand Down Expand Up @@ -509,7 +509,7 @@ jobs:

- name: Upload price-freshness coverage artifact
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: price-freshness-coverage
path: coverage/
Expand All @@ -522,9 +522,9 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand All @@ -537,7 +537,7 @@ jobs:

- name: Upload cloud-status coverage artifact
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: cloud-status-coverage
path: coverage/
Expand All @@ -550,9 +550,9 @@ jobs:
timeout-minutes: 15

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'

Expand All @@ -574,9 +574,9 @@ jobs:
timeout-minutes: 20

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: npm
Expand All @@ -592,7 +592,7 @@ jobs:

- name: Upload Theme Validation Report
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: theme-validation-report
path: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Initialize CodeQL
uses: github/codeql-action/init@v4
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/contract-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v6
with:
node-version: '20'
cache: 'npm'
Expand All @@ -63,9 +63,9 @@ jobs:
if: github.event.pull_request.head.repo.full_name == github.repository
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version: '20'
cache: 'npm'
Expand Down
Loading
Loading