fix(tests): align redirect destination /auth in route guards tests by adm01-debug · Pull Request #117 · adm01-debug/promo-gifts-v4

adm01-debug · 2026-05-22T23:07:30Z

🐛 Bug #3 do plano "10/10"

Job CI Test Coverage (vitest run --coverage) falha em main desde 2026-05-22. No último run (1fa53507), step "Run tests with coverage" rodou 7 min antes de quebrar — não é threshold (thresholds zerados na cmdline), é 1 teste falhando em 1845 total.

🔍 Causa-raiz

src/components/layout/ProtectedRoute.tsx:37 redireciona usuário anônimo para /auth:

if (!user) {
  savePostLoginRedirect(...);
  return <Navigate to="/auth" state={{ from: location }} replace />;
}

Mas dois testes configuravam apenas a rota /login no MemoryRouter:

<Routes>
  <Route path="/login" element={<LoginStub />} />  // ← rota errada
  <Route element={<ProtectedRoute />}>
    ...
  </Route>
</Routes>

Resultado: o Navigate to="/auth" não tem element matching → renderiza vazio → screen.getByTestId("page-login") falha:

TestingLibraryElementError: Unable to find an element by: [data-testid="page-login"]
<body><div /></body>

at tests/admin/route-no-error-element.test.tsx:324:12

Tests afetados (2 arquivos, 2 testes):

tests/admin/reduced-app-navigation.test.tsx:236 — "usuário sem sessão em rota protegida → redirect /login sem warning"
tests/admin/route-no-error-element.test.tsx:324 — "anônimo em rota protegida → /login — árvore limpa"

✅ Fix (2 arquivos, +2/-2 linhas — diff cirúrgico)

Mudar path="/login" → path="/auth" nos dois testes para alinhar com a realidade da produção:

-          <Route path="/login" element={<LoginStub />} />
+          <Route path="/auth" element={<LoginStub />} />

O LoginStub continua renderizando <div data-testid="page-login"> — apenas o path do matching mudou. Toda a expectativa getByTestId("page-login") permanece igual.

🤔 Por que essa estratégia (e não outras)?

Considerei 3 abordagens:

	Mudança	Arquivos	Risco
✅ A (escolhida)	`path="/login"` → `path="/auth"` nos 2 tests	2 testes (1 linha cada)	Mínimo — alinha test com prod
B	Adicionar BOTH `/login` e `/auth` rotas no test	2 testes (+1 linha cada)	Baixo, mas verboso
C	Mudar `ProtectedRoute` (+ `AdminRoute`, `DevRoute`) de `/auth` → `/login`	3 arquivos PROD	Alto — pode quebrar OAuth callback flow

Em produção (src/routes/public-routes.tsx), AMBAS as rotas existem:

<Route path="/auth" element={<Auth />} />
<Route path="/login" element={<Auth />} />  {/* alias defensivo */}

Mas TODOS os 3 redirects de guards (ProtectedRoute, AdminRoute, DevRoute) apontam para /auth, que é a rota canônica. /login é apenas alias defensive coding.

🧪 Validação em lab (clone fresco do main + Node v22 + npm ci)

Validação	Antes	Depois
`tests/admin/route-no-error-element.test.tsx` isolado	❌ FAIL (1/7)	✅ 7/7
`tests/admin/reduced-app-navigation.test.tsx` isolado	❌ FAIL (1/6)	✅ 6/6
Subset (`tests/admin/` + `tests/contracts/` + cloud-status + price-freshness): 21 files	n/a	✅ 314/314
Em produção	—	ZERO mudanças (só testes)

🛣️ Roadmap "10/10"

✅ Bug fix(ci): adicionar gpt-engineer-app[bot] à whitelist do Branch Protection Sentinel #1 Migrations sync guard — PR fix(ci): allowlist docs/redeploy/ + migration align_wave_3_5_2 no guard check-no-db-push #111 (5f3ec9d)
✅ Bug fix(imports): corrigir 32 imports quebrados pelo refactor T1 (19/mai) #2 Edge Deno typecheck — PR fix(contracts): infer V from keyof S & string in parseContract to fix TS2345 in 15 edge functions #115 (0c650ca)
🟢 Bug chore: remover 6 scripts refactor_imports*.cjs lixo (origem dos 32 imports quebrados) #3 Test Coverage — este PR
🟡 Bug feat(ci): Sentinel aceita familia Lovable via regex (resiliente a renomeacoes) #4 ESLint baseline gate — refinado: falha NÃO é em "Run tests" como pensávamos. O job Lint, Typecheck & Test falha no step "ESLint baseline gate" ANTES do "Run tests" (que fica skipped). Próximo PR.

📜 Decision trail

Pre-flight aplicado (lição do PR fix(contracts): infer V from keyof S & string in parseContract to fix TS2345 in 15 edge functions #115 → fix(contracts): infer V from versions keys to unblock Edge Deno typecheck #116): listei 6 PRs abertos antes de criar branch; nenhum ataca Bug chore: remover 6 scripts refactor_imports*.cjs lixo (origem dos 32 imports quebrados) #3
Bem isolado: só toca testes, zero impacto em runtime
Lição UTF-8 do PR fix(ci): allowlist docs/redeploy/ + migration align_wave_3_5_2 no guard check-no-db-push #111 mantida: arquivos commitados como texto plano (validado em clone fresco do branch)

🤖 Pink e Cerébro proceeding.

Summary by cubic

Align route-guard tests to use /auth instead of /login, matching the ProtectedRoute redirect and fixing the failing coverage job. No production code changed.

Bug Fixes
- Updated test routes to match the /auth redirect so Navigate has a matching element: tests/admin/reduced-app-navigation.test.tsx, tests/admin/route-no-error-element.test.tsx.

^{Written for commit 830a6b3. Summary will update on new commits. Review in cubic}

Summary by CodeRabbit

Release Notes

Tests
- Atualizados testes de roteamento para refletir a rota de autenticação em /auth (anteriormente /login). Ajustes implementados nos testes de navegação para garantir cobertura adequada da estrutura de rotas protegidas.

…ctedRoute redirect Bug #3 do plano 10/10. O job CI "Test Coverage" (vitest run --coverage) falhava em main com 1 test failing em 1845 total. Causa-raiz: ProtectedRoute.tsx:37 redireciona para /auth (canonico em prod): if (!user) return <Navigate to="/auth" .../>; Mas os testes admin/reduced-app-navigation.test.tsx e admin/route-no-error-element.test.tsx configuravam: <Route path="/login" element={<LoginStub />} /> Logo o redirect cai num path sem element matching → renderiza vazio → screen.getByTestId("page-login") falha com: Unable to find an element by: [data-testid="page-login"] <body><div /></body> Em produção src/routes/public-routes.tsx mantem AMBAS as rotas: <Route path="/auth" element={<Auth />} /> <Route path="/login" element={<Auth />} /> (alias) Mas TODOS os 3 redirects de guards (ProtectedRoute, AdminRoute, DevRoute) apontam para /auth, que é a rota canonica. /login eh apenas um alias defensivo. Fix cirurgico: mudar path="/login" -> path="/auth" nos 2 testes para alinhar com o destino real do Navigate. Por que nao mudar o redirect para /login no codigo de producao? - Risco alto: OAuth callbacks usam /auth como retorno canonico - 3 arquivos de prod afetados vs 2 de teste Por que nao adicionar AMBAS as rotas no teste? - Mais verbose; o teste deve refletir a realidade da prod - /login alias soh existe pra defensive coding em prod, nao deveria interessar pra um teste de redirect Validacao em lab (clone fresco do main + npm ci + node v22): Antes: tests/admin/route-no-error-element.test.tsx > "anônimo em rota protegida → /login — árvore limpa" -> FAIL (5s timeout em getByTestId) Depois: tests/admin/reduced-app-navigation.test.tsx (6 tests) ✅ tests/admin/route-no-error-element.test.tsx (7 tests) ✅ Subset broader: 314/314 tests passing em 21 files (admin/ + contracts/ + cloud-status + price-freshness) Em produção: zero mudancas. Apenas testes alinhados com Navigate. Roadmap "10/10": ✅ Bug #1 Migrations sync guard (PR #111, 5f3ec9d) ✅ Bug #2 Edge Deno typecheck (PR #115, 0c650ca) 🟢 Bug #3 Test Coverage (este PR) 🟡 Bug #4 ESLint baseline gate (proximo - refinado: nao eh "Run tests" como pensavamos, eh ESLint regression)

Parte 2/2 do Bug #3 do plano 10/10 (mesmo PR). Mesma causa-raiz que reduced-app-navigation.test.tsx: o teste configurava <Route path="/login" element={<LoginStub />} /> mas o ProtectedRoute.tsx:37 redireciona para /auth. Test afetado: "anônimo em rota protegida → /login — árvore limpa" (linha 317) Antes: getByTestId("page-login") timeout 5s (body vazio porque /auth não tinha route matching no MemoryRouter do test) Depois: ✅ 7/7 tests passing Diff: 1 linha (path="/login" → path="/auth").

vercel · 2026-05-22T23:07:36Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
we-dream-big	Ready	Preview, Comment	May 22, 2026 11:07pm

coderabbitai · 2026-05-22T23:07:43Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2e47819f-c0d3-4e1a-9d0c-eee104506886

📥 Commits

Reviewing files that changed from the base of the PR and between 1cb3b47 and 830a6b3.

📒 Files selected for processing (2)

tests/admin/reduced-app-navigation.test.tsx
tests/admin/route-no-error-element.test.tsx

Walkthrough

Dois arquivos de teste de roteamento foram atualizados para servir o stub de login no caminho /auth em vez de /login. As estruturas de rotas reduzidas usadas nas suites de integração agora refletem esse consolidação de caminho de autenticação.

Changes

Consolidação de caminho de rota de login em fixtures de teste

Layer / File(s)	Resumo
Consolidação de path de login em fixtures `tests/admin/reduced-app-navigation.test.tsx`, `tests/admin/route-no-error-element.test.tsx`	Rotas de stub de login foram alteradas de `path="/login"` para `path="/auth"` em ambas as suites de integração de roteamento reduzido.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutos

Suggested labels

javascript

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	O título descreve com precisão a mudança principal: alinhamento do destino de redirecionamento para /auth nos testes de route guards.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/test-coverage-route-auth-redirect

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR fixes a CI vitest run --coverage failure by aligning the route-guard test harnesses with the production redirect behavior: unauthenticated users are redirected to the canonical /auth route (not /login).

Changes:

Update the public route registered in two admin test harnesses from path="/login" to path="/auth".
Keep the same LoginStub assertions (data-testid="page-login") while ensuring the Navigate to="/auth" redirect actually matches a route in MemoryRouter.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/admin/route-no-error-element.test.tsx	Registers `/auth` in the ReducedApp router so ProtectedRoute redirects render the login stub instead of an unmatched route.
tests/admin/reduced-app-navigation.test.tsx	Registers `/auth` in the ReducedApp router to match the production guard redirect destination and prevent empty renders in navigation tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cubic-dev-ai

No issues found across 2 files

_{Re-trigger cubic}

supabase · 2026-05-22T23:12:28Z

This pull request has been ignored for the connected project doufsxqlfjyuvxuezpln because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

…soleto) Após merge do PR #124, PR #125 original ficou dirty com múltiplos conflitos. Cherry-pick apenas dos 4 arquivos cujo valor sobrevive ao merge do #124, descartando o restante (que ou era redundante ou era REVERSÃO de #117/#118/#124). Arquivos aplicados: 1. AppLogo.visual.test.tsx — sidebar variant: h-9 w-9 → h-10 w-10 2. QuoteBuilderDiscountAdvanced.test.tsx — CurrencyInput usa testid (não placeholder) 3. AuthBranding.test.tsx — ContinuousRockets foi inlinado em SpaceScene 4. AuthBranding.visual.test.tsx — Layout atualizado (rounded-3xl px-5 h-[88px]) Arquivos DESCARTADOS do PR #125 original: - tests/admin/reduced-app-navigation + route-no-error-element: reverteriam #117 - tests/components/quotes/AIRecommendationsPanel: reverteria #118 - docs/AUDITORIA + POP secrets + AdminStandardRules + ScenarioSimulation: Tudo já mergeado via #124 - useCatalogState.unit: #124 já skipou explicitamente com TODO de refactor Sanity checks confirmados: - SpaceScene existe em src/pages/auth/AuthBranding.tsx - testid 'quote-discount-input' existe em QuoteBuilderSummaryColumn.tsx:342 - 'h-10 w-10' está em src/components/layout/AppLogo.tsx:29 (sidebar variant)

…soleto) (#130) Após merge do PR #124, PR #125 original ficou dirty com múltiplos conflitos. Cherry-pick apenas dos 4 arquivos cujo valor sobrevive ao merge do #124, descartando o restante (que ou era redundante ou era REVERSÃO de #117/#118/#124). Arquivos aplicados: 1. AppLogo.visual.test.tsx — sidebar variant: h-9 w-9 → h-10 w-10 2. QuoteBuilderDiscountAdvanced.test.tsx — CurrencyInput usa testid (não placeholder) 3. AuthBranding.test.tsx — ContinuousRockets foi inlinado em SpaceScene 4. AuthBranding.visual.test.tsx — Layout atualizado (rounded-3xl px-5 h-[88px]) Arquivos DESCARTADOS do PR #125 original: - tests/admin/reduced-app-navigation + route-no-error-element: reverteriam #117 - tests/components/quotes/AIRecommendationsPanel: reverteria #118 - docs/AUDITORIA + POP secrets + AdminStandardRules + ScenarioSimulation: Tudo já mergeado via #124 - useCatalogState.unit: #124 já skipou explicitamente com TODO de refactor Sanity checks confirmados: - SpaceScene existe em src/pages/auth/AuthBranding.tsx - testid 'quote-discount-input' existe em QuoteBuilderSummaryColumn.tsx:342 - 'h-10 w-10' está em src/components/layout/AppLogo.tsx:29 (sidebar variant)

…#127 Documenta análise + decisão para cada um dos 3 PRs em conflito após #124: - #125: fechado, branch chore/pr125-cherry-pick com 4 testes únicos - #126: fechado, branch chore/pr126-cherry-pick com 2 CORS + 1 auditoria - #127: DRAFT mantido (precisa sessão dedicada com npm install + typecheck) Inclui: - Análise arquivo-por-arquivo de cada PR - Identificação de redundâncias vs main e reversões de #117/#118 - Plano de retomada do #127 (3-5h estimadas) - Lições aprendidas para sessões futuras - Limitação descoberta: MCP do GitHub não expõe github_create_pull_request

…soleto) Após merge do PR #124, PR #125 original ficou dirty com múltiplos conflitos. Cherry-pick apenas dos 4 arquivos cujo valor sobrevive ao merge do #124, descartando o restante (que ou era redundante ou era REVERSÃO de #117/#118/#124). Arquivos aplicados: 1. AppLogo.visual.test.tsx — sidebar variant: h-9 w-9 → h-10 w-10 2. QuoteBuilderDiscountAdvanced.test.tsx — CurrencyInput usa testid (não placeholder) 3. AuthBranding.test.tsx — ContinuousRockets foi inlinado em SpaceScene 4. AuthBranding.visual.test.tsx — Layout atualizado (rounded-3xl px-5 h-[88px]) Arquivos DESCARTADOS do PR #125 original: - tests/admin/reduced-app-navigation + route-no-error-element: reverteriam #117 - tests/components/quotes/AIRecommendationsPanel: reverteria #118 - docs/AUDITORIA + POP secrets + AdminStandardRules + ScenarioSimulation: Tudo já mergeado via #124 - useCatalogState.unit: #124 já skipou explicitamente com TODO de refactor Sanity checks confirmados: - SpaceScene existe em src/pages/auth/AuthBranding.tsx - testid 'quote-discount-input' existe em QuoteBuilderSummaryColumn.tsx:342 - 'h-10 w-10' está em src/components/layout/AppLogo.tsx:29 (sidebar variant)

…soleto) (#134) Após merge do PR #124, PR #125 original ficou dirty com múltiplos conflitos. Cherry-pick apenas dos 4 arquivos cujo valor sobrevive ao merge do #124, descartando o restante (que ou era redundante ou era REVERSÃO de #117/#118/#124). Arquivos aplicados: 1. AppLogo.visual.test.tsx — sidebar variant: h-9 w-9 → h-10 w-10 2. QuoteBuilderDiscountAdvanced.test.tsx — CurrencyInput usa testid (não placeholder) 3. AuthBranding.test.tsx — ContinuousRockets foi inlinado em SpaceScene 4. AuthBranding.visual.test.tsx — Layout atualizado (rounded-3xl px-5 h-[88px]) Arquivos DESCARTADOS do PR #125 original: - tests/admin/reduced-app-navigation + route-no-error-element: reverteriam #117 - tests/components/quotes/AIRecommendationsPanel: reverteria #118 - docs/AUDITORIA + POP secrets + AdminStandardRules + ScenarioSimulation: Tudo já mergeado via #124 - useCatalogState.unit: #124 já skipou explicitamente com TODO de refactor Sanity checks confirmados: - SpaceScene existe em src/pages/auth/AuthBranding.tsx - testid 'quote-discount-input' existe em QuoteBuilderSummaryColumn.tsx:342 - 'h-10 w-10' está em src/components/layout/AppLogo.tsx:29 (sidebar variant)

adm01-debug added 2 commits May 22, 2026 20:05

Copilot AI review requested due to automatic review settings May 22, 2026 23:07

Copilot started reviewing on behalf of adm01-debug May 22, 2026 23:07 View session

vercel Bot deployed to Preview May 22, 2026 23:07 View deployment

Copilot AI reviewed May 22, 2026

View reviewed changes

cubic-dev-ai Bot reviewed May 22, 2026

View reviewed changes

adm01-debug merged commit 8e24d8a into main May 23, 2026
29 of 32 checks passed

adm01-debug deleted the fix/test-coverage-route-auth-redirect branch May 23, 2026 10:56

This was referenced May 23, 2026

test: corrige 6 testes drifted pos-reimport (CurrencyInput, vi.hoisted/OOM, AuthBranding, schema) #125

Closed

test: fix 4 testes drifted pós-Lovable reimport (substitui PR #125 ob… #130

Merged

This was referenced May 23, 2026

audit + fixes: forensic 2026-05-23 — 9 commits, 5 P0/P1 fixes, ESLint -34 #126

Closed

fix(ts+eslint): zera 9 alvos de TS/ESLint e adiciona guard-rail T-FIX-5b #127

Merged

adm01-debug mentioned this pull request May 23, 2026

test: 4 SUT regressions únicas do PR #125 pós-#124 #134

Merged

2 tasks

adm01-debug mentioned this pull request May 23, 2026

fix(quality): exhaustive QA pass — all 6 gates green (TS, ESLint, tests, CORS, toast-leaks, T-FIX-5) #138

Closed

7 tasks

This was referenced May 29, 2026

fix(lovable): corrige 5 bugs introduzidos pelos commits de hoje #513

Merged

feat(tests): exhaustive webhook/edge-function/freight-quest test suite #515

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tests): align redirect destination /auth in route guards tests#117

fix(tests): align redirect destination /auth in route guards tests#117
adm01-debug merged 2 commits into
mainfrom
fix/test-coverage-route-auth-redirect

adm01-debug commented May 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented May 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 22, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

Copilot AI left a comment

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

supabase Bot commented May 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adm01-debug commented May 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🐛 Bug #3 do plano "10/10"

🔍 Causa-raiz

✅ Fix (2 arquivos, +2/-2 linhas — diff cirúrgico)

🤔 Por que essa estratégia (e não outras)?

🧪 Validação em lab (clone fresco do main + Node v22 + npm ci)

🛣️ Roadmap "10/10"

📜 Decision trail

Summary by cubic

Summary by CodeRabbit

Release Notes

Uh oh!

vercel Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

❌ Failed checks (1 warning)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

supabase Bot commented May 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adm01-debug commented May 22, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented May 22, 2026 •

edited

Loading

coderabbitai Bot commented May 22, 2026 •

edited

Loading