fix(ci): remove quote-public-view orphan + clean 5 ghost entries (close B-9)#226
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (fix/ci-remove-quote-public-view-orphan-and-snapshot-ghosts) ↗︎
Tasks are run on every commit but only new migration files are pushed.
❌ Branch Error • Fri, 15 May 2026 15:00:18 UTC View logs for this Workflow Run ↗︎. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughO PR remove a edge function descontinuada ChangesLimpeza de quote-public-view
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63fb3c0797
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ]); | ||
|
|
||
| const SNAPSHOT_SIZE = 84; | ||
| const SNAPSHOT_SIZE = 78; |
There was a problem hiding this comment.
After this removal the allowlist contains 76 entries, but the new ceiling is 78. Since the growth check only fails when LEGACY_ALLOWLIST.size - SNAPSHOT_SIZE > 0, the next two PRs could add functions back to LEGACY_ALLOWLIST and still pass this gate, contrary to the "NÃO ADICIONAR" invariant this script is meant to enforce. Set this to the current allowlist size so any growth is caught immediately.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Removes the orphaned quote-public-view edge function and updates CI guard artifacts so edge-function authorization, CORS, and structured-logging checks reflect the current function set.
Changes:
- Deleted the deprecated
quote-public-viewstub edge function. - Updated the CORS snapshot from 78 to 77 functions.
- Removed orphan entries from the structured logging legacy allowlist and lowered its snapshot ceiling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
supabase/functions/quote-public-view/index.ts |
Deletes the deprecated public quote view stub. |
supabase/functions/_shared/cors-snapshot.json |
Updates CORS snapshot metadata and removes quote-public-view. |
scripts/check-edge-structured-logging.mjs |
Cleans orphan legacy allowlist entries and updates snapshot size. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {"name": "ai-recommendations", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "analyze-logo-colors", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "bi-copilot", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "bitrix-sync", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "block-ip-temporarily", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "categories-api", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "cleanup-notifications", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "cleanup-novelties", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "cnpj-lookup", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "collections-watcher", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "commemorative-dates", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "comparison-ai-advisor", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "comparison-price-watcher", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "connection-tester", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "connections-auto-test", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, | ||
| {"name": "connections-health-check", "mode": "shared", "allowHeaders": [], "exposeHeaders": [], "allowMethods": null, "allowOrigin": null}, |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/check-edge-structured-logging.mjs">
<violation number="1" location="scripts/check-edge-structured-logging.mjs:54">
P2: Set `SNAPSHOT_SIZE` to the current allowlist size (76). Keeping it at 78 leaves room for two new legacy entries to be added without tripping the growth guard, which weakens the "NÃO ADICIONAR" enforcement.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Re-trigger cubic
| ]); | ||
|
|
||
| const SNAPSHOT_SIZE = 84; | ||
| const SNAPSHOT_SIZE = 78; |
There was a problem hiding this comment.
P2: Set SNAPSHOT_SIZE to the current allowlist size (76). Keeping it at 78 leaves room for two new legacy entries to be added without tripping the growth guard, which weakens the "NÃO ADICIONAR" enforcement.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At scripts/check-edge-structured-logging.mjs, line 54:
<comment>Set `SNAPSHOT_SIZE` to the current allowlist size (76). Keeping it at 78 leaves room for two new legacy entries to be added without tripping the growth guard, which weakens the "NÃO ADICIONAR" enforcement.</comment>
<file context>
@@ -26,32 +26,32 @@ const FN_ROOT = "supabase/functions";
]);
-const SNAPSHOT_SIZE = 84;
+const SNAPSHOT_SIZE = 78;
function listEdgeFunctions() {
</file context>
| const SNAPSHOT_SIZE = 78; | |
| const SNAPSHOT_SIZE = 76; |
adm01-debug
deleted the
fix/ci-remove-quote-public-view-orphan-and-snapshot-ghosts
branch
🎯 Problema
CI gate
🛡️ Edge authorization manifest gatefalhando em todos os runs domaindesde 15/mai:Build/teste do PR #222 (run #3117) e seguintes bloqueados.
🔍 Causa-raiz (loop de 3 PRs)
cec0a06f9(PR #188)quote-public-viewdo manifest + doconfig.toml(era ghost entry). Estado: limpo ✅f6fdc7f52✅ Correções
1. DELETE da função (B-9 da auditoria pré-prod)
rm -rf supabase/functions/quote-public-view/— stub de 16 linhas (HTTP 410)src/, zero referência emconfig.toml, zero deps em outras edges2. REGEN do
cors-snapshot.jsonnode scripts/build-cors-snapshot.mjs→ 78 → 77 functions3. CLEAN de 5 ghost entries no
check-edge-structured-logging.mjsJá estavam órfãs (warning ativo):
4. SNAPSHOT_SIZE 84 → 78
Trava o novo ceiling pra evitar regressões.
🧪 Validação local (todos os 5 gates verdes)
📊 Impacto
AUDITORIA-PROFUNDA-PROMOGIFTS-PRE-PROD.md(2026-05-10).🛠️ Como mergear
Squash merge conforme padrão do projeto.
🤖 Generated with Claude (claude-opus-4-7)
Summary by cubic
Fixes the failing edge authorization manifest gate by deleting the orphaned
quote-public-viewfunction and refreshing snapshots/allowlists. CI onmainis unblocked and green again; closes B-9.supabase/functions/quote-public-view/(deprecated 410 stub; no callers/config refs).supabase/functions/_shared/cors-snapshot.json(78 → 77 functions).LEGACY_ALLOWLISTinscripts/check-edge-structured-logging.mjs:bi-share-dossier,collections-public-react,comparisons-public-react,generate-mockup-nanobanana,kit-public-view(plus deletedquote-public-view).SNAPSHOT_SIZEfrom 84 → 78 to lock the new ceiling.Written for commit 63fb3c0. Summary will update on new commits. Review in cubic
Summary by CodeRabbit