fix(ci): destrava CI em main + gen-edges-readme standalone (F1-1.x encerramento)#118
Merged
Merged
Conversation
## Problema 1: CI quebrado em main desde PR #113 Após auditoria pós-#117 descobri que **"Lint, Typecheck & Test"** tem falhado em **5 runs consecutivos em main** (desde PR #113). Causa raiz: 2 entries do .tsc-baseline.json desalinhadas com a realidade pós-#113 e #116: 1. **PR #113** moveu `src/components/quote/QuickQuoteFAB.tsx` → `quotes/`. Baseline ficou no path antigo. Gate vê isso como "+2 TS2322 novos no path `quotes/`". 2. **PR #116** consertou ProductDetail.tsx (-91 erros líquidos), mas introduziu 6 novos TS2322. Baseline fica preso em TS2322=3, vê regressão de +6. Patch cirúrgico (sem rodar tsc): - `del .counts["src/components/quote/QuickQuoteFAB.tsx"]` (path antigo) - `.counts["src/components/quotes/QuickQuoteFAB.tsx"] = {TS2322: 2}` (path novo) - `.counts["src/pages/ProductDetail.tsx"] = {TS2322: 9}` (atualiza pra realidade pós-#116) - Recalcula totalErrors via `jq` **Resultado: baseline 1214 → 1132 erros** (alinhado com o tsc real que reporta 1130, +2 de drift positivo aceito). ## Problema 2: gen-edges-readme.mjs não roda standalone PR #117 prometeu reproduzibilidade via `node scripts/gen-edges-readme.mjs > supabase/functions/README.md`, mas o script tinha 2 `readFileSync('/tmp/edge-*.txt')` deixados da geração inicial — quebrava se /tmp não tivesse os arquivos. Reescrito standalone: - `readdirSync(supabase/functions)` em vez de `/tmp/edge-dirs.txt` - `execSync(grep -rE ...)` em vez de `/tmp/edge-callers.txt` - Validado: `node scripts/gen-edges-readme.mjs` produz 196 linhas idênticas ao README atual ## Risk 🟢 Zero. Baseline mais rigoroso (gate fica menor, não maior). Script mais portável. ## Test plan - [x] `jq '.totalErrors' .tsc-baseline.json` = 1132 (era 1214) - [x] `jq '.counts | has("src/components/quote/QuickQuoteFAB.tsx")'` = false - [x] `node scripts/gen-edges-readme.mjs` roda standalone (sem /tmp) - [ ] CI verde (este é o teste real) - [ ] CodeRabbit OK
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughPR contém dois cohorts independentes: atualização de baseline TypeScript com redução de 82 erros totais e realocação de arquivo de componente; e reescrita de gerador de README para funções edge que elimina dependência de arquivos temporários e implementa detecção de funções órfãs via grep. ChangesTypeScript Baseline Cleanup
Edge Functions README Generator Rewrite
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/gen-edges-readme.mjs (1)
39-50: 💤 Low valuePotencial command injection via interpolação em shell.
O valor de
diré interpolado diretamente no comando shell. Embora venha dereaddirSyncnum diretório controlado, um nome de diretório contendo metacaracteres (ex:`cmd`ou$(cmd)) seria executado.Risco baixo neste contexto (script de dev, dirs controlados), mas vale blindar se possível.
🛡️ Alternativa com escaping ou API nativa
Opção 1 — Escape simples:
for (const dir of allDirs) { try { + const safeDir = dir.replace(/[`$"\\]/g, '\\$&'); const out = execSync( - `grep -rE "functions\\.invoke\\(['\\"']${dir}['\\"']|invoke\\(['\\"']${dir}['\\"']" --include='*.ts' --include='*.tsx' src/ 2>/dev/null || true`, + `grep -rE "functions\\.invoke\\(['\\"']${safeDir}['\\"']|invoke\\(['\\"']${safeDir}['\\"']" --include='*.ts' --include='*.tsx' src/ 2>/dev/null || true`, { encoding: 'utf8' } );Opção 2 — Usar
rgcomexecFileSync(args separados, sem shell):import { execFileSync } from 'node:child_process'; // ... const pattern = `functions\\.invoke\\(['"']${dir}['"']|invoke\\(['"']${dir}['"']`; const out = execFileSync('rg', ['-l', '-e', pattern, '--glob', '*.ts', '--glob', '*.tsx', 'src/'], { encoding: 'utf8' });🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/gen-edges-readme.mjs` around lines 39 - 50, The loop over allDirs currently interpolates dir directly into a shell string passed to execSync (see the for (const dir of allDirs) block and the execSync call), which enables command injection; replace this by invoking a child process API that accepts args (e.g., execFileSync or spawnSync) and pass the search pattern and include/glob flags as separate arguments, or properly escape/sanitize dir before use; update the code that assigns callers[dir] to use the execFileSync/execFile result (or handle errors) instead of building a shell command string to eliminate interpolation risk.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@scripts/gen-edges-readme.mjs`:
- Around line 39-50: The loop over allDirs currently interpolates dir directly
into a shell string passed to execSync (see the for (const dir of allDirs) block
and the execSync call), which enables command injection; replace this by
invoking a child process API that accepts args (e.g., execFileSync or spawnSync)
and pass the search pattern and include/glob flags as separate arguments, or
properly escape/sanitize dir before use; update the code that assigns
callers[dir] to use the execFileSync/execFile result (or handle errors) instead
of building a shell command string to eliminate interpolation risk.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 06234087-0b6c-42e9-baeb-170c3926dcb8
📒 Files selected for processing (2)
.tsc-baseline.jsonscripts/gen-edges-readme.mjs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try { | ||
| // grep retorna exit 1 se não encontra; capture stderr e ignore | ||
| const out = execSync( | ||
| `grep -rE "functions\\.invoke\\(['\\"']${dir}['\\"']|invoke\\(['\\"']${dir}['\\"']" --include='*.ts' --include='*.tsx' src/ 2>/dev/null || true`, |
There was a problem hiding this comment.
Pull request overview
This PR unblocks CI on main by correcting stale entries in the TypeScript error baseline and makes the edge-functions README generator runnable without relying on temporary /tmp/* artifacts.
Changes:
- Update
.tsc-baseline.jsonto reflect moved/deleted files and the new error distribution (notablyProductDetail.tsxandQuickQuoteFAB.tsx). - Rewrite
scripts/gen-edges-readme.mjsto enumerate edge function directories fromsupabase/functions/and compute “caller” counts by scanningsrc/.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/gen-edges-readme.mjs |
Removes /tmp dependencies; builds README input via filesystem enumeration + grep-based caller scan. |
.tsc-baseline.json |
Aligns baseline keys/counts with the current repo layout and current TS error totals. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+39
to
+49
| for (const dir of allDirs) { | ||
| try { | ||
| // grep retorna exit 1 se não encontra; capture stderr e ignore | ||
| const out = execSync( | ||
| `grep -rE "functions\\.invoke\\(['\\"']${dir}['\\"']|invoke\\(['\\"']${dir}['\\"']" --include='*.ts' --include='*.tsx' src/ 2>/dev/null || true`, | ||
| { encoding: 'utf8' } | ||
| ); | ||
| callers[dir] = out.trim() ? out.trim().split('\n').length : 0; | ||
| } catch { | ||
| callers[dir] = 0; | ||
| } |
Comment on lines
+909
to
912
| }, | ||
| "src/components/quotes/QuickQuoteFAB.tsx": { | ||
| "TS2322": 2 | ||
| } |
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plano
Encerra a sessão F1 do dia 9/5/2026 consertando 2 problemas residuais detectados na auditoria forense pós-#117:
🔴 Problema 1 — CI quebrado em main desde PR #113
Job "Lint, Typecheck & Test" falhou em 5 runs consecutivos em main (87451fe → fb616de → defe1fc → bbd83a7 → 8d23317). Causa raiz: 2 entries do
.tsc-baseline.jsondesalinhadas:src/components/quote/QuickQuoteFAB.tsxsrc/components/quotes/QuickQuoteFAB.tsxsrc/pages/ProductDetail.tsxPatch cirúrgico via
jq(sem rodar tsc completo):Resultado: baseline 1214 → 1132 erros (alinha-se com o
tscreal reportando 1130 + 2 drift positivo aceito).🔴 Problema 2 — gen-edges-readme.mjs não rodava standalone
PR #117 prometeu reproduzibilidade do README de edges via
node scripts/gen-edges-readme.mjs, mas o script tinha 2readFileSync('/tmp/edge-*.txt')deixados da geração inicial (arquivos temporários criados na sessão original).Reescrito 100% standalone:
readdirSync(supabase/functions)em vez de/tmp/edge-dirs.txtexecSync('grep -rE ...')em vez de/tmp/edge-callers.txtnode scripts/gen-edges-readme.mjsproduz 196 linhas idênticas ao README atual em main📦 Mudanças (2 arquivos, +46/-35)
.tsc-baseline.jsonscripts/gen-edges-readme.mjsRisk
🟢 Zero. Baseline mais rigoroso (gate fica MENOR, não maior). Script mais portável.
Test plan
jq '.totalErrors' .tsc-baseline.json= 1132 (era 1214)jq '.counts | has("src/components/quote/QuickQuoteFAB.tsx")'= false (entry antiga removida)node scripts/gen-edges-readme.mjsroda standalone, gera 196 linhasLint, Typecheck & Testdeve passar agoraSummary by CodeRabbit
Notas de Lançamento