Updated post-single.css to set hr's border to 0 #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
romainx
pushed a commit
to romainx/hugo-PaperMod
that referenced
this pull request
Jul 26, 2022
* Updated post-single.css to set hr's border to 0 * cleanup Co-authored-by: Aditya Telange <[email protected]>
minyeamer
pushed a commit
to minyeamer/hugo-PaperMod
that referenced
this pull request
Sep 16, 2022
* Updated post-single.css to set hr's border to 0 * cleanup Co-authored-by: Aditya Telange <[email protected]>
dunklecat
pushed a commit
to dunklecat/hugo-PaperModX
that referenced
this pull request
Oct 8, 2022
* Updated post-single.css to set hr's border to 0 * cleanup Co-authored-by: Aditya Telange <[email protected]>
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
* Updated post-single.css to set hr's border to 0 * cleanup Co-authored-by: Aditya Telange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
The problem is that the hr element displays the wrong color at the extremities:
This problem appears both in light and dark mode (though it is more visible in light mode). This issue breaks the consistency of the UI by introducing a jarring element at the extremities.
This PR modifies the css style of hr by setting a border size of 0 to solve this problem. It gives the hr element a unique color.
Here are the results with this patch:
Was the change discussed in an issue or in the Discussions before?
This issue was not raised before.
PR Checklist