Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new 'Image render hook' template from Hugo. #1526

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

adityatelange
Copy link
Owner

What does this PR change? What problem does it solve?

Improves compatibility with custom render hook provided in Hugo 0.123.0 and above.

A custom render hook, even when provided by a theme or module, will override the embedded render hook regardless of the configuration setting above.

Was the change discussed in an issue or in the Discussions before?

Closes: #1504

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Copy link

sonarcloud bot commented May 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adityatelange adityatelange added the enhancement New feature or improvement label May 26, 2024
@adityatelange adityatelange linked an issue Aug 25, 2024 that may be closed by this pull request
@jmooring
Copy link
Contributor

Thanks for getting ahead of this. Much appreciated.

@newptcai
Copy link

I met this problem while adding multilingual support for my website. I'd appreciate it if this can be merged! 🙏

@adityatelange adityatelange merged commit f163fb1 into master Nov 3, 2024
1 check passed
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
@adityatelange adityatelange deleted the feat/new-img-render-markup branch November 9, 2024 15:35
hankmor pushed a commit to hankmor/hugo-PaperMod that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove or update image render hook template Image render hook vs the new embedded image render hook in 0.123
3 participants