Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netease Cloud Music Social Icon #1093

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Add Netease Cloud Music Social Icon #1093

merged 1 commit into from
Feb 4, 2023

Conversation

JingBh
Copy link
Contributor

@JingBh JingBh commented Nov 27, 2022

What does this PR change? What problem does it solve?

Adds a new social icon for Netease Cloud Music, a popular music streaming platform in China.

image image

The middle one is the icon.

Was the change discussed in an issue or in the Discussions before?

No.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud
Copy link

sonarcloud bot commented Nov 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JingBh NetEase Cloud Music has a user profile page? If yes can you share an example

@JingBh
Copy link
Contributor Author

JingBh commented Feb 4, 2023

@adityatelange Yes, see https://music.163.com/#/user/1 for an example (which is their official account).

Although I don't think many people would like to share their music profile, but there's no harm just adding the icon. :)

@adityatelange
Copy link
Owner

@adityatelange Yes, see https://music.163.com/#/user/1 for an example (which is their official account).

Although I don't think many people would like to share their music profile, but there's no harm just adding the icon. :)

Yes sure.

@adityatelange adityatelange merged commit f5320cd into adityatelange:master Feb 4, 2023
@adityatelange adityatelange added the icons Related to Icons label Feb 4, 2023
Nicceboy added a commit to Nicceboy/hugo-PaperMod that referenced this pull request Feb 11, 2023
* Fix multi-line anchor tags not highlighted/underlined.

fixes: adityatelange#1107

* Update Hebrew translation (adityatelange#1104)

Signed-off-by: Eran Israeli <[email protected]>

* Improve Turkish Translation tr.yaml (adityatelange#1098)

* update arabic pagination translation (adityatelange#1137)

* PT translation updated (adityatelange#1124)

Signed-off-by: igorr0driguez <[email protected]>

* Added Belarusian translations i18n/be.yaml (adityatelange#1144)

* updated Polish translation (adityatelange#1148)

* Add Tumblr Icon (adityatelange#1115)

* Add TryHackMe Icon (adityatelange#1113)

from Simple Icons https://github.com/simple-icons/simple-icons/blob/develop/icons/tryhackme.svg

* Add codeforces icon (adityatelange#1092)

From https://github.com/simple-icons/simple-icons

* Google scholar svg icon fixed, now unfilled curved line (adityatelange#1064)

* Add netease cloud music icon (adityatelange#1093)

* Add title to the image tag in rss.xml (adityatelange#1105)

Ref: https://cyber.harvard.edu/rss/rss.html#ltimagegtSubelementOfLtchannelgt

* Add douban and zhihu icon (adityatelange#1084)

* Update README

---------

Signed-off-by: Eran Israeli <[email protected]>
Signed-off-by: igorr0driguez <[email protected]>
Co-authored-by: Aditya Telange <[email protected]>
Co-authored-by: Eran Israeli <[email protected]>
Co-authored-by: Nikita <[email protected]>
Co-authored-by: Essa Alshammri <[email protected]>
Co-authored-by: Igor Rodriguez <[email protected]>
Co-authored-by: Andrey Mukamolov <[email protected]>
Co-authored-by: Karpfly <[email protected]>
Co-authored-by: Axel Wagner <[email protected]>
Co-authored-by: Josh Müller <[email protected]>
Co-authored-by: rais ilham <[email protected]>
Co-authored-by: Nathan Fradet <[email protected]>
Co-authored-by: Bohao Jing <[email protected]>
Co-authored-by: k-yone <[email protected]>
Co-authored-by: Jingchao <[email protected]>
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons Related to Icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants