Fix child process handling/cleanup #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has not been very robust across OSes (macOS and Linux) and use-cases (tests and interactive running). It was kind of complicated and confusing, so streamline a bit.
|
Probably related to #38 |
|
confirmed that the tests pass for me on mac on this branch |
paulsmith
added a commit
that referenced
this pull request
Feb 15, 2023
This change simplifies child process handling and cleanup, which should make tests and hot-reloading most robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that the full e2e tests (TestPushup) were hanging on my Mac, while the same Git checkout worked fine on a Linux vm.
I dumped the stack trace of all the goroutines and saw that one was blocked waiting for a child process (
Cmdtype inos/exec) to exit.So somehow the combo of signal handling and context cancellation wasn't correct, at least for macOS.
Pushup uses a lot of child processes, because e2e tests fire up a full Pushup app and the hot-reloading mode
-devdoes as well. So it's important to get right.This PR simplifies things and should make signal handling and context cancellation (and therefore managing of shutdowns and whatnot of child processes) more robust.