Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: magic link button is only rounded on one side when in magic link modal #152

Closed
1 task done
c0rydoras opened this issue May 14, 2024 · 4 comments · Fixed by #405
Closed
1 task done

[BUG]: magic link button is only rounded on one side when in magic link modal #152

c0rydoras opened this issue May 14, 2024 · 4 comments · Fixed by #405
Assignees
@c0rydoras
Labels
bug Something isn't working frontend This issue or pull request is frontend related

Comments

@c0rydoras
Copy link
Collaborator

Description

When in the magic link ui/when the magic link modal is opened the button is no longer rounded on all sides

Steps to Reproduce

  1. go to timed instance
  2. click magic link button
  3. its no longer rounded on all sides

Expected Behavior

It to stay round

Attachments

image
image

Additional Context

No response

Version

v4.0.3

Required

  • I have checked past issues to see if this bug has already been reported.
@c0rydoras c0rydoras added bug Something isn't working frontend This issue or pull request is frontend related labels May 14, 2024
@derrabauke
Copy link
Contributor

It's caused by this div which is inserted when the modal is open:
image

As it's no more the :last-child the folowing rule will take precedence:
image

Maybe not rendering the modal inPlace would fix it. 🤷‍♂️

@MitanOmar MitanOmar removed the bug Something isn't working label Jun 5, 2024
@MitanOmar
Copy link
Member

@c0rydoras i don't think that this is a bug

@c0rydoras
Copy link
Collaborator Author

How is this not a bug?

@c0rydoras
Copy link
Collaborator Author

What @derrabauke said should fix it

@c0rydoras c0rydoras added the bug Something isn't working label Jun 5, 2024
@c0rydoras c0rydoras self-assigned this Jun 5, 2024
c0rydoras added a commit to c0rydoras/timed that referenced this issue Aug 13, 2024
@c0rydoras
fix(frontend/magic-link): button is now round again when modal is opened
f20ecbe 
fix: adfinis#152
@c0rydoras c0rydoras mentioned this issue Aug 13, 2024
Merged
c0rydoras added a commit to c0rydoras/timed that referenced this issue Aug 13, 2024
@c0rydoras
fix(frontend/magic-link): button is now round again when modal is opened
cb2fd4a 
fix: adfinis#152
c0rydoras added a commit that referenced this issue Aug 13, 2024
@c0rydoras
fix(frontend/magic-link): button is now round again when modal is opened
1dc9d15 
fix: #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c0rydoras c0rydoras

Labels
bug Something isn't working frontend This issue or pull request is frontend related
Projects
timed
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(frontend/magic-link): button is now round again when modal is opened c0rydoras/timed
3 participants
@derrabauke @MitanOmar @c0rydoras