Skip to content

Commit

Permalink
chore(frontend): drop ember-wormhole in favour of in-element helper
Browse files Browse the repository at this point in the history
  • Loading branch information
c0rydoras committed Aug 19, 2024
1 parent c8ba396 commit 4e0ab57
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 17 deletions.
7 changes: 7 additions & 0 deletions frontend/app/components/sy-modal/component.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import Component from "@glimmer/component";

export default class SyModal extends Component {
get syModals() {
return document.getElementById("sy-modals");
}
}
4 changes: 2 additions & 2 deletions frontend/app/components/sy-modal/template.hbs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{#if @visible}}
<EmberWormhole @to="sy-modals">
{{#in-element this.syModals insertBefore=null}}
<SyModal::Overlay @visible={{@visible}} @onClose={{optional @onClose}}>
<div class="modal-dialog {{if @size (concat 'modal-dialog--' @size)}}">
{{yield
Expand All @@ -12,5 +12,5 @@
}}
</div>
</SyModal::Overlay>
</EmberWormhole>
{{/in-element}}
{{/if}}
1 change: 0 additions & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@
"ember-tether": "2.0.1",
"ember-truth-helpers": "3.1.1",
"ember-validated-form": "6.2.0",
"ember-wormhole": "0.6.0",
"eslint": "8.46.0",
"eslint-config-prettier": "8.8.0",
"eslint-plugin-ember": "11.12.0",
Expand Down
14 changes: 0 additions & 14 deletions frontend/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4e0ab57

Please sign in to comment.