This repository has been archived by the owner on May 13, 2024. It is now read-only.
fix(tracking-service): replace drop task modifier #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
reviewed
Feb 16, 2023
The dropTask modifier prevent multiple instance in the timesheet overview from fetching their data for the task selection dropdown. With the renewed logic, it will prevent fetching the same query multiple times.
derrabauke
force-pushed
the
fix-task-selection-loading-options
branch
from
58754fa
to
066d2a8
Compare
|
@czosel Can we merge this as temporary fix and I will open the refactoring PR in an instant? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dropTaskmodifier prevented multiple instances of theTaskSelectcomponent in the timesheet overview from fetching their data for the dropdown. With the renewed logic, it will prevent fetching the same query multiple times.