This repository has been archived by the owner on May 13, 2024. It is now read-only.
fix(remaining-effort): extract fresh info for tooltip #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabauke
force-pushed
the
fix-task-remaining-effort-refresh
branch
from
4aac1e4
to
afde2be
Compare
Yelinz
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tooltip information was stale when task related remaining effort got updated after initial loading of the task/report page.
Implementation detail
I preferred to expand the
metadata-fetcher-servicefor fetching fresh information on the project/task status instead of adding another request for updating the model in store. The meta-data request has to be made anyways and updating the model in question would only double up the request count. Feedback welcome!