Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

chore(deps): upgrade ember-infra to latest v3 #792

Merged
merged 1 commit into from
Feb 8, 2023
Merged

chore(deps): upgrade ember-infra to latest v3 #792

merged 1 commit into from
Feb 8, 2023

Conversation

derrabauke
Copy link
Contributor

Upgrades:

  • ember-source
  • ember-cli
  • ember-data

Aims to fix a bug in ember-data. Rest is drive-by.

@derrabauke derrabauke self-assigned this Feb 8, 2023
@velrest
Copy link
Contributor

velrest commented Feb 8, 2023

Is in your changes something missing? I only see a ember-data bump.

@derrabauke
Copy link
Contributor Author

Is in your changes something missing? I only see a ember-data bump.

TIL: using pnpm up <package-name>@3 with pinned dependencies needs the -L option to install the latest version of that v3 major version. 💡

velrest
velrest approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@velrest velrest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@derrabauke derrabauke merged commit 46a4bf5 into adfinis:master Feb 8, 2023
@derrabauke derrabauke deleted the chore-upgrade-ember-date branch February 8, 2023 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@velrest velrest velrest approved these changes

@Yelinz Yelinz Awaiting requested review from Yelinz

Assignees

@derrabauke derrabauke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loop(max stack size exceeded) if creating an record, whose type was not loaded yet. and ember-inspector open
2 participants
@derrabauke @velrest