This repository has been archived by the owner on May 13, 2024. It is now read-only.
fix(statistics): table sorting on header click #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabauke
force-pushed
the
fix-table-sorting-statistics
branch
2 times, most recently
from
3a357da
to
99426b1
Compare
derrabauke
force-pushed
the
fix-table-sorting-statistics
branch
from
99426b1
to
2ecc3d4
Compare
derrabauke
force-pushed
the
fix-table-sorting-statistics
branch
from
2ecc3d4
to
4b71828
Compare
derrabauke
commented
Jan 4, 2023
| @@ -214,7 +214,7 @@ | |||
| @type={{this.type}} | |||
| @missingParams={{this.missingParams}} | |||
| @ordering={{this.ordering}} | |||
| @on-ordering-change={{fn (mut this.ordering)}} | |||
| @onOrderingChange={{fn (mut this.ordering)}} | |||
There was a problem hiding this comment.
This is the actual fix of the "sorting on header click is not working".
velrest
reviewed
Jan 4, 2023
| {{else}} | ||
| <i class="fa fa-sort"></i> | ||
| {{/if}} | ||
| {{! template-lint-disable}} |
There was a problem hiding this comment.
What would template-lint criticize?
There was a problem hiding this comment.
app/components/sort-header/template.hbs
1:24 warning Interaction added to non-interactive element no-invalid-interactive
velrest
approved these changes
Jan 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.