Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

ci: adapt test workflow to pnpm setup #762

Merged
merged 1 commit into from
Jan 3, 2023
Merged

ci: adapt test workflow to pnpm setup #762

merged 1 commit into from
Jan 3, 2023

Conversation

derrabauke
Copy link
Contributor

  • add no-frozen-lockfile parameter to install step
  • deletes workflow runs on ember-octane branch
  • re-enables codecov reporting

@derrabauke derrabauke added the bug label Jan 2, 2023
@derrabauke derrabauke requested a review from trowik January 2, 2023 11:42
@derrabauke derrabauke self-assigned this Jan 2, 2023
@derrabauke
ci: adapt test workflow to pnpm setup
573a89d 
* add no-frozen-lockfile parameter to install step
* deletes workflow runs on ember-octane branch
* re-enables codecov reporting
@derrabauke
Copy link
Contributor Author

derrabauke commented Jan 2, 2023 •
edited
Loading

The --no-frozen-lockfile tries to fix this issue in the existing dependabot pr, but one has to say, that dependabot is not compatible with pnpm anyways...
For more info on the --no-frozen-lockfile paramter see: pnpm/pnpm#4151

trowik
trowik approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@trowik trowik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derrabauke derrabauke merged commit b9da066 into adfinis:master Jan 3, 2023
@derrabauke derrabauke deleted the chore-ci-pnpm-workflow-setup branch January 3, 2023 08:27
@derrabauke derrabauke mentioned this pull request Jan 3, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trowik trowik trowik approved these changes

Assignees

@derrabauke derrabauke

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabauke @trowik