Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

build: switch to pnpm #738

Merged
merged 2 commits into from
Dec 5, 2022
Merged

build: switch to pnpm #738

merged 2 commits into from
Dec 5, 2022

Conversation

derrabauke
Copy link
Contributor

@derrabauke derrabauke commented Dec 1, 2022 •
edited
Loading

Switching to pnpm resolves a couple of issues:

  • no more dependency conflicts (ember-auto-import, @embroider/macros, etc.)
  • faster install and build which accumulates a lot while this update period

This is part of #710

@derrabauke derrabauke added the maintenance Code maintenance label Dec 1, 2022
@derrabauke derrabauke added this to the ember 3.28 milestone Dec 1, 2022
@derrabauke derrabauke self-assigned this Dec 1, 2022
@derrabauke derrabauke requested a review from anehx December 1, 2022 17:34
@derrabauke derrabauke mentioned this pull request Dec 2, 2022
Merged
@derrabauke derrabauke removed the request for review from anehx December 2, 2022 13:30
@derrabauke derrabauke force-pushed the octane-pr-15 branch 3 times, most recently from d3e7008 to 46775b1 Compare December 2, 2022 14:01
@derrabauke
build: switch to pnpm
61c863d 
* remove old babel plugins which are included in @babel/preset-env
  anyways
* add override (resolution) for ember-concurrency because of
  ember-site-tour
@derrabauke derrabauke requested a review from anehx December 2, 2022 14:05
@derrabauke
Copy link
Contributor Author

@velrest @Yelinz This is the PR we discussed today. So this will be our first app trying pnpm.

@derrabauke derrabauke mentioned this pull request Dec 2, 2022
Merged
anehx
anehx reviewed Dec 5, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@derrabauke derrabauke merged commit 156e8bc into adfinis:ember-octane Dec 5, 2022
@derrabauke derrabauke deleted the octane-pr-15 branch December 5, 2022 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anehx anehx anehx approved these changes

@velrest velrest Awaiting requested review from velrest

Assignees

@derrabauke derrabauke

Labels
maintenance Code maintenance
Projects
None yet
Milestone
ember 3.28
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabauke @anehx