This repository has been archived by the owner on May 13, 2024. It is now read-only.
refactor: transform to native classes via codemod #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yelinz
approved these changes
Oct 28, 2022
| @@ -144,15 +149,17 @@ export default Component.extend({ | |||
| ); | |||
|
|
|||
| yield this["on-save"](attendance); | |||
| }).drop(), | |||
| }).drop()) | |||
| save; | |||
There was a problem hiding this comment.
Refactored tasks look really weird
Comment on lines
+17
to
+20
| return (get(this, "on-enter-viewport") ?? (() => {}))(); | ||
| } | ||
|
|
||
| return this.getWithDefault("on-exit-viewport", () => {})(); | ||
| return (get(this, "on-exit-viewport") ?? (() => {}))(); |
Comment on lines
+16
to
+22
| @(computed("current").readOnly()) | ||
| get direction() { | ||
| return getDirection(this.current); | ||
| }).readOnly(), | ||
| } | ||
|
|
||
| active: computed("current", function() { | ||
| @(computed("current").readOnly()) | ||
| get active() { |
There was a problem hiding this comment.
No need for the computed with readonly?
Comment on lines
+22
to
+25
| name = "duration"; | ||
| @tracked min = MIN_SAFE_INTEGER; | ||
| max = MAX_SAFE_INTEGER; | ||
| maxlength = null; |
| @@ -87,38 +74,38 @@ export default Component.extend({ | |||
| * @property {Number} precision | |||
| * @public | |||
| */ | |||
| precision: 15, | |||
| @tracked precision = 15; | |||
There was a problem hiding this comment.
Any reason why only this property is tracked?
Comment on lines
+8
to
10
| "on-never"() {} | ||
| "on-later"() {} | ||
| "on-start"() {} |
There was a problem hiding this comment.
These are some wild function names...
| @@ -41,7 +44,7 @@ export default Service.extend({ | |||
| * @return {Object} An object with the parsed metadata | |||
| * @public | |||
| */ | |||
| fetchSingleRecordMetadata: task(function*(type, id) { | |||
| @(task(function* (type, id) { | |||
There was a problem hiding this comment.
Quick refactor to restartableTask
| const duration = moment.duration( | ||
| moment().diff(this.get("activity.from")) | ||
| ); | ||
| @task(function* () { |
|
|
||
| /** | ||
| * Whether it is the currently selected day | ||
| * | ||
| * @property {Boolean} active | ||
| * @public | ||
| */ | ||
| active: false, | ||
| active = false; |
Thanks for the feedback! Will incorporate this after the automated codemods are done! |
https://github.com/ember-codemods/ember-no-get-with-default This is a preparation for replacing ember.get
derrabauke
force-pushed
the
octane-pr-5
branch
from
388ee9d
to
567d70b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents:
The contents of this PR start at bfa5eaa
Commits before belong to #715
Info