Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

ci: re-setup pre-commit linting #714

Merged
merged 1 commit into from
Nov 21, 2022
Merged

ci: re-setup pre-commit linting #714

merged 1 commit into from
Nov 21, 2022

Conversation

derrabauke
Copy link
Contributor

@derrabauke derrabauke commented Oct 25, 2022 •
edited
Loading

Contents:

  • setup two husky jobs (lint-staged and commitlint)

The contents of this PR start at 42deec6
Commits before belong to #713

Info

4th PR of this series.
Only merge when #713 is merged and this PR got rebased!

@derrabauke derrabauke added the maintenance Code maintenance label Oct 25, 2022
@derrabauke derrabauke self-assigned this Oct 25, 2022
@derrabauke derrabauke mentioned this pull request Oct 25, 2022
Merged
@derrabauke derrabauke mentioned this pull request Oct 26, 2022
Merged
@derrabauke
Copy link
Contributor Author

@czosel Please don't wait for the tests to become ✔️ . Turned them of for this series of PRs onto #710

@derrabauke derrabauke added this to the ember 3.28 milestone Nov 4, 2022
@derrabauke derrabauke changed the base branch from master to ember-octane November 21, 2022 15:38
czosel
czosel approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@derrabauke derrabauke merged commit 4ea98a9 into adfinis:ember-octane Nov 21, 2022
@derrabauke derrabauke deleted the octane-pr-3 branch November 21, 2022 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@czosel czosel czosel approved these changes

Assignees

@derrabauke derrabauke

Labels
maintenance Code maintenance
Projects
None yet
Milestone
ember 3.28
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabauke @czosel