Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Fix: parse queryparams for magic link as booleans, not strings #1046

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix: parse queryparams for magic link as booleans, not strings #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc04dc2
fix: parse queryparam as boolean, not string
StephanH90 Aug 8, 2023
a5345da
fix: dont use strictEqual to check currentRoute in test
StephanH90 Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/index/reports/controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export default class IndexReportController extends Controller {
@tracked task;
@tracked duration;
@tracked comment;
@tracked review;
@tracked notBillable;
@tracked review = false;
@tracked notBillable = false;

@service notify;
@service router;
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/index-reports-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ module("Acceptance | index reports", function (hooks) {
await click(`button[data-date="${tomorrow}"]`);
await click("[data-test-report-save]");

assert.strictEqual(currentURL(), `/reports?day=${tomorrow}`);
assert.ok(currentURL().includes(`/reports?day=${tomorrow}`));
assert.dom("[data-test-report-row]").exists({ count: 6 });
});
});
Loading