Merge pull request #798 from derrabauke/fix-customer-statistics-criteria

fix(customer-statistics): require fromDate param
adfinis · Feb 9, 2023 · 696a7b2 · 696a7b2
2 parents 55bc87c + 3ebee3f
commit 696a7b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/statistics/controller.js b/app/statistics/controller.js
@@ -20,7 +20,7 @@ const deserializeMoment = (momentString) =>
 const TYPES = {
   year: { include: "", requiredParams: [] },
   month: { include: "", requiredParams: [] },
-  customer: { include: "", requiredParams: [] },
+  customer: { include: "", requiredParams: ["fromDate"] },
   project: {
     include: "customer",
     requiredParams: ["customer"],

diff --git a/tests/acceptance/statistics-test.js b/tests/acceptance/statistics-test.js
@@ -40,7 +40,7 @@ module("Acceptance | statistics", function (hooks) {
   });
 
   test("can view statistics by customer", async function (assert) {
-    await visit("/statistics?type=customer");
+    await visit("/statistics?type=customer&fromDate=1900-01-01");
 
     assert.dom("thead > tr > th").exists({ count: 3 });
     assert.dom("tbody > tr").exists({ count: 5 });