fix(statistics): except ordering and type from qp reset

adfinis · Oct 31, 2023 · 20df93c · 20df93c
1 parent e850fa8
commit 20df93c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/app/controllers/qpcontroller.js b/app/controllers/qpcontroller.js
@@ -17,9 +17,9 @@ export default class ControllersQPControllerController extends Controller {
     });
   }
 
-  resetQueryParams({ except = [] }) {
+  resetQueryParams(options = { except: [] }) {
     this.queryParams.forEach((qp) => {
-      if (!except.includes(qp)) {
+      if (!options.except.includes(qp)) {
         this[qp] = this.#defaults[qp];
       }
     });

diff --git a/app/statistics/controller.js b/app/statistics/controller.js
@@ -128,7 +128,10 @@ export default class StatisticsController extends QPController {
 
   get appliedFilters() {
     return Object.keys(queryParamsState(this)).filter((key) => {
-      return queryParamsState(this)[key]?.changed && key !== "type";
+      return (
+        queryParamsState(this)[key]?.changed &&
+        !["type", "ordering"].includes(key)
+      );
     });
   }
 
@@ -187,6 +190,6 @@ export default class StatisticsController extends QPController {
 
   @action
   reset() {
-    this.resetQueryParams({ except: ["type"] });
+    this.resetQueryParams({ except: ["ordering", "type"] });
   }
 }