This repository has been archived by the owner on May 13, 2024. It is now read-only.
feat(settings): add DATA_UPLOAD_MAX_NUMBER_FIELDS to env #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
winged
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
LGTM, however setting this to an unreasonable large amount can make us vulnerable to DOS (in theory). But given that we allow authenticated requests only anyway, we could also just set it to None and have Django skip the field count check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value should be customizable as there are big projects that have a lot of tasks, tasks and project assignees. In these cases the amount of fields exceeds the default value of 1000, which makes saving any changes on that project impossible.
I'll add the variable to our helm chart as well, so we can change it at any time.