Fix bug when executing snapshot update #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which directly publish repos
| snap_name = snapshot_spec_to_name(cfg, snap) | ||
| if snap_name in affected_snapshots: | ||
| return True | ||
| except KeyError: |
There was a problem hiding this comment.
Thanks a lot for the PR please consider adding # pragma: no cover or writing a test for the except case.
except KeyError: # pragma: no coverYou can run make test to see if it is really fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #18. When executing
snapshot updatepyaptly fails if it encounters a publish endpoint, which directly publishes repos without snapshots.