chore(infra-apps): update argocd to 4.0.*#604
Merged
Conversation
Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
vmaillot
approved these changes
Mar 17, 2022
hairmare
approved these changes
Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
infra-appsto use argocd chart version4.0.*With the 4.0 release of the chart
controller.enableStatefulSetis true per default to enable HA mode. If you want to keep using a deploymet you need to set it to false.Also both the ApplicationSet and Notifications controller are now deployed as part of Argo CD, this will need additional resources in the cluster.
Please tune
applicationSet.metricsandapplicationSet.resourcesas well asnotifications.metrics,notifications.resources, and (maybe)notifications.argocdUrlduring this upgrade at the very least.Issues
n/a
Changes
Chart changes
https://github.com/argoproj/argo-helm/tree/master/charts/argo-cd#400-and-above
App changes
https://github.com/argoproj/argo-cd/blob/v2.3.0/docs/operator-manual/upgrading/2.2-2.3.md
Checklist
pre-commit rundocs/Signed-off-by: Toni Tauro toni.tauro@adfinis.com