fix(validated-input): rewrite to glimmer and support nested changesets #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velrest
force-pushed
the
fix-nested-changeset
branch
3 times, most recently
from
44edf63
to
759eec2
Compare
|
This PR will probably drop support for ember |
velrest
force-pushed
the
fix-nested-changeset
branch
5 times, most recently
from
9b6ffd4
to
e929f3d
Compare
Previously the computed `_val` did not recompute if `name` was a nested property like `titleObject.de`. This is solved with using getters. Example twiddle: https://ember-twiddle.com/9cb7325ea5aa8983b5ea871366014d2d?openFiles=controllers.application%5C.js%2C#docs():
velrest
force-pushed
the
fix-nested-changeset
branch
from
e929f3d
to
89e4088
Compare
BREAKING CHANGE: This drops support for Ember LTS 3.16 and `ember-changeset` < 3.0.0 and `ember-changeset-validations` < 3.0.0
velrest
force-pushed
the
fix-nested-changeset
branch
from
89e4088
to
1e962a1
Compare
anehx
reviewed
Apr 30, 2021
velrest
force-pushed
the
fix-nested-changeset
branch
from
2148c64
to
e1a987c
Compare
BREAKING CHANGE: drop node v10 support since v10 has reached EOL
velrest
force-pushed
the
fix-nested-changeset
branch
from
e1a987c
to
baaf13c
Compare
anehx
approved these changes
May 18, 2021
velrest
pushed a commit
that referenced
this pull request
May 19, 2021
# [4.0.0](v3.0.3...v4.0.0) (2021-05-19) ### Bug Fixes * **validated-input:** rewrite to glimmer and support nested changesets ([#581](#581)) ([2f3e7c5](2f3e7c5)) ### BREAKING CHANGES * **validated-input:** This drops support for Ember LTS 3.16 and `ember-changeset` < 3.0.0 and `ember-changeset-validations` < 3.0.0 * refactor(validated-input): refactor dynamic component call to angle-brackets * chore(*): drop node v10 support * **validated-input:** drop node v10 support since v10 has reached EOL * fix(themed-component): convert array to string befor using in key path
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the computed
_valdid not recompute ifnamewas a nested property liketitleObject.de.This is solved with using getters. Example twiddle:
https://ember-twiddle.com/9cb7325ea5aa8983b5ea871366014d2d?openFiles=controllers.application%5C.js%2C#docs():