Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependencies #392

Merged
merged 1 commit into from
Nov 3, 2020
Merged

chore: update dependencies #392

merged 1 commit into from
Nov 3, 2020

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented Oct 30, 2020

Update ember source to 3.22

@Yelinz Yelinz requested a review from anehx October 30, 2020 10:20
anehx
anehx requested changes Nov 2, 2020
View reviewed changes
Copy link
Member

@anehx anehx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however please mark it as chore! and as breaking change correctly: BREAKING CHANGE: at the beginning of the commit message. Also, state clearly what the breaking change is e.g. "This drops support for Ember LTS 3.12"

https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-both--and-breaking-change-footer

.dependabot/config.yml Show resolved Hide resolved
@Yelinz
Copy link
Member Author

Yelinz commented Nov 2, 2020

Looks good, however please mark it as chore! and as breaking change correctly: BREAKING CHANGE: at the beginning of the commit message. Also, state clearly what the breaking change is e.g. "This drops support for Ember LTS 3.12"

https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-both--and-breaking-change-footer

I tried using chore! but the commit linter said it was invalid

@Yelinz
Copy link
Member Author

Yelinz commented Nov 2, 2020

Seems like we have to update out semantic release package to use newer versions of commitlint for the chore! style

@Yelinz
chore!: update dependencies
855edda 
BREAKING CHANGE: This drops support for Ember LTS 3.8 and 3.12
@Yelinz
Copy link
Member Author

Yelinz commented Nov 3, 2020

@anehx Updated our semantic release config and now the ! syntax in the commit works

@Yelinz Yelinz merged commit 2664399 into adfinis:master Nov 3, 2020
@Yelinz Yelinz deleted the update branch November 3, 2020 12:49
github-actions bot pushed a commit that referenced this pull request Nov 6, 2020
@semantic-release-bot
chore(release): 3.0.0
efc9032 
# [3.0.0](v2.0.0...v3.0.0) (2020-11-06)

* chore!: update dependencies (#392) ([2664399](2664399)), closes [#392](#392)

### Bug Fixes

* **deps:** bump ember-auto-import from 1.6.0 to 1.7.0 ([#394](#394)) ([9d464e4](9d464e4))
* **select:** pass promptIsSelectable to select ([e739b4f](e739b4f))

### BREAKING CHANGES

* This drops support for Ember LTS 3.8 and 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anehx anehx anehx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yelinz @anehx