WIP: Add management command to clean up unreferenced bucket objects #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinwe-adfinis
commented
Sep 3, 2024
Comment on lines
+39
to
+40
| # TODO: delete for real | ||
| # s3_client.delete_object(Bucket=S3_BUCKET, Key=fname) |
There was a problem hiding this comment.
This should be uncommented before merge.
There was a problem hiding this comment.
As discussed: Lets add a flag like --commit instead, and do the dry run by default.
martinwe-adfinis
force-pushed
the
feat/cleanup-objects
branch
from
4b04ca2 to
a8fd0a2
Compare
martinwe-adfinis
force-pushed
the
feat/cleanup-objects
branch
from
a8fd0a2 to
db6b602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.