Eslint config: add new eslint-plugin-fbt
#3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtnzlml
force-pushed
the
eslint_config_fbt_plugin
branch
from
095d0bd to
7f98089
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
eslint_config_fbt_plugin
branch
from
7f98089 to
d7ed4db
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
eslint_config_fbt_plugin
branch
from
d7ed4db to
838fd56
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
eslint_config_fbt_plugin
branch
from
838fd56 to
625ebce
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
eslint_config_fbt_plugin
branch
from
625ebce to
deac855
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
eslint_config_fbt_plugin
branch
from
deac855 to
f75f022
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
eslint_config_fbt_plugin
branch
from
f75f022 to
8cf212f
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
eslint_config_fbt_plugin
branch
from
8cf212f to
19b80a2
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
tbergquist-godaddy
approved these changes
Jan 22, 2022
This commit adds a new Eslint plugin for FBT (optional via FBT preset) with one rule enabled: `fbt/no-empty-strings`. I decided to turn off the second available rule because there were some situations where I was not sure what should be the solution.
mrtnzlml
force-pushed
the
eslint_config_fbt_plugin
branch
from
19b80a2 to
f6a4e57
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new Eslint plugin for FBT (optional via FBT preset) with one rule enabled:
fbt/no-empty-strings. I decided to turn off the second available rule because there were some situations where I was not sure what should be the solution.