-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master branch merged and fixed #223
Closed
patrickschaper
wants to merge
16
commits into
addyosmani:library-options
from
patrickschaper:library-options
Closed
Master branch merged and fixed #223
patrickschaper
wants to merge
16
commits into
addyosmani:library-options
from
patrickschaper:library-options
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better remote handling (#196) * use node's url parser
* Support for passing CSS files as Vinyl objects. Critical can now process CSS files passed to the library as an array of Vinyl file objects in opts.css, so they do not need to be written to disk before processing. * Add documentation for `css` option to README.md.
# Conflicts fixed # README.md # cli.js # index.js # lib/core.js # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master branch was merged and all conflicts fixed.
Tests were successful.
library-options branch can now be merged into master branch