Fix issue neekey#11 where spaces in commands are not escaped or surro…

…unded by quotations

This is done by calling /proc/<PID>/cmdline where the arguments are separated by NUL characters rather than spaces. This can then be split up and parsed.

.gitignore

@@ -3,4 +3,5 @@
 *.iws
 **/node_modules
 node_modules
-.idea
+.idea
+.vscode/

lib/index.js

@@ -1,6 +1,7 @@
 var ChildProcess = require('child_process');
 var IS_WIN = process.platform === 'win32';
 var TableParser = require('table-parser');
+var fs = require('fs');
 /**
  * End of line.
  * Basically, the EOL should be:
@@ -273,6 +274,21 @@ function formatOutput(data) {
     var ppid = ( d.PPID && d.PPID[0] ) || ( d.ParentProcessId && d.ParentProcessId[0] ) || undefined;
 
     if (pid && cmd) {
+      // console.log('Print `%j`', cmd)
+      if (!IS_WIN && cmd.length > 1) {
+        // console.log('Print yes `%j`', cmd)
+        try {
+          cmd = fs.readFileSync('/proc/' + pid + '/cmdline', 'utf8').split('\0');
+        }
+        catch (err) {
+          if (err.code !== 'ENOENT') {
+            throw err; 
+          }
+        }
+        // console.log('data: `%j`', data);
+        // cmd = fs.readFileSync('/proc/' + pid + '/cmdline').split('\0');
+      }
+
       var command = cmd[0];
       var args = '';
 

test/test.js

@@ -5,6 +5,7 @@ var Path = require('path');
 var Sinon = require('sinon');
 
 var serverPath = Path.resolve(__dirname, './node_process_for_test.js');
+var serverPathSpace = Path.resolve(__dirname, './with space/sleep with space');
 var UpperCaseArg = '--UPPER_CASE';
 var child = null;
 var pid = null;
@@ -197,3 +198,23 @@ describe('test', function () {
     });
   });
 });
+
+// don't run on Windows
+(process.platform === 'win32' ? describe.skip : describe)('test command with space', function () { 
+  before(function () {
+    child = CP.spawn(serverPathSpace);
+    pid = child.pid;
+  });
+
+  afterEach(killProcess);
+
+  it('by command with space in path', function (done) {
+    PS.lookup({pid: pid}, function (err, list) {
+      assert.equal(list.length, 1);
+      assert.equal(list[0].pid, pid);
+      assert.equal(list[0].command, '/bin/bash');
+      assert.equal(list[0].arguments[0], serverPathSpace);
+      done();
+    });
+  });
+});

test/with space/sleep with space

@@ -0,0 +1,2 @@
+#!/bin/bash
+/bin/sleep 5