crypto: fix KeyObject garbage collection

These objects don’t hold any resources on the event loop, so they should be weak objects that can be garbage collected when nothing refers to them anymore. PR-URL: nodejs#35481 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax · Oct 3, 2020 · f5c7aa0 · f5c7aa0
1 parent 35b17d9
commit f5c7aa0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/node_crypto.h b/src/node_crypto.h
@@ -519,7 +519,9 @@ class NativeKeyObject : public BaseObject {
                   v8::Local<v8::Object> wrap,
                   const std::shared_ptr<KeyObjectData>& handle_data)
     : BaseObject(env, wrap),
-      handle_data_(handle_data) {}
+      handle_data_(handle_data) {
+    MakeWeak();
+  }
 
   std::shared_ptr<KeyObjectData> handle_data_;
 };