buffer: also alias BigUInt methods

These were overlooked in 5864fca because of the extra `Big` in the name. :) Refs: nodejs#34729
addaleax · Aug 28, 2020 · 03c61a7 · 03c61a7
1 parent 8ec3b55
commit 03c61a7
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/doc/api/buffer.md b/doc/api/buffer.md
@@ -1379,6 +1379,10 @@ values.
 added:
  - v12.0.0
  - v10.20.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/?????
+    description: This function is also available as `buf.readBigUint64BE()`.
 -->
 
 * `offset` {integer} Number of bytes to skip before starting to read. Must
@@ -1400,6 +1404,10 @@ console.log(buf.readBigUInt64BE(0));
 added:
  - v12.0.0
  - v10.20.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/?????
+    description: This function is also available as `buf.readBigUint64LE()`.
 -->
 
 * `offset` {integer} Number of bytes to skip before starting to read. Must
@@ -2304,6 +2312,10 @@ console.log(buf);
 added:
  - v12.0.0
  - v10.20.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/?????
+    description: This function is also available as `buf.writeBigUint64BE()`.
 -->
 
 * `value` {bigint} Number to be written to `buf`.
@@ -2327,6 +2339,10 @@ console.log(buf);
 added:
  - v12.0.0
  - v10.20.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/?????
+    description: This function is also available as `buf.writeBigUint64LE()`.
 -->
 
 * `value` {bigint} Number to be written to `buf`.

diff --git a/lib/internal/buffer.js b/lib/internal/buffer.js
@@ -952,10 +952,14 @@ class FastBuffer extends Uint8Array {}
 function addBufferPrototypeMethods(proto) {
   proto.readBigUInt64LE = readBigUInt64LE,
   proto.readBigUInt64BE = readBigUInt64BE,
+  proto.readBigUint64LE = readBigUInt64LE,
+  proto.readBigUint64BE = readBigUInt64BE,
   proto.readBigInt64LE = readBigInt64LE,
   proto.readBigInt64BE = readBigInt64BE,
   proto.writeBigUInt64LE = writeBigUInt64LE,
   proto.writeBigUInt64BE = writeBigUInt64BE,
+  proto.writeBigUint64LE = writeBigUInt64LE,
+  proto.writeBigUint64BE = writeBigUInt64BE,
   proto.writeBigInt64LE = writeBigInt64LE,
   proto.writeBigInt64BE = writeBigInt64BE,
 

diff --git a/test/parallel/test-buffer-writeuint.js b/test/parallel/test-buffer-writeuint.js
@@ -222,7 +222,8 @@ const assert = require('assert');
 }
 
 for (const fn of [
-  'UInt8', 'UInt16LE', 'UInt16BE', 'UInt32LE', 'UInt32BE', 'UIntLE', 'UIntBE'
+  'UInt8', 'UInt16LE', 'UInt16BE', 'UInt32LE', 'UInt32BE', 'UIntLE', 'UIntBE',
+  'BigUInt64LE', 'BigUInt64BE',
 ]) {
   const p = Buffer.prototype;
   const lowerFn = fn.replace(/UInt/, 'Uint');