Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] #3596

Merged
merged 2 commits into from
Sep 11, 2024
Merged

[email protected] #3596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b200dac
[email protected]
nstepien Sep 11, 2024
e83616f
adopt noCheck in tsconfig.lib.json
nstepien Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"react-router-dom": "^6.11.1",
"rollup": "^4.0.2",
"rollup-plugin-postcss": "^4.0.2",
"typescript": "~5.5.2",
"typescript": "~5.6.2",
"vite": "^5.3.3",
"vitest": "^2.0.3"
},
Expand Down
1 change: 0 additions & 1 deletion tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"composite": true,
"emitDeclarationOnly": true,
"exactOptionalPropertyTypes": true,
"incremental": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It defaults to true when composite is enabled

"isolatedModules": true,
"jsx": "react-jsx",
"lib": ["ESNext"],
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"compilerOptions": {
"composite": false,
"declaration": true,
"incremental": false,
"lib": ["ESNext", "DOM", "DOM.Iterable", "DOM.AsyncIterable"],
"noCheck": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With false:

npx tsc -p tsconfig.lib.json --diagnostics

Files:              134
Lines:            72766
Identifiers:      69468
Symbols:         170712
Types:            44962
Instantiations:  304386
Memory used:    199413K
I/O read:         0.02s
I/O write:        0.01s
Parse time:       0.33s
Bind time:        0.13s
Check time:       1.48s
Emit time:        0.08s
Total time:       2.02s

With true:

npx tsc -p tsconfig.lib.json --diagnostics

Files:             134
Lines:           72766
Identifiers:     69468
Symbols:         43376
Types:            1505
Instantiations:   1445
Memory used:    90150K
I/O read:        0.02s
I/O write:       0.01s
Parse time:      0.34s
Bind time:       0.12s
Check time:      0.00s
Emit time:       0.21s
Total time:      0.67s

"outDir": "./.cache/lib"
},
"files": ["src/index.ts"]
Expand Down