Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pass isRowSelectionDisabled prop to the div #3593

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Do not pass isRowSelectionDisabled prop to the div #3593

merged 3 commits into from
Sep 5, 2024

Conversation

amanmahajan7
Copy link
Contributor

Fixes

Warning: React does not recognize the `%s` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `%s` instead. If you accidentally passed it from a parent component, remove it from the DOM element.%s isRowSelectionDisabled isrowselectiondisabled

@amanmahajan7 amanmahajan7 self-assigned this Sep 5, 2024
amanmahajan7
amanmahajan7 commented Sep 5, 2024
View reviewed changes
src/GroupRow.tsx
@@ -42,6 +42,7 @@ function GroupedRow<R, SR>({
gridRowStart,
groupBy,
toggleGroup,
isRowSelectionDisabled,
...props
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spreading props can be dangerous sometimes. Wonder if we should avoid it if possible

@amanmahajan7 amanmahajan7 marked this pull request as ready for review September 5, 2024 16:51
@amanmahajan7 amanmahajan7 enabled auto-merge (squash) September 5, 2024 16:55
@amanmahajan7 amanmahajan7 merged commit b0ba55f into main Sep 5, 2024
2 checks passed
@amanmahajan7 amanmahajan7 deleted the am-fix-warning branch September 5, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstepien nstepien nstepien approved these changes

Assignees

@amanmahajan7 amanmahajan7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanmahajan7 @nstepien